Re: [Kicad-developers] Migrating old designs best practice

2017-11-23 Thread hauptmech
I can confirm unconnected wires. It may be worth noting that I did not preserve the -cache.lib file when I archived the design. I also had an issue with an old asymmetric diode footprint having its anode and cathode reversed when I used it in a new design. If pin numbers in the library got

Re: [Kicad-developers] [PATCH] Add live footprint filtering in modview window

2017-11-23 Thread Wayne Stambaugh
Oliver, Understood. I'm fine with pushing this off until version 6. I'm pretty busy myself. I'm guessing there is a lot of common code that could be refactored. Given that the new symbol library editor already has a tree view, I wonder if the symbol library viewer is even necessary. After

Re: [Kicad-developers] Getting kicad to work with wxPython Phoenix

2017-11-23 Thread Wayne Stambaugh
On 11/23/2017 03:32 PM, miles mccoo wrote: > Thanks all, for the replies > > Thank you for merging my patch. > > I'm pleased to read that the Kicad takes the python interface seriously. > > Abstraction layer. I've considered writing one or at least submitting > patches to move in that

[Kicad-developers] [PATCH] support "disable autopan" with gal canvas

2017-11-23 Thread Julius Schmidt
This patch adds support for the "disable autopan" feature to the gal canvas. I'm not entirely sure this is the best way to do it, there is already an "autopan setting" but it is actually used to indicate whether the current tool uses autopan. fixes

Re: [Kicad-developers] [PATCH] Math expression support for pad editor.

2017-11-23 Thread Michael Geselbracht
Hi Russell, the class can handle variables in two ways: NumericEvaluator eval; 1. Assignment within expressions: eval.process("x=1; y=5"); 2. Assignment from c++ code: eval.setVar("posx", -3.4); So it would be up to the dialog to add a variable to an eval object within a "focus lost" or "value

Re: [Kicad-developers] [PATCH] Fix aperture macro hit testing (Fixes lp:1730249)

2017-11-23 Thread Nick Østergaard
Thanks! 2017-11-23 10:20 GMT+01:00 Maciej Sumiński : > For the record: an updated version of this patch has been already > comitted. Thank you Jon! > > Regards, > Orson > > On 11/11/2017 11:22 PM, Jon Evans wrote: > > Hi all, > > > > This patch fixes a bug reported by

Re: [Kicad-developers] Getting kicad to work with wxPython Phoenix

2017-11-23 Thread Nick Østergaard
I guess this is the same idea as with https://github.com/KiCad/kicad-python 2017-11-23 19:28 GMT+01:00 Greg Smith : > "I was simply afraid that we > may spent a lot of time petting the SWIG interface, which we will nuke > it and start from scratch because of inevitable

Re: [Kicad-developers] [PATCH] Math expression support for pad editor.

2017-11-23 Thread Michael Geselbracht
Hello Jean-Pierre, I need to remember that one. But you are right of course. I will add some comments and examples. - Michael On Thu, Nov 23, 2017 at 8:54 PM, jp charras wrote: > Le 23/11/2017 à 20:45, Michael Geselbracht a écrit : > > Hi, > > I have replaced the

Re: [Kicad-developers] Getting kicad to work with wxPython Phoenix

2017-11-23 Thread Wayne Stambaugh
On 11/23/2017 12:04 PM, Maciej Sumiński wrote: > Hi Miles, > > On 11/23/2017 04:17 PM, miles mccoo wrote: >> In a recent thread >> on this list, >> it was mentioned that kicad may need to drop support for SWIG/Python due to >> wx and

Re: [Kicad-developers] Migrating old designs best practice

2017-11-23 Thread Wayne Stambaugh
I stand corrected. I just looked and pin numbers are checked by position so swapped pins should get rescued. What isn't rescued is pins that changed length which is a bit surprising since that would possibly leave unconnected wires. I'm not sure why it was done this way but I guess I'll have to

Re: [Kicad-developers] Getting kicad to work with wxPython Phoenix

2017-11-23 Thread Carsten Schoenert
Am 23.11.2017 um 17:28 schrieb Wayne Stambaugh: ... >> The short version: Kicad will probably want to wait to move to the >> Phoenix version of wxPython. > > Not until they are package in Debian stable. This is my litmus test for > availability of new dependencies. I do not want kicad to be in

Re: [Kicad-developers] Getting kicad to work with wxPython Phoenix

2017-11-23 Thread miles mccoo
Thanks all, for the replies Thank you for merging my patch. I'm pleased to read that the Kicad takes the python interface seriously. Abstraction layer. I've considered writing one or at least submitting patches to move in that direction[1] but I got sidetracked trying to document what's already

Re: [Kicad-developers] [PATCH] Math expression support for pad editor.

2017-11-23 Thread Russell Oliver
Hi All, Just a query for Michael: can your parser be modified to include references to dialog variables, ie while writing an expression for y axis position, using the label posx or something would refer to the value currently within that text box? Kind Regards Russell On 24 Nov 2017 06:54, "jp

Re: [Kicad-developers] [PATCH] Math expression support for pad editor.

2017-11-23 Thread jp charras
Le 23/11/2017 à 20:45, Michael Geselbracht a écrit : > Hi, > I have replaced the useless file info comments by a GPLv3 header  in order to > make my "libeval" code > license-wise compatible to the Kicad project. > >  - Michael > > Thanks Michael, Could you add a bit of comments? Currently

Re: [Kicad-developers] Getting kicad to work with wxPython Phoenix

2017-11-23 Thread Greg Smith
"I was simply afraid that we may spent a lot of time petting the SWIG interface, which we will nuke it and start from scratch because of inevitable switch to Phoenix." I agree. I would suggest that the Python API is not quite stable enough to freeze the API. If we desire a stable interface/API,

Re: [Kicad-developers] Getting kicad to work with wxPython Phoenix

2017-11-23 Thread Maciej Sumiński
Hi Miles, On 11/23/2017 04:17 PM, miles mccoo wrote: > In a recent thread > on this list, > it was mentioned that kicad may need to drop support for SWIG/Python due to > wx and wxPython limitations. > > Perhaps I misinterpreted what

Re: [Kicad-developers] [PATCH] Math expression support for pad editor.

2017-11-23 Thread Maciej Sumiński
Just to be clear, these patches are not critical for the feature freeze. If I manage to get them merged before the freeze is announced - cool, otherwise we will have a reward for our dedicated nightly build testers in v6. Regards, Orson On 11/23/2017 04:28 PM, Maciej Sumiński wrote: > Ok, that

Re: [Kicad-developers] Getting kicad to work with wxPython Phoenix

2017-11-23 Thread Tomasz Wlostowski
On 23/11/17 16:17, miles mccoo wrote: > > PS - AFAIK, the patch that triggered mention of dumping python due to > wxPython still hasn't been denied or merged. :-) > https://lists.launchpad.net/kicad-developers/msg31700.html > > Hi Miles, I just committed your patch. Thanks for your

Re: [Kicad-developers] Getting kicad to work with wxPython Phoenix

2017-11-23 Thread Wayne Stambaugh
On 11/23/2017 10:17 AM, miles mccoo wrote: > > In a recent thread > on this > list, it was mentioned that kicad may need to drop support for > SWIG/Python due to wx and wxPython limitations. > > Perhaps I misinterpreted what was said.

Re: [Kicad-developers] [PATCH] Add live footprint filtering in modview window

2017-11-23 Thread Wayne Stambaugh
Oliver, It seems to work but I found one issue that will certainly confuse users. Footprint libraries are loaded on demand so until you actually select a library in the viewer, there are no footprints to filter. Even after you select a library, only the footprints in the selected library are

Re: [Kicad-developers] Migrating old designs best practice

2017-11-23 Thread Nick Østergaard
Maybe I am mistaken then. 2017-11-23 13:21 GMT+01:00 Wayne Stambaugh : > On 11/22/2017 11:02 PM, hauptmech wrote: > > When opening an old design I noticed that the C and R symbol pin nodes > > changed position (I'm guessing other symbols as well), breaking the > >

Re: [Kicad-developers] [PATCH] Math expression support for pad editor.

2017-11-23 Thread Maciej Sumiński
Ok, that is good news. Would you share the files licensed under GPLv3? I think I can handle the rest of potential problems. Regards, Orson On 11/23/2017 04:03 PM, Michael Geselbracht wrote: > Hi, > these files were written by me. The comment blocks at the top are generated > by Eclipse ("let" is

[Kicad-developers] Getting kicad to work with wxPython Phoenix

2017-11-23 Thread miles mccoo
In a recent thread on this list, it was mentioned that kicad may need to drop support for SWIG/Python due to wx and wxPython limitations. Perhaps I misinterpreted what was said. It's my perception that the kicad team doesn't see the

Re: [Kicad-developers] [PATCH] Math expression support for pad editor.

2017-11-23 Thread Wayne Stambaugh
Michael, All source code in kicad must have a license statement and that license must be compatible with the GPL3+. This is mandatory to minimize the possibility of legal repercussions. Cheers, Wayne On 11/23/2017 10:03 AM, Michael Geselbracht wrote: > Hi, > these files were written by me.

Re: [Kicad-developers] [PATCH] Math expression support for pad editor.

2017-11-23 Thread Michael Geselbracht
Hi, these files were written by me. The comment blocks at the top are generated by Eclipse ("let" is my login name). I am afraid that the coding style is about the opposite of the rules for Kicad. But if you can use the code feel free to do so. The current implementation has some issues: 1. The

Re: [Kicad-developers] [PATCH] Add live footprint filtering in modview window

2017-11-23 Thread Wayne Stambaugh
Oops! Wrong email. Thanks for looking at this. On 11/23/2017 08:48 AM, Oliver Walters wrote: > Wayne, > > I think you meant to respond to the other thread. But good point, I > haven't fixed the step s-expr reader. Why doesn't this use the same > code? Anyway, I'll have a look. > > On Fri, Nov

Re: [Kicad-developers] [PATCH] Add live footprint filtering in modview window

2017-11-23 Thread Wayne Stambaugh
Oliver, Have you tested the impact of these changes on the step exporter? I'm not sure it will understand the offset keyword and the step export will have incorrect model offsets. Please verify this before I commit these patches. If it creates a lot of work to correct, I'm thinking we should

Re: [Kicad-developers] [PATCH] Math expression support for pad editor.

2017-11-23 Thread Maciej Sumiński
We still do not have the feature freeze, so there is still a chance to shove it to the master branch. I feel a bit uneasy about exprtk (over 1 MB header file), but Michael's parser approach seems like a good solution to me. We can extend it later as the lemon format is not very complex. I took

[Kicad-developers] Tweaks to about dialog

2017-11-23 Thread Oliver Walters
As mentioned in previous thread, I have made some slight changes to the About dialog. 1. Wording / link tweaks 2. Removed references to outdated links (now better served from the kicad-pcb.org site) 3. Removed "artists" tab - very outdated, 3D models are now community contributed I have also

Re: [Kicad-developers] Migrating old designs best practice

2017-11-23 Thread Wayne Stambaugh
On 11/22/2017 11:02 PM, hauptmech wrote: > When opening an old design I noticed that the C and R symbol pin nodes > changed position (I'm guessing other symbols as well), breaking the > schematic. Did the people who changed these symbols have a plan for > migrating old designs? Is the 'rescue'

Re: [Kicad-developers] Recent eeschema changes

2017-11-23 Thread Wayne Stambaugh
On 11/22/2017 10:42 PM, hauptmech wrote: > On 23/11/17 10:51, Wayne Stambaugh wrote: >> On 11/22/2017 4:46 PM, hauptmech wrote: >>> On 23/11/17 07:03, Julius Schmidt wrote: On Wed, 22 Nov 2017, Andy Peters wrote: > This “touching” of projects occurs with more applications than I can

Re: [Kicad-developers] [PATCH] Fix for 3D model offset

2017-11-23 Thread Oliver Walters
23 // EDA_TEXT refactor, moved 'hide' //#define SEXPR_BOARD_FILE_VERSION20170920 // long pad names and custom pad shape //#define SEXPR_BOARD_FILE_VERSION20170922 // Keepout zones can exist on multiple layers -#define SEXPR_BOARD_FILE_VERSION 20171114 // Save 3D model offset in mm, ins

Re: [Kicad-developers] Recent eeschema change

2017-11-23 Thread Clemens Koller
Hi! On 2017-11-23 09:53, Julius Schmidt wrote: > It definitely modifies files, as is obvious from the code. > for( SCH_SCREEN* screen = schematic.GetFirst(); screen; screen = > schematic.GetNext() ) > SaveEEFile( screen, false, CREATE_BACKUP_FILE ); > > is called

Re: [Kicad-developers] [PATCH] Fix for 3D model offset

2017-11-23 Thread easyw
I think the master branch already has enough new features to make its output incompatible with v4. 'Offset' approach seems the easiest and cleanest solution IMHO. the 'offset' thing is creating a stopper for kicad 4 release as well as i.e. rounded rectangle pad does... kicad 4 just would stop

Re: [Kicad-developers] [PATCH] Fix for 3D model offset

2017-11-23 Thread jp charras
Le 23/11/2017 à 11:25, Oliver Walters a écrit : > Orson, Wayne, > > I would agree. Please find attached a patch that implements "offset" Hi Oliver, Because all our footprints in libraries have the "offset" set to O,O,O, (the default value) if could be worth to export the offset only if it is

Re: [Kicad-developers] [PATCH] Fix for 3D model offset

2017-11-23 Thread Oliver Walters
m_out->Print( aNestLevel+2, "(offset (xyz %s %s %s))\n", Double2Str( bs3D->m_Offset.x ).c_str(), Double2Str( bs3D->m_Offset.y ).c_str(), Double2Str( bs3D->m_Offset.z ).c_str() ); diff --gi

Re: [Kicad-developers] Recent eeschema changes

2017-11-23 Thread Marco Ciampa
On Wed, Nov 22, 2017 at 12:04:10PM -0500, Kevin Cozens wrote: > On 2017-11-22 03:16 AM, Julius Schmidt wrote: > >It seems the current origin/master will modify schematic files on disk > >just by opening them -- even if I opt out of the remap tool. > > There is also another subtle bug you can hit

Re: [Kicad-developers] [PATCH] Fix aperture macro hit testing (Fixes lp:1730249)

2017-11-23 Thread Maciej Sumiński
For the record: an updated version of this patch has been already comitted. Thank you Jon! Regards, Orson On 11/11/2017 11:22 PM, Jon Evans wrote: > Hi all, > > This patch fixes a bug reported by Nick in GerbView GAL, where aperture > macro hit testing wasn't quite right. > >

Re: [Kicad-developers] Recent eeschema change

2017-11-23 Thread Julius Schmidt
It definitely modifies files, as is obvious from the code. for( SCH_SCREEN* screen = schematic.GetFirst(); screen; screen = schematic.GetNext() ) SaveEEFile( screen, false, CREATE_BACKUP_FILE ); is called before the dialog box appears. Moving that into the case

Re: [Kicad-developers] [PATCH] Allow items to be moved from all anchor points

2017-11-23 Thread Maciej Sumiński
Hi Jose, Thank you for fixing the problem. I have just pushed your patch to the master branch. Regards, Orson On 11/20/2017 05:29 PM, José Ignacio wrote: > A change in commit 57310001350 caused kicad to stop allowing users > to move items like footprints, arcs and lines using anchors other >

Re: [Kicad-developers] [PATCH] Fix for 3D model offset

2017-11-23 Thread Maciej Sumiński
I think the master branch already has enough new features to make its output incompatible with v4. 'Offset' approach seems the easiest and cleanest solution IMHO. Cheers, Orson On 11/22/2017 11:16 PM, Oliver Walters wrote: > I understand this will break "forwards compatibility" if opening a v5