Re: [Kicad-developers] [PATCH] Fix some performance issues

Camille, I merged your patches into the kicad development branch. Everything seemed to work fine although I didn't notice much a performance gain. That being said, thanks for fixing all of the places where we should have been passing values by reference instead of push the entire object on the

Re: [Kicad-developers] Kicad from scratch: pcbnew: cannot use ~/ for home directory for KISYS3DMOD path?

https://github.com/KiCad/kicad-source-mirror/blob/610ff7485ff8659cec69568a734e059429aca151/common/pgm_base.cpp You have to look at KISYSMOD and then KISYS3DMOD which appends to the path made for KISYSMOD On Tue, Jan 9, 2018 at 6:01 PM, Clemens Koller wrote: > Hi, Joerg! > >

Re: [Kicad-developers] Libedit and Modedit Icons

> > +1 to the Google icon overlays. > I'll have a look into that On Wed, Jan 10, 2018 at 8:40 AM, Jeff Young wrote: > +1 to the Google icon overlays. > > On 9 Jan 2018, at 21:15, Jon Evans wrote: > > Inspiration from Google's material design icons?

Re: [Kicad-developers] Kicad from scratch: pcbnew: cannot use ~/ for home directory for KISYS3DMOD path?

Hi, Joerg! On 2018-01-09 18:49, Jörg Hermann wrote: > Is this behaviour somehow related to  > https://bugs.launchpad.net/kicad/+bug/1677545 Maybe... remotely. KISYS3DMOD's default path, as well as it's handling, seems to be off a bit. My question is: Is Kicad supposed to work with ~/... in

Re: [Kicad-developers] Libedit and Modedit Icons

+1 to the Google icon overlays. > On 9 Jan 2018, at 21:15, Jon Evans wrote: > > Inspiration from Google's material design icons? (permissively-licensed) . > These could be overlaid in the bottom right quarter maybe? > > > > > On Tue, Jan 9, 2018 at 4:09 PM, Oliver

Re: [Kicad-developers] [4.0.7] Bug report: Cannot open a project called noname.pro

Hi Nick, thanks, than I guess someone caught this before and fixed it :) Whenever 5.0 hits Slackware, I'll give it another try and cry out again if not. (been waiting for your eMail to hit the mailing list, didn't happen, so I'm responding to both now) Best Regards, Heiko On 01/08/2018 10:17

Re: [Kicad-developers] [PATCH] Fix some performance issues

Don't wait for my changes, I just wanted to feel out whether you'd be willing to accept them soon. I'm not sure if or when I'll get to them. On Tue, Jan 09, 2018 at 04:01:53PM -0500, Wayne Stambaugh wrote: > Camille, > > Although I didn't look over all of it, I'm OK with most of this since it >

Re: [Kicad-developers] Libedit and Modedit Icons

Inspiration from Google's material design icons? (permissively-licensed) . These could be overlaid in the bottom right quarter maybe? [image: Inline image 3] [image: Inline image 1] [image: Inline image 2] On Tue, Jan 9, 2018 at 4:09 PM, Oliver Walters < oliver.henry.walt...@gmail.com> wrote: >

Re: [Kicad-developers] Libedit and Modedit Icons

Ok, that's good to hear. I will take another look at the Gerber icons and otherwise see if anyone can suggest some simple clean replacements for the arrows. If not, I'll push a patch. On Wed, Jan 10, 2018 at 8:05 AM, Wayne Stambaugh wrote: > One good thing about bitmaps is

Re: [Kicad-developers] Libedit and Modedit Icons

One good thing about bitmaps is they are low risk (other than the complaining that will surely ensue) so we can merge them just about any time. I don't want to wait too long so our doc images can be updated to reflect the changes so if we cannot come up with better alternatives to replace the

Re: [Kicad-developers] [PATCH] Fix some performance issues

Camille, Although I didn't look over all of it, I'm OK with most of this since it is low risk but I wish you would have broken it into smaller patches. Reviewing a 124K patch is not my idea of fun. I'm waiting on some file renaming work from Chris which I am sure is going to clash with your

Re: [Kicad-developers] One more quick plug for reducing "Clarify Selection" dialogs

Tom and Orson, You are far more familiar with this code that I am. I'm going to defer to you for input and approval on this. It's presently looking more involved than I am comfortable with during a feature freeze. Please let me know what you think when you get a chance to review and test it.

Re: [Kicad-developers] Libedit and Modedit Icons

I think the changes are absolutely good in general, and I’d very much like to see them get merged. Not that I have any control over that. ;) As for the arrows, I’d still really like to see them go away. The colour isn’t the problem, it’s the arrows themselves. ANY of the alternatives

Re: [Kicad-developers] One more quick plug for reducing "Clarify Selection" dialogs

Hi Seth, Yeah, I did try some of those other methods first. But they all let implementation details bleed into the wrong places (COLLECORS_GUIDE instead of SELECTION_TOOL, but the info still doesn’t belong outside of the router). You are correct that some of the changes in selectPoint are

Re: [Kicad-developers] Libedit and Modedit Icons

The coloured arrows were already in place, all I have done is made them all the same "style". In fact, previously concepts like "save" and "load" were conveyed both with a downward pointing arrow, and the arrow colour was the only point of difference. I thought I had made an improvement on what

Re: [Kicad-developers] One more quick plug for reducing "Clarify Selection" dialogs

Jeff- I get your reasoning. However, it seems like you could accomplish the same goal (preventing disambiguation) by using the existing GENERAL_COLLECTOR::Modules[] for your footprint disambiguation and maybe modifying the COLLECTORS_GUIDE or Inspect() to get the track disambiguation. This

Re: [Kicad-developers] Libedit and Modedit Icons

Look at icons created with people already for impressionshttps://icons8.com/icon/free-pack/files/all Исходное сообщение От: Michael Kavanagh Дата: 09.01.18 21:07 (GMT+03:00) Кому: kicad-developers@lists.launchpad.net Тема: Re: [Kicad-developers]

Re: [Kicad-developers] One more quick plug for reducing "Clarify Selection" dialogs

Hi Seth, The test_window creates a SELECTION_TOOL without the rest of kicad behind it. Since I added methods which SELECTION_TOOL calls, I had to mock them in the test files. GENERAL_COLLECTOR::Modules[] can’t be used because the creator of the collector (SELECTION_TOOL) shouldn’t know

[Kicad-developers] Daily build for KiCad on Ubuntu (ppa)

Hi all, Launchpad build farm is currently disabled due to security issues (Meltdown and Spectre) [1]. So for the moment new KiCad daily build are disabled. Existing packages are still available but not new build... Sorry for this (temporary) bad news. [1]

Re: [Kicad-developers] One more quick plug for reducing "Clarify Selection" dialogs

Same here. Same errors. Yes, cmaked. I don't understand why you are changing the test_window link libraries in this patch. Also, why did you decide to write a "FootprintFilter" routine instead of using the GENERAL_COLLECTOR::Modules[]? -S 2018-01-09 11:05 GMT-08:00 Jeff Young

Re: [Kicad-developers] Libedit and Modedit Icons

I agree with Michael.And folder icon for Open/Load action and Blank list icon for Create new actions.Current icons very difficult to perception for me and I see tooltips periodically for simple operations open/new/save. Исходное сообщение От: Michael Kavanagh

Re: [Kicad-developers] One more quick plug for reducing "Clarify Selection" dialogs

Did you do a CMake? There’s a change in the CMake files…. > On 9 Jan 2018, at 18:59, kristoffer Ödmark > wrote: > > Hmm, cannot compile, get a lot of undefiner references. Even after nuking the > build dir. > > > ../../common/libpcbcommon.a(class_pad.cpp.o):

Re: [Kicad-developers] One more quick plug for reducing "Clarify Selection" dialogs

Hmm, cannot compile, get a lot of undefiner references. Even after nuking the build dir. ../../common/libpcbcommon.a(class_pad.cpp.o): In function `D_PAD::HitTest(EDA_RECT const&, bool, int) const': kicad/pcbnew/class_pad.cpp:982: undefined reference to `TestPointInsidePolygon(wxPoint

Re: [Kicad-developers] One more quick plug for reducing "Clarify Selection" dialogs

I just about to try :) hang on, got some merge conflicts on some local stuff On 2018-01-09 19:22, Wayne Stambaugh wrote: Does the patch resolve your issue? On 1/9/2018 1:21 PM, kristoffer Ödmark wrote: Yes, I can reproduce this with very thick tracks! On 2018-01-09 16:55, Jeff Young wrote:

Re: [Kicad-developers] One more quick plug for reducing "Clarify Selection" dialogs

Does the patch resolve your issue? On 1/9/2018 1:21 PM, kristoffer Ödmark wrote: > Yes, I can reproduce this with very thick tracks! > > > On 2018-01-09 16:55, Jeff Young wrote: >> Hi Kristoffer, >> >> That’s odd.  Did you try it with your mouse pointer directly over the >> corner?  (You may

Re: [Kicad-developers] One more quick plug for reducing "Clarify Selection" dialogs

Yes, I can reproduce this with very thick tracks! On 2018-01-09 16:55, Jeff Young wrote: Hi Kristoffer, That’s odd. Did you try it with your mouse pointer directly over the corner? (You may need a reasonably thick track for this to happen. Try something on the order of 2mm.) Without my

Re: [Kicad-developers] Renaming headers?

Yeah, most "real IDEs" have no problem jumping through source. I break out CLion when I need to do battle with the KiCad spaghetti. We shouldn't _have_ to, though. On Tue, Jan 09, 2018 at 11:13:08AM -0700, Andy Peters wrote: > > > On Jan 9, 2018, at 10:37 AM, Chris Pavlina

Re: [Kicad-developers] Renaming headers?

> On Jan 9, 2018, at 10:37 AM, Chris Pavlina wrote: > > There's a plugin for vim called CtrlP that implements fuzzy matching on > filenames too, which I use. Still, not even fuzzy matching will tell you > PCB_EDIT_FRAME is in wxPcbStruct.h. Not that I advocate for its

Re: [Kicad-developers] Kicad from scratch: pcbnew: cannot use ~/ for home directory for KISYS3DMOD path?

Is this behaviour somehow related to https://bugs.launchpad.net/kicad/+bug/1677545 > On 9. Jan 2018, at 15:38, Nick Østergaard wrote: > > If you really want to start from scratch then you may also want to remove the > ~/.cache/kicad (or there about, I am not on linux right

Re: [Kicad-developers] [PATCH] Implement primitive icon scaling for high DPI

I know… I just wanted to check that it is still OK after your patch. Jeff already did, so everything fine. > On 9. Jan 2018, at 18:28, Chris Pavlina wrote: > > OSX/macOS has built-in scaling for those, other operating systems don't. > > On Tue, Jan 09, 2018 at

Re: [Kicad-developers] Renaming headers?

Still waiting for crystal ball matching. :) On 1/9/2018 12:37 PM, Chris Pavlina wrote: > There's a plugin for vim called CtrlP that implements fuzzy matching on > filenames too, which I use. Still, not even fuzzy matching will tell you > PCB_EDIT_FRAME is in wxPcbStruct.h. > > On Tue, Jan 09,

Re: [Kicad-developers] Libedit and Modedit Icons

On 1/9/2018 12:05 PM, Rene Pöschl wrote: > On 09/01/18 16:50, Wayne Stambaugh wrote: >> I'm with Jose on the arrows.  If we are going to use them, please don't >> make the all different colors.  I don't see how a blue left arrow versus >> a magenta right arrow conveys any meaning to the user. >> >

Re: [Kicad-developers] Renaming headers?

There's a plugin for vim called CtrlP that implements fuzzy matching on filenames too, which I use. Still, not even fuzzy matching will tell you PCB_EDIT_FRAME is in wxPcbStruct.h. On Tue, Jan 09, 2018 at 11:39:13AM -0500, Jon Evans wrote: > This is a tangent, but for ease of finding files, I

Re: [Kicad-developers] One more quick plug for reducing "Clarify Selection" dialogs

The heat gets bumped up for multiple reports or when people click “this bug affects me too”. Patch uploaded. https://bugs.launchpad.net/kicad/+bug/1708869 (The duplicate: https://bugs.launchpad.net/kicad/+bug/1503679

Re: [Kicad-developers] [PATCH] Implement primitive icon scaling for high DPI

It applies cleanly on 87cc3ea44 if you want to test, I won't have a chance to rebase it until tomorrow most likely. Looks like a lot of changes. On Tue, Jan 09, 2018 at 02:27:16PM +0100, Maciej Sumiński wrote: > Hi Chris, > > The patch does not apply cleanly on the current master, would you

Re: [Kicad-developers] [PATCH] Implement primitive icon scaling for high DPI

OSX/macOS has built-in scaling for those, other operating systems don't. On Tue, Jan 09, 2018 at 02:40:20PM +0100, Bernhard Stegmaier wrote: > Hi Chris, > > can you show a screenshot what this patch fixes? > I have a Retina MacBook and for my taste the toolbar icons are pretty OK > without any

Re: [Kicad-developers] Libedit and Modedit Icons

On 2018-01-09 12:05 PM, Rene Pöschl wrote: (I can't tell you how often i clicked load symbol instead of update symbol while working on the reorganization of the official lib.) Pop up tooltips when the mouse is over the icons can also help with that problem. -- Cheers! Kevin.

Re: [Kicad-developers] Libedit and Modedit Icons

On 09/01/18 16:50, Wayne Stambaugh wrote: I'm with Jose on the arrows. If we are going to use them, please don't make the all different colors. I don't see how a blue left arrow versus a magenta right arrow conveys any meaning to the user. I like the idea of coloring them differently. For

Re: [Kicad-developers] Renaming headers?

This is a tangent, but for ease of finding files, I highly recommend using a fuzzy matcher so that you can type any part of a filename instead of having to remember how it starts. (This is how Sublime Text works if you use Ctrl+P to open a file) FZF is a great tool for this that can integrate

Re: [Kicad-developers] Renaming headers?

Now that you say it, indeed the class prefix is kinda stupid, but at least it helps when doing ls, since they are grouped in one place, whatever the name after class_ :) Sorting them by function would be the best i guess, I would suggest that the commit(s) that is exactly where rc1 branches

Re: [Kicad-developers] One more quick plug for reducing "Clarify Selection" dialogs

Hey Jeff, I'm not sure what a heat of 22 even means? I don't see any comments or suggestions in the bug report where lots of devs and/or users gave it a big thumbs up. I'm talking about getting some input on the concept and testing on a patch from other devs and users. I can't remember, did

Re: [Kicad-developers] Renaming headers?

On 09/01/18 16:57, Wayne Stambaugh wrote: > Prefixing files with class_ was a choice that I do not like and have > never done. It make searching file names a pain. If I want to use the > bash auto complete feature I have to type class_ just get the point > where I can start to differentiate the

Re: [Kicad-developers] Renaming headers?

On 09/01/18 16:21, Kristoffer Ödmark wrote: > Oh I was not planning on doing this, I am way to new to do a good job of > sorting the codebase. Just wanted to see if there have been anyone else > thinking in these lines. Currently in the pcbnew folder, the files seems > to be grouped by their

Re: [Kicad-developers] Renaming headers?

On 1/9/2018 10:21 AM, Kristoffer Ödmark wrote: > Oh I was not planning on doing this, I am way to new to do a good job of > sorting the codebase. Just wanted to see if there have been anyone else > thinking in these lines. Currently in the pcbnew folder, the files seems > to be grouped by their

Re: [Kicad-developers] One more quick plug for reducing "Clarify Selection" dialogs

Hi Kristoffer, That’s odd. Did you try it with your mouse pointer directly over the corner? (You may need a reasonably thick track for this to happen. Try something on the order of 2mm.) Without my change the selection disambiguation is run *before* we know it’s a drag action on a simple

Re: [Kicad-developers] Libedit and Modedit Icons

I'm with Jose on the arrows. If we are going to use them, please don't make the all different colors. I don't see how a blue left arrow versus a magenta right arrow conveys any meaning to the user. On 1/9/2018 10:01 AM, José Ignacio wrote: > i dislike the arrows on their own > too.  >

Re: [Kicad-developers] One more quick plug for reducing "Clarify Selection" dialogs

Hi Wayne, Well, the bug has a heat of 22, so it’s definitely not just me. ;) My change doesn’t alter the dragging or selecting behaviour. All it does is keep an extraneous “Clarify Selection” menu from coming up (which I think all our users would consider a bug). What we currently do in

Re: [Kicad-developers] One more quick plug for reducing "Clarify Selection" dialogs

If i understand him correctly that would only be when on a corner, I think it would be the desired behaviour. Although, when I try it on my build on my laptop, there is no clarify selection menu popping up when trying do drag ( 'd' ) or such on corners. Not in opengl anywas. So I dont know.

Re: [Kicad-developers] One more quick plug for reducing "Clarify Selection" dialogs

Jeff, Have actually confirmed that this is the desired behavior for this outside of you own objectives? I'm not saying that this is or isn't a good idea but I personally don't drag trace corners around so I'm not sure what the appropriate behavior should be. You should get comments from the dev

Re: [Kicad-developers] Renaming headers?

Oh I was not planning on doing this, I am way to new to do a good job of sorting the codebase. Just wanted to see if there have been anyone else thinking in these lines. Currently in the pcbnew folder, the files seems to be grouped by their names, which is also fine. I would just enjoy if the

Re: [Kicad-developers] Renaming headers?

On 1/9/2018 10:01 AM, Kristoffer Ödmark wrote: > Quite a bit of files under the root directory that could benefit from > some sorting as well :) Would be two patches then, one for renaming, and > one for sorting them somehow, both kinda large. > > Maybe move classes to a folder called classes?

Re: [Kicad-developers] Renaming headers?

Quite a bit of files under the root directory that could benefit from some sorting as well :) Would be two patches then, one for renaming, and one for sorting them somehow, both kinda large. Maybe move classes to a folder called classes? -Kristoffer On 01/09/2018 02:59 AM, Wayne Stambaugh

Re: [Kicad-developers] Libedit and Modedit Icons

Good job! Theese are very clear improvements! I must say though, I do not really like the Gerbviewer icon much. The colors are a bit contrasting to the rest of the icons, and I was probably wrong about the GBR thing, I feel that removing the Magnifying glass only on the previous one would be

Re: [Kicad-developers] Kicad from scratch: pcbnew: cannot use ~/ for home directory for KISYS3DMOD path?

If you really want to start from scratch then you may also want to remove the ~/.cache/kicad (or there about, I am not on linux right now). But it is not as important, it only contains the scene graph model cache. (Or what ever it is really called) 2018-01-09 14:55 GMT+01:00 Clemens Koller

[Kicad-developers] Kicad from scratch: pcbnew: cannot use ~/ for home directory for KISYS3DMOD path?

Hi! I am testing latest-git on Linux, collecting some UX issues when starting Kicad from scratch (*): On a new installation, I cannot execute 3D Shape Downloader out of the box. KISYS3DMOD points to ~/SW/share/kicad/modules/packages3d after installation to ~/SW/share/kicad/bin. This folder

Re: [Kicad-developers] [PATCH] Implement primitive icon scaling for high DPI

Hi Chris, Patch looks OK on normal-res Retina MacBook Pro (ie: it didn’t break anything). Cheers, Jeff. > On 9 Jan 2018, at 13:44, Nick Østergaard wrote: > > I suspect it looks something similar to what is presented in > > https://bugs.launchpad.net/kicad/+bug/1519581 >

Re: [Kicad-developers] [PATCH] Implement primitive icon scaling for high DPI

I suspect it looks something similar to what is presented in https://bugs.launchpad.net/kicad/+bug/1519581 2018-01-09 14:40 GMT+01:00 Bernhard Stegmaier : > Hi Chris, > > can you show a screenshot what this patch fixes? > I have a Retina MacBook and for my taste the

Re: [Kicad-developers] [PATCH] Implement primitive icon scaling for high DPI

Hi Chris, can you show a screenshot what this patch fixes? I have a Retina MacBook and for my taste the toolbar icons are pretty OK without any patch… Regards, Bernhard > On 9. Jan 2018, at 14:27, Maciej Sumiński wrote: > > Hi Chris, > > The patch does not apply

Re: [Kicad-developers] [PATCH] Implement primitive icon scaling for high DPI

Hi Chris, The patch does not apply cleanly on the current master, would you rebase it? Thanks in advance. Cheers, Orson On 01/09/2018 03:43 AM, Chris Pavlina wrote: > Hi, > > As discussed with Wayne earlier, I've attached a patch which adds simple > toolbar icon scaling so the toolbars are

Re: [Kicad-developers] pcbnew: Zoom to fit board on screen broken

Thanks Clemens, confirmed and reported here: https://bugs.launchpad.net/kicad/+bug/1742140 On Tue, Jan 9, 2018 at 6:32 AM, Clemens Koller wrote: > Sorry, my mistake: > > It happens in Modern (Fallback) mode only. Legacy mode is okay! (The new > names...) > > Regards, > > Clemens

Re: [Kicad-developers] pcbnew: Zoom to fit board on screen broken

Sorry, my mistake: It happens in Modern (Fallback) mode only. Legacy mode is okay! (The new names...) Regards, Clemens On 2018-01-09 12:25, Clemens Koller wrote: > Hi, Jon! > > Its erratic in Legacy mode only, after starting with an empty project. Once > there were components placed and

Re: [Kicad-developers] pcbnew: Zoom to fit board on screen broken

Hi, Jon! Its erratic in Legacy mode only, after starting with an empty project. Once there were components placed and deleted, the behaviour vanishes, IIRC. Regards, Clemens On 2018-01-09 05:31, Jon Evans wrote: > Can't reproduce this on my Linux system.  I even tried removing my config >