Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

2018-03-16 Thread Nick Østergaard
Thank you very much, I will try to remember it after the weekend. 2018-03-17 0:46 GMT+01:00 Seth Hillbrand : > Hi Nick- > > I finally found a moment to figure out Docker and get this up and running > in your build configuration. > > Please take a look when you have a

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

2018-03-16 Thread Seth Hillbrand
Hi Nick- I finally found a moment to figure out Docker and get this up and running in your build configuration. Please take a look when you have a chance and let me know if you have any issues with this patch. Best- Seth 2018-02-10 7:12 GMT-08:00 Seth Hillbrand : >

Re: [Kicad-developers] [PATCH] - File format shim for clearance data

2018-03-16 Thread hauptmech
While i would still like to see this (my) shim go in, I agree with wayne. Until/unless a less brittle approach is used for the parser, it's better to signal a problem painfully and maintain the integrity of the file. I have to admit that when i first heard the s-expressions idea I assumed that

Re: [Kicad-developers] [PATCH] - File format shim for clearance data

2018-03-16 Thread Jeff Young
Hi Wayne, Patch reverted. However, I think your concern is misplaced. If we want to prevent dataloss (ie: from reading a 6.0 file into 5.0), then we should warn the user based on the version string (and give them a chance to say “I still want to open”). But either way, actually failing to

Re: [Kicad-developers] [PATCH] - File format shim for clearance data

2018-03-16 Thread Wayne Stambaugh
Jeff, Please revert this patch. Any changes to the board file parser and/or formatter need to be discussed before the changes are committed. It has been the intention that the board parser be pendantic by design to prevent data loss by ignoring unknown formatting. Allowing anything outside of

Re: [Kicad-developers] [PATCH] - File format shim for clearance data

2018-03-16 Thread Jeff Young
Perhaps somewhat germane to this discussion I have removed the strict-format nags from the PCB parser. It now logs warnings to stderr but otherwise ignores structures it doesn’t understand. I’m not sure that helps hauptmech much as if the file is subsequently written the unknown markup will

Re: [Kicad-developers] [PATCH 0/8] fixing various small spelling issues

2018-03-16 Thread Nick Østergaard
For reference, this patch series have been merged. 2018-02-25 13:17 GMT+01:00 : > From: Carsten Schoenert > > While working on the packaging of KiCad 5 for Debian the lintian QS tool > found some spelling error which I fixed mostly by this

[Kicad-developers] [PATCH] Add/modify python APIs for querying available pcbnew footprints

2018-03-16 Thread miles mccoo
Note: I have attempted to follow the kicad coding standards. Surely, there's something that I missed. Please, instead of: "syntax error. Please see the coding guidelines", please give an idea of the nature of things I missed. ;-) This change adds the python apis: GetLogicalLibs and

Re: [Kicad-developers] small typo

2018-03-16 Thread Wayne Stambaugh
Marco, Please send patches created using `git format-patch` as attachments. It makes life easier for lead devs to merge your changes. I went ahead and fixed this and gave you credit for the fix. Thanks for catching this typo. Cheers, Wayne On 03/15/2018 05:34 PM, Marco Ciampa wrote: > Here