Re: [Kicad-developers] Partial fix for bug #1758747 Import Eagle Project ignores cream="no" option

Hi Russell- I was unclear. The change in the LSET makes sense. But it looks like you are not setting the solderpaste margin when the solderpaste layer is enabled. I think you need to handle both the case where the paste is enabled and where it is disabled. -S 2018-03-27 12:53 GMT-07:00 Russel

Re: [Kicad-developers] Partial fix for bug #1758747 Import Eagle Project ignores cream="no" option

The cream setting is the eagle equivalent to enabling/disabling the soldering paste layer for the pad. Hence the change in the layer set. On Wed, 28 Mar 2018 03:14 Seth Hillbrand, wrote: > Hi Russell- > > Thanks for the patch. However, currently, if there is no e.cream setting, > the local sold

Re: [Kicad-developers] [PATCH] Fix for bug/1754049

Le 27/03/2018 à 14:16, jp charras a écrit : <> > I just committed a first fix that fixes a few issues. > Currently, a bug is still pending: a crash can happen if a undo command uses > a removed item. > > About vias, that are multilayers items, blind/ buried vias and especially > micro vias a

Re: [Kicad-developers] [PATCH] - File format shim for clearance data

I agree with this. The current pad parsing code should not be open ended even if there are plans for future expansion. On 3/27/2018 1:51 PM, Seth Hillbrand wrote: > Hi Jeff- > > Can we split this patch?  I think the addition of strict checking for > the pads should be in 5.   > > -S > > 2018-0

Re: [Kicad-developers] [PATCH] - File format shim for clearance data

@Jeff, I still have to test the round tripping to make sure there is no data loss for potential combinations of unknown tokens. As soon as I have tested it, I will let you know. On 3/27/2018 1:34 PM, Jeff Young wrote: > 5.0, 6.0 or abandon? > >> On 20 Mar 2018, at 16:47, Jeff Young >

Re: [Kicad-developers] [PATCH] - File format shim for clearance data

Hi Jeff- Can we split this patch? I think the addition of strict checking for the pads should be in 5. -S 2018-03-27 10:34 GMT-07:00 Jeff Young : > 5.0, 6.0 or abandon? > > > On 20 Mar 2018, at 16:47, Jeff Young wrote: > > Hi Wayne, > > This solution *is* pretty much “property” tokens except

Re: [Kicad-developers] [PATCH] - File format shim for clearance data

5.0, 6.0 or abandon? > On 20 Mar 2018, at 16:47, Jeff Young wrote: > > Hi Wayne, > > This solution is pretty much “property” tokens except that: > > 1) it’s more flexible (properties can be arbitrary s-expressions) > 2) it handles 3rd-party-needs and our own with a single infrastructure > > I

Re: [Kicad-developers] Partial fix for bug #1758747 Import Eagle Project ignores cream="no" option

Hi Russell- Thanks for the patch. However, currently, if there is no e.cream setting, the local solderpaste margin gets set. In your patch, if the setting is missing, that doesn't happen. Is this your intention? -S 2018-03-27 5:06 GMT-07:00 Russell Oliver : > This fixes the issue where the c

Re: [Kicad-developers] [PATCH] Fix for bug/1754049

Le 26/03/2018 à 21:58, Maciej Suminski a écrit : > Hi Jean-Pierre, > -Not so minor issues: Multilayers items (blind/buried vias, keepout zones) are incorrectly handled: * In GAL mode, removed Multilayers items are still visible after deletion. >>> >>> This should be fixed. Ev

[Kicad-developers] Partial fix for bug #1758747 Import Eagle Project ignores cream="no" option

This fixes the issue where the cream setting is ignored when setting the layer set for the pad, but the bug report also mentions that the rotation for rectangles are ignored during import. They rectangle is niavely converted to a polygon. 0001-Eagle-Import-Correct-layer-set-based-on-cream-settin.