Re: [Kicad-developers] New Footprint libs and wizard issues

2018-04-06 Thread Kevin Cozens
On 2018-04-06 06:30 AM, kristoffer Ödmark wrote: Attached is a patch that adds support for custom environment paths. Previously the wizard would only accept KISYSMOD, KIPRJMOD and the github one. I added MYSYSMOD as a custom path ages ago. What I find odd about the dialog boxes that let you

Re: [Kicad-developers] [PATCH] Adjust Menubar of 3D Viewer to common style

2018-04-06 Thread Jeff Young
Hi Thomas, I don’t think I’d nest the two export options just for the sake of consistency. Nested menus are harder to use, and should only be resorted to when necessary (either when room on the menu is an issue, or when progressive disclosure is desired). Copy 3D Image goes to the clipboard,

Re: [Kicad-developers] New Footprint libs and wizard issues

2018-04-06 Thread Jeff Young
I think the reason is that KIPRJMOD is not editable. Still, it would be better to show it in the dialog and just make it read-only (as then the user would know it existed without opening the help window). Feel free to log a bug for that (just set its milestone to 6.0). I’ll merge your patch.

Re: [Kicad-developers] New Footprint libs and wizard issues

2018-04-06 Thread kristoffer Ödmark
Turns out the redundant code was not very redundant. There would have to be some more refactoring of the code to get this all using the NormalizePath command in common/env_paths.cpp I am also uncertain, since I dont understand the codebase good enough, to why Pgm.GetLocalEnvVars does not

Re: [Kicad-developers] New Footprint libs and wizard issues

2018-04-06 Thread kristoffer Ödmark
Found a bug shortly after, I will reupload. I will also remove the redundant code and check if it still works. On 2018-04-06 13:05, Jeff Young wrote: Patch looks good to me, although I’d rather see the redundant code removed. On 6 Apr 2018, at 11:30, kristoffer Ödmark

Re: [Kicad-developers] New Footprint libs and wizard issues

2018-04-06 Thread Jeff Young
Patch looks good to me, although I’d rather see the redundant code removed. > On 6 Apr 2018, at 11:30, kristoffer Ödmark > wrote: > > <0001-Footprint-Wizard-now-also-handles-custom-Env-paths.patch> ___ Mailing list:

[Kicad-developers] Mac sensitivity to includes

2018-04-06 Thread Jeff Young
So I pushed another change that broke the build because the Mac compiler didn’t need an include: #include which evidently other compilers do. Anyone know how to make the Mac equally sensitive to includes so I can find out before pushing? Thanks, Jeff.

[Kicad-developers] Jenkins build is back to normal : kicad-qa #3900

2018-04-06 Thread Miguel Angel Ajo
See ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help

[Kicad-developers] Build failed in Jenkins: kicad-qa #3899

2018-04-06 Thread Miguel Angel Ajo
See Changes: [jeff] Standardize "assign footprints" terminology. [jeff] Workaround for wxString's lack of thread safety. -- Started by an SCM change Building remotely on debian8

Re: [Kicad-developers] New Footprint libs and wizard issues

2018-04-06 Thread kristoffer Ödmark
Attached is a patch that adds support for custom environment paths. Previously the wizard would only accept KISYSMOD, KIPRJMOD and the github one. left some legacy handling in the GetAutoPath, as to not break anything, I can remove it if wanted. - Kristoffer On 2018-04-04 11:02, jp

Re: [Kicad-developers] [RFC] Able to install KiCad stable and "daily build" in same computer

2018-04-06 Thread Clemens Koller
Does it make sense to include the major version in the package name as well, just to give it a grab handle? kicad4-4.0.7 kicad5-5.0.0 kicad5-nightly See qt, gtk, ... Regards, Clemens On 2018-04-06 08:01, Strontium wrote: > Hi Wayne, > > I agree with you about scope creep, however I do see

[Kicad-developers] DRC Markers and dirty bit

2018-04-06 Thread Jeff Young
Adding a DRC Marker sets the file’s dirty bit. Yet we don’t save these in the file, do we? Maybe we need a flag to BOARD_COMMIT::push() which says whether or not to call OnModify()? ___ Mailing list: https://launchpad.net/~kicad-developers Post to

Re: [Kicad-developers] What is the purpose of multiple 3D models?

2018-04-06 Thread Fabrizio Tappero
Multiple 3d shapes is actually great. I use it when i have a component that is a second PCB that can be mounted in two different orientations. On Mar 31, 2018 7:39 PM, "jp charras" wrote: > Le 31/03/2018 à 19:28, Kevin Cozens a écrit : > > On 2018-03-31 01:04 PM, jp

Re: [Kicad-developers] [RFC] Able to install KiCad stable and "daily build" in same computer

2018-04-06 Thread Fabrizio Tappero
Hi, As for freecad I think it is a great idea to have v5 and kicad-nightly. Cheers Fabrizio On Apr 6, 2018 8:02 AM, "Strontium" wrote: > Hi Wayne, > > I agree with you about scope creep, however I do see issues for users. > > From an end user perspective V5 is a big

Re: [Kicad-developers] [RFC] Able to install KiCad stable and "daily build" in same computer

2018-04-06 Thread Strontium
Hi Wayne, I agree with you about scope creep, however I do see issues for users. From an end user perspective V5 is a big change. I noticed big changes just from missing nightly updates for 2 months.  There may be an extended period of time when a user will want to run both versions, for