Re: [Kicad-developers] [PATCH] Add logo to documentation

I agree. The double KiCad does look a bit odd but I do like the KiCad logo embedded in the docs. On 06/13/2018 06:00 PM, Nick Østergaard wrote: Maybe we need to remove the word KiCad from the title, as  it essentially reads  "[KiCad] KiCad Pcbnew Python Scripting" 2018-06-13 21:12

Re: [Kicad-developers] [PATCH] Add logo to documentation

Maybe we need to remove the word KiCad from the title, as it essentially reads "[KiCad] KiCad Pcbnew Python Scripting" 2018-06-13 21:12 GMT+02:00 John Beard : > Sorry, I had a line commented in a local commit to avoid a costly re-build > of the docstrings when I didn't need them to be (the

Re: [Kicad-developers] Slash character in fp-lib-table nick names?

Those are good reasons for not allowing slashes in the footprint names but I don’t see any reason for not allowing them in *library* nick names. As far as I can tell any character except : could be allowed before the :. It’s a pretty long standing “bug” so we could view it as standard. It will

Re: [Kicad-developers] [PATCH] Add logo to documentation

Sorry, I had a line commented in a local commit to avoid a costly re-build of the docstrings when I didn't need them to be (the doc dependencies aren't managed by CMake, it just always runs the targets, which is fine for CI). The attached should be better (difference is a lack of a "# " before

Re: [Kicad-developers] [PATCH] Add logo to documentation

John, I am getting the following error when I try to apply your patch: $ git am --ignore-whitespace < /c/Users/wstambaugh/Documents/Archive/temp/kicad/patches/0001-Documentation-add-logo-to-Doxygen-pages.patch Applying: Documentation: add logo to Doxygen pages error: patch failed:

Re: [Kicad-developers] Slash character in fp-lib-table nick names?

AFAIK you cannot use slashes ('/') or colons (':') in either a library (footprint or symbol) table nickname or a footprint or symbol name. If you could use a slash in a footprint library nickname in the past, this was a bug and the fact that it worked was a fluke. The reason is that the library

Re: [Kicad-developers] Slash character in fp-lib-table nick names?

Sorry to bring this up again but it just strikes me as a bit odd. Can we not allow slash characters in the fp-lib-table as before and not break backwards compatibility? It seems to read fp-lib-tables with slashes fine but current KiCad nightly won't let me edit it. I am up for making a patch if

[Kicad-developers] [PATCH] Add logo to documentation

Hi, This patch adds a small KiCad logo to the three doxygen documentation targets (C++, dev docs and Python docs) for a little bit more flair. The image itself is put in the /Documentation dir, but it's not really important to the process where it goes. Cheers, John From

Re: [Kicad-developers] [PATCH] Python FP wizard helper: docstrings and rounded/chamfered rects

John, Everything looked good so I merged your patch set. Thank you for your contribution to KiCad. Cheers, Wayne On 6/13/2018 7:59 AM, John Beard wrote: > Hi, > > Here's an update patch set that adds to the existing Pcbnew Python docs. > It seems to work quite well (see screenshot). > > I

Re: [Kicad-developers] Build failed in Jenkins: kicad-qa #4256

For the record: the issue has been already fixed by Jean-Pierre and was not really related to the documentation fixes. Thank you! Cheers, Orson On 06/12/2018 04:28 PM, Miguel Angel Ajo wrote: > See > > Changes: > >

Re: [Kicad-developers] Janitor needs a kick

Whoops! Apparently trying to change status of a non-existent bug report drove him insane. He has already taken his pills, everything should be back to normal soon. Sorry for the mess. Cheers, Orson On 06/13/2018 02:48 AM, Seth Hillbrand wrote: > I don't think it was my formatting but the last