Re: [Kicad-developers] Strange strings for translation.

2018-06-18 Thread Adam Wolf
Wow! My tree was in a very weird state due to trying to my script trying to apply the STEP patch I sent to the list, and instead of crashing, it didn't update to the latest master. The script is fixed on my end now, and shouldn't happen again. Sorry for the false positive! Adam On Mon, Jun 18,

Re: [Kicad-developers] Strange strings for translation.

2018-06-18 Thread Wayne Stambaugh
On 6/18/2018 2:53 PM, jp charras wrote: > Le 18/06/2018 à 20:45, Adam Wolf a écrit : >> Is there something in particular you want tested on macOS? It still >> builds, and the export STEP dialog seems OK. >> >> Adam > > It compiles? > > Strange: > this line > " e appK2S.AppendDir(

Re: [Kicad-developers] Strange strings for translation.

2018-06-18 Thread jp charras
Le 18/06/2018 à 20:45, Adam Wolf a écrit : > Is there something in particular you want tested on macOS? It still > builds, and the export STEP dialog seems OK. > > Adam It compiles? Strange: this line " e appK2S.AppendDir( "MacOS" );" (dialog_export_step.cpp, line 261) has a typo,

Re: [Kicad-developers] Strange strings for translation.

2018-06-18 Thread Wayne Stambaugh
That should do it. It was a fairly simple change but most of the changes were between #ifdef/#endif statement so I just want to be sure I didn't fat finger anything. Cheers, Wayne On 6/18/2018 2:45 PM, Adam Wolf wrote: > Is there something in particular you want tested on macOS? It still >

Re: [Kicad-developers] Strange strings for translation.

2018-06-18 Thread Adam Wolf
Is there something in particular you want tested on macOS? It still builds, and the export STEP dialog seems OK. Adam On Mon, Jun 18, 2018 at 11:20 AM Wayne Stambaugh wrote: > > I just pushed the fix for this. Would one of our macos devs please test > this to make sure I didn't break anything?

Re: [Kicad-developers] Strange strings for translation.

2018-06-18 Thread Wayne Stambaugh
I just pushed the fix for this. Would one of our macos devs please test this to make sure I didn't break anything? Thanks, Wayne On 6/18/2018 10:59 AM, Константин Барановский wrote: > After adding one of the last commits the next strings is appears for > translation: > > #:

Re: [Kicad-developers] Strange strings for translation.

2018-06-18 Thread Wayne Stambaugh
Sorry about that. When I reviewed the patch, I missed that these strings should not be translated. I'll fix it today. Thanks for the heads up. On 6/18/2018 10:59 AM, Константин Барановский wrote: > After adding one of the last commits the next strings is appears for > translation: > > #:

[Kicad-developers] Strange strings for translation.

2018-06-18 Thread Константин Барановский
After adding one of the last commits the next strings is appears for translation: #: pcbnew/dialogs/dialog_export_step.cpp:254 msgid "/Contents/Applications/pcbnew.app/Contents/MacOS" msgstr "" #: pcbnew/dialogs/dialog_export_step.cpp:256 #: pcbnew/dialogs/dialog_export_step.cpp:257 #:

Re: [Kicad-developers] Upgrading from V4 to V5 resources?

2018-06-18 Thread Wayne Stambaugh
As soon as I have the rough draft completed, I will post a link to it for review before I commit it. On 6/18/2018 9:09 AM, Rene Pöschl wrote: > Another pitfall seems to be that users do not expect that they need to > update their fp-lib-table after installing kicad 5. > > Either they need to

Re: [Kicad-developers] Upgrading from V4 to V5 resources?

2018-06-18 Thread Rene Pöschl
Another pitfall seems to be that users do not expect that they need to update their fp-lib-table after installing kicad 5. Either they need to update the fp-lib-table to get the footprint library to the state of v5 or they would need to manually install the version 4 symbol and 3d model libs

Re: [Kicad-developers] [PATCH] Add logo to documentation

2018-06-18 Thread Nick Østergaard
Mmm, I think I would prefer the Ki logo man. 18. jun. 2018 10.11 skrev John Beard : > In that case, here is the patch with the 48px app logo in the top left. > Doxygen recommends 55px max height, so 48px seems a handy size. > > Screenshot for reference. > > Cheers, > > John > > On Sun, Jun 17,

Re: [Kicad-developers] [PATCH] Add logo to documentation

2018-06-18 Thread Marco Ciampa
On Mon, Jun 18, 2018 at 09:10:49AM +0100, John Beard wrote: > In that case, here is the patch with the 48px app logo in the top left. > Doxygen recommends 55px max height, so 48px seems a handy size. > > Screenshot for reference. > > Cheers, > > John > Nice, would you mind adding a small

Re: [Kicad-developers] [PATCH] Add logo to documentation

2018-06-18 Thread John Beard
In that case, here is the patch with the 48px app logo in the top left. Doxygen recommends 55px max height, so 48px seems a handy size. Screenshot for reference. Cheers, John On Sun, Jun 17, 2018 at 5:58 PM, Wayne Stambaugh wrote: > I'm OK with the short logo image. This would probably look