[Kicad-developers] Jenkins e-mails?

​Hi Nick- I notice that the dev list is not receiving notices of build failures from Jenkins. But the build logs (e.g. http://ci.kicad-pcb.org/job/kicad-qa/4320/console) show that Jenkins is trying to send e-mails. Was this disabled on purpose? If so, is there a way to get specifically added

Re: [Kicad-developers] [PATCH v2] Rewrite test for valid characters in names

That makes sense, thanks. Can you do a git format-patch for this change? We'll look at moving the higher loops to std::replace_copy_if during v5.1 -S ​ Am Do., 28. Juni 2018 um 11:34 Uhr schrieb Simon Richter < simon.rich...@hogyros.de>: > Hi Seth, > > On 06/28/2018 07:56 PM, Seth Hillbrand

Re: [Kicad-developers] [PATCH] V5 upgrade documentation

I have put the upated image live now, and it seems to work. I will try to revert the removal of the macros. Den tor. 28. jun. 2018 kl. 23.21 skrev Nick Østergaard : > Hi Seth > > Ok, thank you for your investigation. I will update the docker image to > bionic which uses 0.52 of po4a. > > Nick >

Re: [Kicad-developers] gcc-specific OpenMP extension in connectivity_algo.cpp:351

Hi, On 06/28/2018 09:26 PM, Seth Hillbrand wrote: > The shared declaration was unintentional, so I've removed it.  As an > aside, does anyone know the right gcc flag to get these warnings?  Mine > ​is very happy to overlook this but apparently other versions are not. There is none. I build

Re: [Kicad-developers] [PATCH] V5 upgrade documentation

Hi Seth Ok, thank you for your investigation. I will update the docker image to bionic which uses 0.52 of po4a. Nick Den tor. 28. jun. 2018 kl. 23.05 skrev Seth Hillbrand < seth.hillbr...@gmail.com>: > ​Bother. po4a fixed this back in 2016 ( >

Re: [Kicad-developers] [PATCH] V5 upgrade documentation

​Bother. po4a fixed this back in 2016 ( https://github.com/mquinson/po4a/commit/86f79e5d341ffcb62da9812101304c3dbb420cc6). It looks like our doc server is running 0.47 (the fix didn't get released until 0.49) -S Am Do., 28. Juni 2018 um 12:39 Uhr schrieb Wayne Stambaugh <

[Kicad-developers] Jenkins build is back to normal : kicad-noscript-fedora20 #3302

See ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe :

[Kicad-developers] Jenkins build is back to normal : linux-kicad-full-gcc-head #3616

See ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe :

Re: [Kicad-developers] [PATCH] V5 upgrade documentation

No problem, thanks for everything! On Thu, Jun 28, 2018 at 2:38 PM Wayne Stambaugh wrote: > > Hey Adam, > > It will eventually be in the Kicad documentation at > > http://docs.kicad-pcb.org/stable/en/kicad.html > > There were some github macros that hauptmech added that broke the > documentation

Re: [Kicad-developers] [PATCH] V5 upgrade documentation

Hey Adam, It will eventually be in the Kicad documentation at http://docs.kicad-pcb.org/stable/en/kicad.html There were some github macros that hauptmech added that broke the documentation build. Apparently asciidoc was choking on them which is unfortunate as they made the github adoc

[Kicad-developers] Jenkins build is back to normal : kicad-qa #4321

See ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help

Re: [Kicad-developers] gcc-specific OpenMP extension in connectivity_algo.cpp:351

​Thanks, JP was just mentioning that in https://bugs.launchpad.net/kicad/+bug/1778454 The shared declaration was unintentional, so I've removed it. As an aside, does anyone know the right gcc flag to get these warnings? Mine ​is very happy to overlook this but apparently other versions are not.

Re: [Kicad-developers] gcc-specific OpenMP extension in connectivity_algo.cpp:351

If the fix is trivial and not likely to break other compiler builds, then feel free to fix it. I do not want to hold up rc3 any longer than we already have to fix an unsupported compiler error. If it cannot be fixed with the next two days, then it will have to wait. I want to tag rc3 before I

[Kicad-developers] gcc-specific OpenMP extension in connectivity_algo.cpp:351

Hi, Commit 0748c118d introduced a line #pragma omp parallel shared( m_itemList ) ... MSVC rejects this, as m_itemList is a subobject of this, and sharing subobjects is not allowed in the OpenMP specification: A variable that is part of another variable (as an array or structure

Re: [Kicad-developers] [PATCH v2] Rewrite test for valid characters in names

Hi Seth, On 06/28/2018 07:56 PM, Seth Hillbrand wrote: > ​Understood.   What's the impact of the array assignment now?  ​ MSVC refuses to compile it. It seems to be an artefact from a gcc extension that allows the result of a ternary to be an lvalue if both branches are, but I don't think that

Re: [Kicad-developers] [PATCH v2] Rewrite test for valid characters in names

​Understood. What's the impact of the array assignment now? ​ ​-S​ Am Do., 28. Juni 2018 um 10:01 Uhr schrieb Simon Richter < simon.rich...@hogyros.de>: > > The ternary operator decays array arguments to pointers, so they can no > longer be assigned to array references. > --- >

Re: [Kicad-developers] [PATCH] V5 upgrade documentation

Hi Wayne, Has it been decided where this documentation will live? Is it some place with a URL? Thanks! Adam On Sun, Jun 24, 2018 at 11:24 AM Wayne Stambaugh wrote: > > hauptmech, > > I merged your patch and pushed the changes upstream to the kicad doc > repo. Thank you for the help with the

[Kicad-developers] [PATCH v2] Rewrite test for valid characters in names

The ternary operator decays array arguments to pointers, so they can no longer be assigned to array references. --- common/lib_id.cpp | 64 ++- 1 file changed, 30 insertions(+), 34 deletions(-) diff --git a/common/lib_id.cpp

Re: [Kicad-developers] [PATCH] Rewrite test for valid characters in names

Hi, > I agree that the assignment is non-standard and probably should be > updated. However, if we're going to re-write this, would you be up for > doing it with std:: algorithms? I've thought about this too, but as this function looks at each character in isolation, we'd end up with a fairly

Re: [Kicad-developers] [PATCH] Rewrite test for valid characters in names

​Hi Simon- I agree that the assignment is non-standard and probably should be updated. However, if we're going to re-write this, would you be up for doing it with std:: algorithms? -S​ Am Do., 28. Juni 2018 um 09:24 Uhr schrieb Simon Richter < simon.rich...@hogyros.de>: > > The ternary

[Kicad-developers] Build failed in Jenkins: linux-kicad-full-gcc-head #3615

See Changes: [hillbrand] pcbnew: fix OpenMP synch issue -- [...truncated 65.87 KB...] [ 39%] Building CXX object

[Kicad-developers] [PATCH] Rewrite test for valid characters in names

The ternary operator decays array arguments to pointers, so they can no longer be assigned to array references. --- common/lib_id.cpp | 71 ++- 1 file changed, 39 insertions(+), 32 deletions(-) diff --git a/common/lib_id.cpp

[Kicad-developers] Build failed in Jenkins: linux-kicad-full-gcc-head #3614

See Changes: [hillbrand] pcbnew: Synchronize zone removal -- [...truncated 66.12 KB...] [ 39%] Building CXX object

[Kicad-developers] Build failed in Jenkins: kicad-qa #4319

See Changes: [hillbrand] pcbnew: Synchronize zone removal -- Started by an SCM change Building remotely on debian8 (clang gcc linux) in workspace

Re: [Kicad-developers] [PATCH/QUESTION] Fix -Wshadow warnings in sch_sheet_path.cpp

John, I went ahead and merged your patch even though there seems to be not logical reason for the shadow variable warning. There is not much risk in renaming a few variables to keep the compiler from complaining. Thank you for your contribution to KiCad. Cheers, Wayne On 6/28/2018 9:44 AM,

[Kicad-developers] [PATCH/QUESTION] Fix -Wshadow warnings in sch_sheet_path.cpp

Hi, Simple patch to fix a trio of -Wshadow warnings in SCH_SHEET_PATH. Apparently, these shadow declarations from the STL vector header: /home/john/src/kicad/eeschema/sch_sheet_path.cpp: In member function ‘void SCH_SHEET_PATH::GetComponents(SCH_REFERENCE_LIST&, bool, bool)’: