Re: [Kicad-developers] Patch to draw bitmaps in GAL canvases

2018-07-29 Thread Tomasz Wlostowski
On 27/07/18 15:31, jp charras wrote: > Le 27/07/2018 à 15:20, Tomasz Wlostowski a écrit : >> On 27/07/18 13:28, jp charras wrote: >>> Le 26/07/2018 à 18:13, Mário Luzeiro a écrit : Hi JP, Don't know about CAIRO, but a "for xy DrawRectangle" it is too heavy. >>> >>> In fact "for xy

Re: [Kicad-developers] MacOS build issue with new geometry tests

2018-07-29 Thread Bernhard Stegmaier
Hi, it’s not constexpr that breaks clang. Usage of floating point isn’t valid in a constexpr (only literals allowed, floating point isn’t a literal)… https://en.cppreference.com/w/cpp/language/constexpr Regards, Bernhard > On 29. Jul

Re: [Kicad-developers] MacOS build issue with new geometry tests

2018-07-29 Thread John Beard
Hi Adam, Sorry, this in my stuff - I though that was a way to get PI without having to guess the setting of _USE_MATH_DEFINES or do #ifdefs like at the top of dl_codes.h, but obviously not. The attached patch might work, but I can't test on a Mac, so all I can say is "it builds for me and the

[Kicad-developers] MacOS build issue with new geometry tests

2018-07-29 Thread Adam Wolf
Hi folks! There's a build failure on the new geometry test stuff with MacOS. qa/geometry/geom_test_utils.h:33:18: error: constexpr variable 'PI' must be initialized by a constant expression constexpr double PI = atan(1.0) * 4.0; ^ ~~~ qa/geometry/geom_test_utils.h:33:23: note: