Re: [Kicad-developers] KiCad v5 MacOS Library Editor - Error Cannot Load Aliases

2018-08-02 Thread Bernhard Stegmaier
Hi Andrey, you might also want to check if you previously had some environment variables set in macOS itself to use libraries from a non-standard place. If so, remove them and configure paths only via KiCad (Preferences => Configure Paths). Regards, Bernhard > On 2. Aug 2018, at 06:32, Piotr

Re: [Kicad-developers] [PATCH] Restore settings dialog icon scale stepped slider increments

2018-08-02 Thread Jeff Young
Hi John, Can you reattach your patch in git format-patch format? That will make sure you’re listed in the git commit. Cheers, Jeff. > On 2 Aug 2018, at 05:40, John Gehrig wrote: > > Hi everyone, > > While looking at the new common settings dialog, I noticed that the Icon > Scale STEPPED_S

[Kicad-developers] Sunken panels and 3D borders.

2018-08-02 Thread Wayne Stambaugh
Is there any reason to keep sunken panels and 3D boards in either dialog or frame window panels? They look out of place on all versions of windows after 3.1. Given the flat look of most modern window managers on linux, they also look out of place there as well. Is there any objection to removing

Re: [Kicad-developers] Sunken panels and 3D borders.

2018-08-02 Thread Jeff Young
Hi Wayne, I had been removing them but on either MSW or GTK (I can’t remember which), wxGrid doesn’t have any border at all in flat mode, and the header rows are the same background colour as the dialog makes things really hard to visually parse. A single-pixel line border would be better, but

Re: [Kicad-developers] Sunken panels and 3D borders.

2018-08-02 Thread Jeff Young
Here’s one example (although not the one I was thinking of). Note how the grid doesn’t have any border, so the icons at the bottom are just sort of floating, and the left edge next to the “3D Model(s)” heading looks clipped. (Ignore the red oval; the picture was borrowed from an unrelated bug

Re: [Kicad-developers] Sunken panels and 3D borders.

2018-08-02 Thread Wayne Stambaugh
I'll go ahead a do it while I'm tweaking dialogs. Wayne On 8/2/2018 10:33 AM, Jeff Young wrote: > Perfect.  Yes, feel free to change them to that (or I can do it). > > Cheers, > Jeff. > > >> On 2 Aug 2018, at 15:30, Wayne Stambaugh > > wrote: >> >> Hey Jeff, >> >>

Re: [Kicad-developers] Sunken panels and 3D borders.

2018-08-02 Thread Jeff Young
Perfect. Yes, feel free to change them to that (or I can do it). Cheers, Jeff. > On 2 Aug 2018, at 15:30, Wayne Stambaugh wrote: > > Hey Jeff, > > To fix the border issue, use wxBORDER_SIMPLE instead of wxBORDER_RAISED > as a window style option. Here is the environment variable dialog on >

Re: [Kicad-developers] Sunken panels and 3D borders.

2018-08-02 Thread Wayne Stambaugh
Hey Jeff, To fix the border issue, use wxBORDER_SIMPLE instead of wxBORDER_RAISED as a window style option. Here is the environment variable dialog on windows 10 with this change. Cheers, Wayne On 8/2/2018 10:11 AM, Jeff Young wrote: > Hi Wayne, > > I had been removing them but on either MSW

[Kicad-developers] Doxygen comments typo patch from Forum

2018-08-02 Thread Simon Richter
Hi, there is a patch submission on the KiCad forum. The submitter doesn't want to post to the mailing list for fear of spam. https://forum.kicad.info/t/patch-that-fixes-doxygen-typos-and-any-other-misc-typos-in-general/11804 Looks good to me, does anyone feel like merging it? Simon signat

Re: [Kicad-developers] KiCad v5 build warning

2018-08-02 Thread Seth Hillbrand
I'd second Nick's suggestion. Any objections to enabling it by default for 5.0.1? -S Am Do., 2. Aug. 2018 um 08:03 Uhr schrieb Nick Østergaard : > Hello > > It may be off by default, but should we enable it by default? I think > yes. It has been discussed briefly here and there. > > If we like

Re: [Kicad-developers] KiCad v5 build warning

2018-08-02 Thread Nick Østergaard
Hello It may be off by default, but should we enable it by default? I think yes. It has been discussed briefly here and there. If we like it in the 5.0 builds I propose we set it as default on on the 5.0 branch now. Nick Den man. 23. jul. 2018 kl. 05.48 skrev Seth Hillbrand : > > Hi Devs- > > Qu

[Kicad-developers] Warning regarding global wxStrings and thread-safety

2018-08-02 Thread Jeff Young
I finally caught a long-standing but very infrequent crash in the debugger. It’s somewhat harrowing. wxString keeps multiple iterators on a string up-to-date with regard to editing. It keeps them in a linked list. If you reference a global string in a thread (even in a const manner, such as

Re: [Kicad-developers] Warning regarding global wxStrings and thread-safety

2018-08-02 Thread Jeff Young
PS: I also have a strange sense of deja vue. Did I discover this earlier and forget already, or is my mind just playing tricks on me? > On 2 Aug 2018, at 18:01, Jeff Young wrote: > > I finally caught a long-standing but very infrequent crash in the debugger. > It’s somewhat harrowing. > > w

Re: [Kicad-developers] Warning regarding global wxStrings and thread-safety

2018-08-02 Thread Seth Hillbrand
Hi Jeff- Good find. I note here (http://docs.wxwidgets.org/3.0/classwx_string.html) that the use of wxString is explicitly discouraged: "While the use of wxString is unavoidable in wxWidgets program, you are encouraged to use the standard string classes std::string or std::wstring in your applic

Re: [Kicad-developers] Warning regarding global wxStrings and thread-safety

2018-08-02 Thread Jeff Young
Interesting. I also found this: #if wxUSE_UNICODE_UTF8 // NB: In UTF-8 build, (non-const) iterator needs to keep reference // to the underlying wxStringImpl, because UTF-8 is variable-length // encoding and changing the value pointer to by an iterator (using // its operator*)

Re: [Kicad-developers] KiCad v5 build warning

2018-08-02 Thread Adam Wolf
It works fine with macOS, and I've already enabled it for nightlies. On Thu, Aug 2, 2018 at 10:32 PM Seth Hillbrand wrote: > > I'd second Nick's suggestion. Any objections to enabling it by default for > 5.0.1? > > -S > > Am Do., 2. Aug. 2018 um 08:03 Uhr schrieb Nick Østergaard : >> >> Hello >>

Re: [Kicad-developers] Warning regarding global wxStrings and thread-safety

2018-08-02 Thread Tomasz Wlostowski
On 02/08/18 19:01, Jeff Young wrote: > I finally caught a long-standing but very infrequent crash in the > debugger.  It’s somewhat harrowing. > > wxString keeps multiple iterators on a string up-to-date with regard to > editing.  It keeps them in a linked list.  If you reference a global > string