[Kicad-developers] Question on Connectivity Algo

When building zone connectivity, we go through the following two routines: bool ContainsPoint( const VECTOR2I p ) const { auto zone = static_cast ( Parent() ); return m_cachedPoly->ContainsPoint( p, zone->GetMinThickness() ); } int ContainsPoint( const VECTOR2I& aP, int aClearance = 0 )

Re: [Kicad-developers] [PATCH] Add Insert hotkey to add a zone/segment corner

Looks good John. I pushed your patch to the master branch. Thanks for your contribution! -Seth Am Sa., 4. Aug. 2018 um 04:40 Uhr schrieb John Beard : > Hi Seth, > > Sorry about that, I think I've checked the right thing here. > > I suppose many global TOOL_ACTIONs are actually unsafe to call f

Re: [Kicad-developers] Question on Connectivity Algo

Hi Jeff- Am Di., 7. Aug. 2018 um 08:07 Uhr schrieb Jeff Young : > When building zone connectivity, we go through the following two routines: > > bool ContainsPoint( const VECTOR2I p ) const > { > auto zone = static_cast ( Parent() ); > return m_cachedPoly->ContainsPoint( p, zone->GetMinTh

Re: [Kicad-developers] Question on Connectivity Algo

Le 07/08/2018 à 20:14, Seth Hillbrand a écrit : > Hi Jeff- > > Am Di., 7. Aug. 2018 um 08:07 Uhr schrieb Jeff Young >: > > When building zone connectivity, we go through the following two > routines: > > bool ContainsPoint( const VECTOR2I p ) const > { >

[Kicad-developers] Windows performance issue

I did some performance optimisations for POSIX kernels which hugely improves the speed of time-stamping a directory of files. But it’s still (very) slow on MSW. I’ve written a version of the optimisation for MSW, but of course I can’t even compile it, much less test it. Any volunteers? Cheer

Re: [Kicad-developers] Windows performance issue

I triggered this windows build with the patch. https://jenkins.simonrichter.eu:8443/job/windows-kicad-msys2-patch/70/ tir. 7. aug. 2018 21.34 skrev Jeff Young : > I did some performance optimisations for POSIX kernels which hugely > improves the speed of time-stamping a directory of files. But

Re: [Kicad-developers] Question on Connectivity Algo

Am Di., 7. Aug. 2018 um 12:13 Uhr schrieb Jeff Young : > So the polygon of a zone and the zone boundary points are two distinct > data structures? (And the polygon both has the fillet shapes and is inset > by half the minThickness width?) > The polygon (m_Poly) of the zone is just the area that

Re: [Kicad-developers] Windows performance issue

It looks lile the patch does not compile, but maybe the patch was not applied correctly. You should be able to look at the patched code in the workspace. tir. 7. aug. 2018 21.39 skrev Nick Østergaard : > I triggered this windows build with the patch. > > https://jenkins.simonrichter.eu:8443/job/w

Re: [Kicad-developers] Windows performance issue

I think it applied OK. It appears to need some wx header files and some fixes in string handling. I could guess at them, but probably more efficient for someone on MSW. > On 7 Aug 2018, at 20:47, Nick Østergaard wrote: > > It looks lile the patch does not compile, but maybe the patch was not

Re: [Kicad-developers] Question on Connectivity Algo

So the polygon of a zone and the zone boundary points are two distinct data structures? (And the polygon both has the fillet shapes and is inset by half the minThickness width?) Thanks, Jeff. > On 7 Aug 2018, at 19:35, jp charras wrote: > > Le 07/08/2018 à 20:14, Seth Hillbrand a écrit : >>

Re: [Kicad-developers] Question on Connectivity Algo

Cool. Thanks, Seth! > On 7 Aug 2018, at 20:43, Seth Hillbrand wrote: > > Am Di., 7. Aug. 2018 um 12:13 Uhr schrieb Jeff Young >: > So the polygon of a zone and the zone boundary points are two distinct data > structures? (And the polygon both has the fillet shapes and