Re: [Kicad-developers] [PATCH] RFC: toolbar button support for action plugins

2018-08-17 Thread Andrew Lutsenko
Hi Seth, That makes sense. I will keep working on this feature and will ping this thread again once user configuration is implemented. Thanks, Andrew On Fri, Aug 17, 2018 at 10:03 AM Seth Hillbrand wrote: > Hi Andrew- > > I like the patch idea and your implementation approach is good. > > The

Re: [Kicad-developers] [PATCH] RFC: toolbar button support for action plugins

2018-08-17 Thread Seth Hillbrand
Hi Andrew- I like the patch idea and your implementation approach is good. The coding style policy is located at https://kicad-source-mirror.readthedocs.io/en/stable/Documentation/development/coding-style-policy/ We're not totally consistent but we try to ensure any new code follows it and clean

Re: [Kicad-developers] [PATCH] RFC: toolbar button support for action plugins

2018-08-17 Thread Andrew Lutsenko
I found and fixed couple compilation issues and also implemented option to not show toolbar icon, just have the icon in menus. (Not user configurable, just for plugin writers, another attribute they can set). Also fixed formatting according to your directions, thanks. Patches are attached. If

[Kicad-developers] bug 1776648

2018-08-17 Thread Ronnie Gaensli
There's this minor issue with auto pan.. And there's a fix / patch (4 lines). Maybe one of the core developers could have a look. I'm glad to adjust the patch for least possible effort on your side. https://bugs.launchpad.net/kicad/+bug/1776648 Thanks and cheers. Ronnie

Re: [Kicad-developers] [PATCH] RFC: toolbar button support for action plugins

2018-08-17 Thread Clemens Koller
Hi, Andrew! On 17/08/2018 07.10, Andrew Lutsenko wrote: > Or are you asking to update docs in the repo? I suggested to have your sample pluging and icon bundled with your patch, ready for git to apply (once committers agree...). Clemens On 17/08/2018 07.10, Andrew Lutsenko wrote: > Hi

Re: [Kicad-developers] [PATCH] RFC: toolbar button support for action plugins

2018-08-17 Thread Andrew Lutsenko
Hi Seth I just checked out new preferences in pcbnew, looks much more organized than before. I totally can add a new tab there "pcbnew->Action plugins" and list the plugins there with option to remove toolbar icon. But that is a non-negligible amount of work. Will you hold off on merging my