Re: [Kicad-developers] GAL branch

2018-09-24 Thread Jeff Young
Hi Tom, I’m happy to do it. Do I have your latest changes? Cheers, Jeff. > On 24 Sep 2018, at 19:54, Tomasz Wlostowski wrote: > > On 24/09/18 20:07, Wayne Stambaugh wrote: >> Hey Jeff, >> >> On 9/21/2018 9:49 AM, Jeff Young wrote: >>> Hi Tom, >>> >>> Do you have additional fixes that are n

Re: [Kicad-developers] GAL branch

2018-09-24 Thread Tomasz Wlostowski
On 24/09/18 20:07, Wayne Stambaugh wrote: > Hey Jeff, > > On 9/21/2018 9:49 AM, Jeff Young wrote: >> Hi Tom, >> >> Do you have additional fixes that are not in your branch of my repo? >> >> If not, does it make sense for me to rebase it on master? (It would have to >> become “truth” at that poin

Re: [Kicad-developers] [Proposal] merge optional Python3 support

2018-09-24 Thread Wayne Stambaugh
On 9/24/2018 1:07 PM, Seth Hillbrand wrote: > > > Am Mo., 24. Sep. 2018 um 06:20 Uhr schrieb Thomas Pointhuber > mailto:thomas.pointhu...@gmx.at>>: > > Hi, > > I would consider merging Python3 into 5.1 mandatory now, after the > following comment (It seems like Fedora 29 will ship K

Re: [Kicad-developers] GAL branch

2018-09-24 Thread Seth Hillbrand
Am Mo., 24. Sep. 2018 um 11:09 Uhr schrieb Wayne Stambaugh < stambau...@gmail.com>: > From the testing I've done, this seems ready for wider user testing. I > think we ( and by we I mean you and Tom ;) ) should start preparing to > merge this into the development branch. I'm guessing giving the

Re: [Kicad-developers] GAL branch

2018-09-24 Thread Wayne Stambaugh
Hey Jeff, On 9/21/2018 9:49 AM, Jeff Young wrote: > Hi Tom, > > Do you have additional fixes that are not in your branch of my repo? > > If not, does it make sense for me to rebase it on master? (It would have to > become “truth” at that point, but you could clone back from it.) > > Cheers, >

Re: [Kicad-developers] [Proposal] merge optional Python3 support

2018-09-24 Thread Seth Hillbrand
Am Mo., 24. Sep. 2018 um 06:20 Uhr schrieb Thomas Pointhuber < thomas.pointhu...@gmx.at>: > Hi, > > I would consider merging Python3 into 5.1 mandatory now, after the > following comment (It seems like Fedora 29 will ship KiCad without > scripting support enabled due to Python2 dependency): > * ht

Re: [Kicad-developers] [PATCH] Add missing header

2018-09-24 Thread Wayne Stambaugh
On 9/24/2018 10:20 AM, Simon Richter wrote: > Hi, > > On 24.09.2018 16:15, Wayne Stambaugh wrote: > >> Does this affect the 5.0 branch as well? > > No, it's a fixup for Orson's "Refactored logic in Spice model editor > dialog" change, which isn't in the 5.0 branch. > >Simon Simon, I merge

Re: [Kicad-developers] [PATCH] Add missing header

2018-09-24 Thread Simon Richter
Hi, On 24.09.2018 16:15, Wayne Stambaugh wrote: > Does this affect the 5.0 branch as well? No, it's a fixup for Orson's "Refactored logic in Spice model editor dialog" change, which isn't in the 5.0 branch. Simon signature.asc Description: OpenPGP digital signature ___

Re: [Kicad-developers] [PATCH] Add missing header

2018-09-24 Thread Wayne Stambaugh
Simon, Does this affect the 5.0 branch as well? Cheers, Wayne On 9/24/2018 8:49 AM, Simon Richter wrote: > Hi, > > patch ping: this is a trivial change, dialog_spice_model.cpp needs > for std::toupper. > >Simon > > On 22.09.2018 22:32, Simon Richter wrote: >> --- >> eeschema/dialogs/di

Re: [Kicad-developers] [Proposal] merge optional Python3 support

2018-09-24 Thread Thomas Pointhuber
Hi, I would consider merging Python3 into 5.1 mandatory now, after the following comment (It seems like Fedora 29 will ship KiCad without scripting support enabled due to Python2 dependency): * https://github.com/KiCad/fedora-packaging/pull/20#issuecomment-423963638 It seems there is still Python

Re: [Kicad-developers] [Proposal] merge optional Python3 support

2018-09-24 Thread Nick Østergaard
If it would like the optional python3 support in 5.1, I think it makes sense to rebase and merge now on master. On Thu, 20 Sep 2018 at 18:06, Seth Hillbrand wrote: > > I've done some basic tests on Mac with current packaging and doesn't seem to > break anything. Tested footprint generation and a

Re: [Kicad-developers] [PATCH] Add missing header

2018-09-24 Thread Simon Richter
Hi, patch ping: this is a trivial change, dialog_spice_model.cpp needs for std::toupper. Simon On 22.09.2018 22:32, Simon Richter wrote: > --- > eeschema/dialogs/dialog_spice_model.cpp | 2 ++ > 1 file changed, 2 insertions(+) > signature.asc Description: OpenPGP digital signature