I am not 100% up to speed on what's broken yet.
Just for clarifications, we have to compile our nightly builds with the
oldest SDK we want to support, not the newest. The issues we've had when
10.11, 10.12, and 10.13 came out were all issues where users on the new
version were unable to compile
I've been out on business travel this week so I haven't been able to attend
to this at all. This might not be a hard problem to fix, but sometimes it
takes a bit as it can be an issue in a dependency.
Between Seth and I this weekend I'm pretty sure we can get a good handle on
the problem, but
I noticed a comment on a fix to step export on Mac:
"It will be sufficient until we get rid of kicad2step as an external
utility."
Unfortunately I do not see kicad2step being integrated and for a few years now
I wish I had not made the STEP rendering part of the kicad process. The reason
is that
Hi Simon,
You can change those to SetColSize() for now. It’s fixed in master so when I
do another rebase it will pick them up.
Cheers,
Jeff.
> On 29 Sep 2018, at 00:39, Simon Richter wrote:
>
> Hi,
>
>> Really guys, this is an amazing bit of work you've put together. From> my
>> end, I
The branch seems to be fairly buildable. It is only some of the first
commits that does not build well, see
https://jenkins.simonrichter.eu:8443/job/windows-kicad-msys2-evaluate/86/artifact/build-report.txt/*view*/
On Sat, 29 Sep 2018 at 01:39, Simon Richter wrote:
>
> Hi,
>
> > Really guys,
Hi,
> Really guys, this is an amazing bit of work you've put together. From> my
> end, I don't see show stoppers to merging to master.
I have a build failure on MSVC for b487a155f:
eeschema\dialogs\dialog_fields_editor_global.cpp(727): error C2039:
'SetColumnWidth': is not a member of
Yeah, I kind of figured that. All the GTK logic for opening the control from
the keyboard is happening in the native control.
> On 29 Sep 2018, at 00:02, Seth Hillbrand wrote:
>
> Hi Jeff-
>
> Turns out, there is still no triggering of that line. However, setting a
> break on the
Hi Jeff-
Turns out, there is still no triggering of that line. However, setting a
break on the gtk_combo_box_popdown() that it calls does get triggered. I'm
attaching the backtrace.
-S
Am Fr., 28. Sep. 2018 um 12:50 Uhr schrieb Seth Hillbrand <
s...@hillbrand.org>:
> Oh, wait, nevermind.
Hi Devs-
We currently have an issue where KiCad does not run at all on MacOS Mojave
that was just released. It may just be a matter of re-running the full
compile using the Mojave SDK but we should get that running on our nightly
builds.
This normally might not be that big of an issue but the
Oh, wait, nevermind. Sorry, that was without wx debug info. Pls disregard.
Am Fr., 28. Sep. 2018 um 12:47 Uhr schrieb Seth Hillbrand <
s...@hillbrand.org>:
> Hi Jeff-
>
> Does not trigger for me using XFCE/Debian.
>
> -Seth
>
> Am Fr., 28. Sep. 2018 um 12:07 Uhr schrieb Jeff Young :
>
>> Could
Hi Jeff-
Does not trigger for me using XFCE/Debian.
-Seth
Am Fr., 28. Sep. 2018 um 12:07 Uhr schrieb Jeff Young :
> Could I get someone to perform a quick GTK test for me?
>
> Put a breakpoint in wxComboBox::Popup() (line 403 of
> wxWidgets/src/gtk/combobox.cpp
> in my wxWidgets), and then
Could I get someone to perform a quick GTK test for me?
Put a breakpoint in wxComboBox::Popup() (line 403 of
wxWidgets/src/gtk/combobox.cpp in my wxWidgets), and then activate a layer-box
popup (such as in Track & Via Properties) via the keyboard (spacebar, for
instance).
I’d like to know if
We could use the entity-reference strategy for that. A real ‘{’ would get
encoded as “{openbrace}”, so any braces in the encoded string are known to be
encoded-character-clauses.
> On 28 Sep 2018, at 16:21, Wayne Stambaugh wrote:
>
> I prefer readability over verbosity as long as the
I merged your patch into the dev branch.
Thanks,
Wayne
On 09/28/2018 01:30 PM, John Beard wrote:
> Hi,
>
> There is a resource leak in DL_Dxf::test().
>
> This function is never actually used and only provides some kind of
> manual test case. However, the leaks set off static analysers like
>
John,
I merged your patch into the dev branch.
Thanks,
Wayne
On 09/28/2018 01:07 PM, John Beard wrote:
> Hi,
>
> Small patch here to fix a small leak in a unit test.
>
> While the leak is not very exciting here, the other function of unit
> tests is to "document" interfaces by using them
Hi,
There is a resource leak in DL_Dxf::test().
This function is never actually used and only provides some kind of
manual test case. However, the leaks set off static analysers like
Coverity (6 times), so we might as well fix it since it's easy?
Cheers,
John
From
Hi,
Small patch here to fix a small leak in a unit test.
While the leak is not very exciting here, the other function of unit
tests is to "document" interfaces by using them correctly. So this
uses a unique_ptr to make the ownership explicit.
Fixes coverity defect 183869.
Cheers,
John
From
Hi Wayne,
I understand - my question is what would be the better resolution for
lp:1778374 for 5.1 (not 5.0.1)?
I have not done any work on the list dialog yet on any branch, as I
don't want to waste time making a read-only widget if that's not the
preferred method.
My feeling is that it would
I've been testing this out today and it looks great and works perfectly for
me.
There are still some debug messages that are showing in my console when
running release. But that's trivial.
Really guys, this is an amazing bit of work you've put together. From my
end, I don't see show stoppers
Hi John,
That was quick! I merged your patch in the 5.0 branch.
Thanks,
Wayne
On 09/28/2018 10:18 AM, John Beard wrote:
> HI Wayne,
>
> Yes, here is a separate patch for the 5.0 series.
>
> Cheers,
>
> John
> On Fri, Sep 28, 2018 at 3:11 PM Wayne Stambaugh wrote:
>>
>> Hey John,
>>
>>
I prefer readability over verbosity as long as the verbosity isn't too
excessive. We are still going to have to provide some type of escaping
no matter how you look at it. If you are going to use something like
{quoted_character} you still have to provide escaping of the '{' and '}'
characters.
Thanks for the clarification. Wishlist bugs are always tagged for the
next release version so there is no need to make any hotkey list dialog
changes for 5.0.1.
On 09/28/2018 10:42 AM, John Beard wrote:
> Hi Wayne,
>
> I was only planning to make changes to the list dialog (as opposed to
> the
Hey John,
Given that 5.1 is pretty far along and the delta between the 5.0 and
development branches, I would rather you didn't spent a lot of time
trying to back port the dialog fixes which are low priority. I want to
get 5.0.1 tagged as soon as possible and merge the eeschema-gal stuff so
we
Hi Wayne,
I was only planning to make changes to the list dialog (as opposed to
the editor dialog) in the master branch. I'm not planning to backport
any of the filter stuff to 5.0.1.
The aim is to check off https://bugs.launchpad.net/kicad/+bug/1778374
(Wishlist: add search box to Help --> List
Hi Wayne,
Do you have any preference on the hotkey list dialog? I'm happy to go
either way, but I'd like to know the preferred direction before I
spend too much time on it!
Cheers,
John
On Fri, Sep 28, 2018 at 3:11 PM Wayne Stambaugh wrote:
>> Hey John,
>
> Nice work! I merged your patch into
Seth,
On 09/28/2018 09:35 AM, Seth Hillbrand wrote:
>
> Hi Wayne-
>
> Am Fr., 28. Sep. 2018 um 05:00 Uhr schrieb Wayne Stambaugh
> mailto:stambau...@gmail.com>>:
>
> > If we do want to maintain the actual SEGZONE object on the board, we
> > should port the command to clear it over to
HI Wayne,
Yes, here is a separate patch for the 5.0 series.
Cheers,
John
On Fri, Sep 28, 2018 at 3:11 PM Wayne Stambaugh wrote:
>
> Hey John,
>
> Nice work! I merged your patch into the development branch. I do have
> one favor to ask if you have the time. Patch 6 does not apply to the
>
Hey John,
Nice work! I merged your patch into the development branch. I do have
one favor to ask if you have the time. Patch 6 does not apply to the
5.0 branch which also suffers from the crash bug. If you could merge it
into the 5.0 branch and send me a separate patch I would appreciate it.
Hi Wayne-
Am Fr., 28. Sep. 2018 um 05:00 Uhr schrieb Wayne Stambaugh <
stambau...@gmail.com>:
> > If we do want to maintain the actual SEGZONE object on the board, we
> > should port the command to clear it over to GAL as well.
>
> This would be my preference as it keeps with our stance about
For the illegal filename chars I think we’re going to be forced into some sort
of encoding as escaping will still leave the illegal chars there. The question
then becomes do you prioritize verbosity or readability:
my_project{slash}library
my_project%2Flibrary
my_project0x2Flibrary
> On
Seth,
On 09/27/2018 04:37 PM, Seth Hillbrand wrote:
>
>
> Am Mi., 26. Sep. 2018 um 12:23 Uhr schrieb Wayne Stambaugh
> mailto:stambau...@gmail.com>>:
>
> On 9/26/2018 3:16 PM, Seth Hillbrand wrote:
> > Hi Wayne-
> >
> > That will be more luck of the draw in your memory
Hi,
Here is a patch set for adding a filter control to the hotkey editor
dialog. Preview video: https://sendvid.com/je0cyg87
Most of the work in the first commit is separating out the hotkey data
from the UI widget code.
This also fixes a couple of other bugs (one crashing, and one able to
get
That would solve the colon problem but not the other illegal file name
characters such as '/' and '\'. I would like to have a fix for all of
the characters that we currently convert to '_'. I suppose that we
could use a solution like this for all illegal characters but it would
be a bit verbose
Le 27/09/2018 à 22:37, Seth Hillbrand a écrit :
>
>
> Am Mi., 26. Sep. 2018 um 12:23 Uhr schrieb Wayne Stambaugh
> mailto:stambau...@gmail.com>>:
>
> On 9/26/2018 3:16 PM, Seth Hillbrand wrote:
> > Hi Wayne-
> >
> > That will be more luck of the draw in your memory management.
34 matches
Mail list logo