Re: [Kicad-developers] Consistency between symbol and fp editor UIs

2018-10-03 Thread Jeff Young
> Fixed. > That was quick :) > But have you pushed yet? Nope. Still buggy. ;) Cheers, Jeff. ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe :

Re: [Kicad-developers] Consistency between symbol and fp editor UIs

2018-10-03 Thread Eeli Kaikkonen
ke 3. lokak. 2018 klo 20.49 Jeff Young (j...@rokeby.ie) kirjoitti: > Fixed. > That was quick :) But have you pushed yet? > 3. Trying to save without write permission opens dialog which is > different. The symbol editor's dialog is non-technical, the fp editor's is > a technical system message.

Re: [Kicad-developers] Consistency between symbol and fp editor UIs

2018-10-03 Thread Jeff Young
Hi Eeli, > On 3 Oct 2018, at 09:23, Eeli Kaikkonen wrote: > > You may prefer bug reports for this and I can do that, but I thought it might > be good to gather some opinions first. There's more than one issues and I > don't know if I have noticed them all. > > The new library editors with

Re: [Kicad-developers] [PATCH] Hotkey list dialog

2018-10-03 Thread John Beard
Hi Wayne, I know the policy is not to convert wxFB dialogs, but in this case, I don't see how that dialog could be written neatly in wxFB without having the derived class tear half of the components down again if m_read_only is true. The alternative is to duplicate the entire dialog, which is a

Re: [Kicad-developers] [PATCH] Hotkey list dialog

2018-10-03 Thread Wayne Stambaugh
John, Your patch set looks good and works as advertised. I have a few nit-pick comments. I personally prefer making the hotkey list panel hard coded as you did rather than using wxFB but not all developers share my preference in this regard. Since this makes the hotkey list panel more

Re: [Kicad-developers] [PATCH] Hotkey list dialog

2018-10-03 Thread John Beard
Hi, Here's a screenshot of the list widget this creates. I also forgot to mention that this also allows to remove the "InstallOnPanel" workaround to installing the custom hotkey widget on the wxFB panel's placeholder panel. Cheers, John On Wed, Oct 3, 2018 at 4:20 PM John Beard wrote: > > Hi,

Re: [Kicad-developers] [PATCH] Add KICAD_TEMPLATE_DIR to Configure Paths... help

2018-10-03 Thread Wayne Stambaugh
John, I merged your patch. Thanks, Wayne On 10/2/2018 5:42 PM, John Beard wrote: > Hi Wayne, > > Here's the updated patch. The only changes are comments and var names. > > I'll keep looking at wxGrid cell tooltips. If anyone knows if we > already can do that (or WX has an easy way that's

[Kicad-developers] [PATCH] Hotkey list dialog

2018-10-03 Thread John Beard
Hi, Here is a patch sequence for using the hotkey editor widget in a read-only mode to provide a filterable (and slightly prettier) hotkey list. This is a 5.1 milestone. Major details other than the main aim of the list widget: * There are some "common UI" elements introduced here that should

[Kicad-developers] Nicknames for hotkey configs - should be translated?

2018-10-03 Thread John Beard
Hi, Quick question about the "nicknames" parameter for the hotkey config dialog. At all the call sites for the ShowPreferences() dialog, the parameter aHotkeysNickname is constructed with _(). This parameter is used to provide a default name for the hotkey file on export. Does this string

[Kicad-developers] Consistency between symbol and fp editor UIs

2018-10-03 Thread Eeli Kaikkonen
You may prefer bug reports for this and I can do that, but I thought it might be good to gather some opinions first. There's more than one issues and I don't know if I have noticed them all. The new library editors with left side library tree panel have still some inconsistencies which could be