Re: [Kicad-developers] [PATCH]/Question TITLE_BLOCK tests

2018-10-06 Thread Wayne Stambaugh
On 10/06/2018 03:48 PM, John Beard wrote: > Hi Wayne, > > On Sat, Oct 6, 2018 at 5:29 PM Wayne Stambaugh wrote: >> No problem. I will test your patch once you post it. > > Patch attached. Indeed, it was a missing include in the header that > probably worked until now due to serendipitous

Re: [Kicad-developers] [PATCH]/Question TITLE_BLOCK tests

2018-10-06 Thread John Beard
Hi Wayne, On Sat, Oct 6, 2018 at 5:29 PM Wayne Stambaugh wrote: > No problem. I will test your patch once you post it. Patch attached. Indeed, it was a missing include in the header that probably worked until now due to serendipitous include ordering in the existing CPPs. This actually

Re: [Kicad-developers] Patch to draw bitmaps in GAL canvases

2018-10-06 Thread jp charras
Le 06/10/2018 à 16:00, Seth Hillbrand a écrit : > > > Am Sa., 6. Okt. 2018 um 06:58 Uhr schrieb jp charras > mailto:jp.char...@wanadoo.fr>>: > > Le 06/10/2018 à 15:24, Seth Hillbrand a écrit : > > Hi All- > > > > It looks like the bitmap GAL function did not get cherry-picked

Re: [Kicad-developers] Patch to draw bitmaps in GAL canvases

2018-10-06 Thread Seth Hillbrand
Am Sa., 6. Okt. 2018 um 06:58 Uhr schrieb jp charras : > Le 06/10/2018 à 15:24, Seth Hillbrand a écrit : > > Hi All- > > > > It looks like the bitmap GAL function did not get cherry-picked into > > 5.0.1. Was this intentional? > > > > -S > > It was intentional when I committed my work because: >

Re: [Kicad-developers] Patch to draw bitmaps in GAL canvases

2018-10-06 Thread jp charras
Le 06/10/2018 à 15:24, Seth Hillbrand a écrit : > Hi All- > > It looks like the bitmap GAL function did not get cherry-picked into > 5.0.1.  Was this intentional? > > -S It was intentional when I committed my work because: - The opengl code was not good. Thanks to Tomasz to fix it. - the code

Re: [Kicad-developers] [PATCH]/Question TITLE_BLOCK tests

2018-10-06 Thread Wayne Stambaugh
John, I'm getting the following build errors. [ 84%] Building CXX object qa/common/CMakeFiles/qa_common.dir/test_utf8.cpp.o In file included from /home/wayne/src/kicad-trunk/qa/common/test_title_block.cpp:27: /home/wayne/src/kicad-trunk/include/title_block.h:143:5: error: ‘wxArrayString’ does

Re: [Kicad-developers] Patch to draw bitmaps in GAL canvases

2018-10-06 Thread Wayne Stambaugh
IFAIR, this was done to get some testing because it was a fairly large change. I'm fine with cherry-picking this for 5.0.1 since there have not been any bug reports filed on it recently. On 10/06/2018 09:24 AM, Seth Hillbrand wrote: > Hi All- > > It looks like the bitmap GAL function did not

Re: [Kicad-developers] Patch to draw bitmaps in GAL canvases

2018-10-06 Thread Seth Hillbrand
Hi All- It looks like the bitmap GAL function did not get cherry-picked into 5.0.1. Was this intentional? -S ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe :

Re: [Kicad-developers] [PATCH] Expand testing documentation

2018-10-06 Thread Wayne Stambaugh
John, I merged your patch. Thanks, Wayne On 10/04/2018 01:00 PM, John Beard wrote: > Hi, > > Simple patch to give some more/updated details on how to use the unit tests. > > Cheers, > > John > > > > ___ > Mailing list: