Re: [Kicad-developers] [patch] improved support for MS Visual Studio

2019-03-06 Thread Adam Wolf
We have to bundle wxPython / Python / Swig on macOS. Adam On Wed, Mar 6, 2019 at 2:37 PM Tomasz Wlostowski wrote: > On 06/03/2019 20:30, Simon Richter wrote: > > At the moment, MSVC builds lack Python support, so that's a no go, also > > we'd have to redo the entire packaging as that is msys2 b

Re: [Kicad-developers] [patch] improved support for MS Visual Studio

2019-03-06 Thread Tomasz Wlostowski
On 06/03/2019 20:28, Wayne Stambaugh wrote: > Seth, > > On 3/6/2019 2:16 PM, Seth Hillbrand wrote: >> Am 2019-03-06 12:17, schrieb Tomasz Wlostowski: >>> Hi, >>> >>> This patchset enables building KiCad in MS Visual Studio (version 2017, >>> not tested on earlier versions). >> >> Thank you Tom!  I

Re: [Kicad-developers] [patch] improved support for MS Visual Studio

2019-03-06 Thread Tomasz Wlostowski
On 06/03/2019 20:44, Simon Richter wrote: > Hi Tom, > > On 06.03.19 18:17, Tomasz Wlostowski wrote: > >> - prebuilt environment [1], containing the right versions of libraries >> and tools (CMake & CMake modules). The supplied libraries currently >> support only debug x86_64 targets. > > BTW, I

Re: [Kicad-developers] [patch] improved support for MS Visual Studio

2019-03-06 Thread Tomasz Wlostowski
On 06/03/2019 20:30, Simon Richter wrote: > At the moment, MSVC builds lack Python support, so that's a no go, also > we'd have to redo the entire packaging as that is msys2 based as well. > > Python support on MSVC is non-trivial, because there is no such thing as > a default system python. How

Re: [Kicad-developers] [patch] improved support for MS Visual Studio

2019-03-06 Thread Wayne Stambaugh
Simon, On 3/6/2019 2:30 PM, Simon Richter wrote: > Hi Seth, > > On 06.03.19 20:16, Seth Hillbrand wrote: > >> Thank you Tom!  I would love it if, after testing, we could consider >> switching our official MSW builds to MSVC. > > At the moment, MSVC builds lack Python support, so that's a no go,

Re: [Kicad-developers] [patch] improved support for MS Visual Studio

2019-03-06 Thread Tomasz Wlostowski
On 06/03/2019 18:40, Mark Roszko wrote: > On a side note, you can actually run GDB/MSYS2 inside VS2017+ with the > debugger working just fine. I tried, but failed. VS2017 couldn't read the debug symbols generated by GCC/MSYS. Tom > Just a side note and not saying anything bad about this patch. >

Re: [Kicad-developers] [patch] improved support for MS Visual Studio

2019-03-06 Thread Tomasz Wlostowski
On 06/03/2019 18:47, Simon Richter wrote: > Hi Tom, > > On 06.03.19 18:17, Tomasz Wlostowski wrote: > >> This patchset enables building KiCad in MS Visual Studio (version 2017, >> not tested on earlier versions). > > Awesome! > > Patch 5/9 "msvc: enable parallel builds, remove unused compiler >

Re: [Kicad-developers] [patch] improved support for MS Visual Studio

2019-03-06 Thread Tomasz Wlostowski
On 06/03/2019 18:39, Mark Roszko wrote: > Tom, > > Have you looked at vcpkg? > https://github.com/Microsoft/vcpkg > > It's basically Microsoft's C++ library manager that integrates with > CMake standalone and VS2017/VSCode/VS2019. > The downside is the libraries get built on each user's machine f

Re: [Kicad-developers] [patch] improved support for MS Visual Studio

2019-03-06 Thread Simon Richter
Hi Tom, On 06.03.19 18:17, Tomasz Wlostowski wrote: > - prebuilt environment [1], containing the right versions of libraries > and tools (CMake & CMake modules). The supplied libraries currently > support only debug x86_64 targets. BTW, I also have -DCMAKE_RUNTIME_OUTPUT_DIRECTORY:PATH=%WOR

Re: [Kicad-developers] [patch] improved support for MS Visual Studio

2019-03-06 Thread Wayne Stambaugh
Seth, On 3/6/2019 2:16 PM, Seth Hillbrand wrote: > Am 2019-03-06 12:17, schrieb Tomasz Wlostowski: >> Hi, >> >> This patchset enables building KiCad in MS Visual Studio (version 2017, >> not tested on earlier versions). > > Thank you Tom!  I would love it if, after testing, we could consider > sw

Re: [Kicad-developers] [patch] improved support for MS Visual Studio

2019-03-06 Thread Simon Richter
Hi Seth, On 06.03.19 20:16, Seth Hillbrand wrote: > Thank you Tom!  I would love it if, after testing, we could consider > switching our official MSW builds to MSVC. At the moment, MSVC builds lack Python support, so that's a no go, also we'd have to redo the entire packaging as that is msys2 ba

Re: [Kicad-developers] [patch] improved support for MS Visual Studio

2019-03-06 Thread Seth Hillbrand
Am 2019-03-06 12:17, schrieb Tomasz Wlostowski: Hi, This patchset enables building KiCad in MS Visual Studio (version 2017, not tested on earlier versions). Thank you Tom! I would love it if, after testing, we could consider switching our official MSW builds to MSVC. While the mingw project

Re: [Kicad-developers] [patch] improved support for MS Visual Studio

2019-03-06 Thread Wayne Stambaugh
Tom, I don't see anything in this patch set that makes me want to cringe so once 5.1 is released, I'm fine with merging them. Cheers, Wayne On 3/6/2019 12:17 PM, Tomasz Wlostowski wrote: > Hi, > > This patchset enables building KiCad in MS Visual Studio (version 2017, > not tested on earlier v

Re: [Kicad-developers] [patch] improved support for MS Visual Studio

2019-03-06 Thread Simon Richter
Hi Tom, On 06.03.19 18:17, Tomasz Wlostowski wrote: > This patchset enables building KiCad in MS Visual Studio (version 2017, > not tested on earlier versions). Awesome! Patch 5/9 "msvc: enable parallel builds, remove unused compiler parameters" basically undoes patch 3/9 "MSVC support for exte

Re: [Kicad-developers] [patch] improved support for MS Visual Studio

2019-03-06 Thread Alexis Lockwood
Halle-fking-lujah On 3/6/19 10:17 AM, Tomasz Wlostowski wrote: Hi, This patchset enables building KiCad in MS Visual Studio (version 2017, not tested on earlier versions). It is largely based on patches & library builds by Simon Richter (thanks a lot!), with some improvements: - no MSVC-specifi

Re: [Kicad-developers] [patch] improved support for MS Visual Studio

2019-03-06 Thread Mark Roszko
On a side note, you can actually run GDB/MSYS2 inside VS2017+ with the debugger working just fine. Just a side note and not saying anything bad about this patch. On Wed, Mar 6, 2019 at 12:39 PM Mark Roszko wrote: > Tom, > > Have you looked at vcpkg? > https://github.com/Microsoft/vcpkg > > It's

Re: [Kicad-developers] [patch] improved support for MS Visual Studio

2019-03-06 Thread Mark Roszko
Tom, Have you looked at vcpkg? https://github.com/Microsoft/vcpkg It's basically Microsoft's C++ library manager that integrates with CMake standalone and VS2017/VSCode/VS2019. The downside is the libraries get built on each user's machine for a given arch you specify but not that bad. On Wed,

[Kicad-developers] [patch] improved support for MS Visual Studio

2019-03-06 Thread Tomasz Wlostowski
Hi, This patchset enables building KiCad in MS Visual Studio (version 2017, not tested on earlier versions). It is largely based on patches & library builds by Simon Richter (thanks a lot!), with some improvements: - no MSVC-specific patches other than setting the compiler parameters. - no need fo