Re: [Kicad-developers] [PATCH] Crash Reporter

2019-06-04 Thread Nick Østergaard
You can testrun it on windows from: https://kicad-downloads.s3.cern.ch/windows/testing/patched/kicad-patched-371-5.1.0-770-g8bf750311-x86_64.exe On Wed, 5 Jun 2019 at 08:17, Eeli Kaikkonen wrote: > > I'm trying to compile the reporter branch on Kubuntu. The official master > branch compiles fin

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-06-04 Thread Eeli Kaikkonen
I'm trying to compile the reporter branch on Kubuntu. The official master branch compiles fine. But with this branch I get a bunch of linking errors: debug_report.cpp:(.text._ZNSt6thread11_State_implINS_8_InvokerISt5tupleIJZN19DIALOG_CRASH_REPORT12OnSendReportER14wxCommandEventEUlvE_E6_M_runEv

Re: [Kicad-developers] PATCH: fix crash in netlist updater

2019-06-04 Thread Seth Hillbrand
On 2019-06-04 20:03, Andrew Lutsenko wrote: I think I know what's up. You are probably on python 3.7 and my distro is still on 3.6. https://www.python.org/dev/peps/pep-0479/ That proposal changed how StopIteration is handled inside generators, they are no longer handled internally. Change took

Re: [Kicad-developers] PATCH: fix crash in netlist updater

2019-06-04 Thread Andrew Lutsenko
I think I know what's up. You are probably on python 3.7 and my distro is still on 3.6. https://www.python.org/dev/peps/pep-0479/ That proposal changed how StopIteration is handled inside generators, they are no longer handled internally. Change took effect in 3.7. Please see new patch that shou

Re: [Kicad-developers] PATCH: fix crash in netlist updater

2019-06-04 Thread Andrew Lutsenko
I just tried your code on linux, python3 and I don't get any exceptions: import pcbnew b = pcbnew.GetBoard() d = b.GetDrawings() d *' at 0x7fe9769e6d80> > for a in d: print(a) > > ... m = b.GetModules() for mod in m: print(mod) > > ... If you look at generated pcbnew.py (and make

Re: [Kicad-developers] PATCH: fix crash in netlist updater

2019-06-04 Thread Seth Hillbrand
On 2019-06-04 14:23, Andrew Lutsenko wrote: Seth, 1. No, it's not needed. At first I didn't find Cast() in BOARD_ITEMS cpp code so thought it's implemented in descendant classes only and added the check as safeguard like it was done in DList. But now I found that Cast() is in swig python extensi

Re: [Kicad-developers] Show grid in eeschema status line

2019-06-04 Thread Steven A. Falco
On 6/4/19 4:46 PM, Wayne Stambaugh wrote: > On 6/3/19 12:25 PM, Steven A. Falco wrote: >> On 6/3/19 10:42 AM, Wayne Stambaugh wrote: >>> Hi Steve, >>> >>> Your patch no longer applies cleanly as there has been some serious >>> refactoring and legacy code removal. I think your patch is a good idea

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-06-04 Thread Nick Østergaard
I just tried to trigger a crash via the help menu and I see a fine dialog, but that one I don't see for a real crash. On Wed, 5 Jun 2019 at 00:12, Nick Østergaard wrote: > > I mean: I am really on 2745a95b6 > > On Wed, 5 Jun 2019 at 00:11, Nick Østergaard wrote: > > > > Hello > > > > I just chec

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-06-04 Thread Nick Østergaard
I mean: I am really on 2745a95b6 On Wed, 5 Jun 2019 at 00:11, Nick Østergaard wrote: > > Hello > > I just checkout out the crash reporter from Tom's branch. I am not on: > 2745a95b6 (HEAD, tom/tom-crash-reporter-may27) crash_reporter: > correctly install Windows exception handler under Kicad shel

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-06-04 Thread Nick Østergaard
Hello I just checkout out the crash reporter from Tom's branch. I am not on: 2745a95b6 (HEAD, tom/tom-crash-reporter-may27) crash_reporter: correctly install Windows exception handler under Kicad shell I found a place in eeschema where it crashes. Specifically: 1. Open KiCad 2. Load the sallen_ke

Re: [Kicad-developers] Show grid in eeschema status line

2019-06-04 Thread Wayne Stambaugh
On 6/3/19 12:25 PM, Steven A. Falco wrote: > On 6/3/19 10:42 AM, Wayne Stambaugh wrote: >> Hi Steve, >> >> Your patch no longer applies cleanly as there has been some serious >> refactoring and legacy code removal. I think your patch is a good idea >> but it will need to be fixed. I do have a few

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-06-04 Thread Wayne Stambaugh
On 6/4/19 12:31 PM, Tomasz Wlostowski wrote: > On 04/06/2019 17:11, Tomasz Wlostowski wrote: > >> Hi Wayne, >> >> It looks like I screwed up the exception handler under KiCad windows >> shell. Will fix soon. > > Fixed in my github branch. > > T. > As soon as I get home on Sunday, I will test i

Re: [Kicad-developers] Build failure - probably a race generating template_fieldnames_lexer.h

2019-06-04 Thread Steven A. Falco
On 6/4/19 12:41 PM, Seth Hillbrand wrote: > On 2019-06-04 11:07, Steven A. Falco wrote: >> I think I just hit the builder race condition that was discussed a few >> days ago.  I've attached a copy of template_fieldnames_lexer.h.  At >> line 184 there is an #endif, and then part of the file appears

Re: [Kicad-developers] PATCH: fix crash in netlist updater

2019-06-04 Thread Andrew Lutsenko
Seth, 1. No, it's not needed. At first I didn't find Cast() in BOARD_ITEMS cpp code so thought it's implemented in descendant classes only and added the check as safeguard like it was done in DList. But now I found that Cast() is in swig python extension for BOARD_ITEM so it will always be defined

Re: [Kicad-developers] Build failure - probably a race generating template_fieldnames_lexer.h

2019-06-04 Thread Seth Hillbrand
On 2019-06-04 11:07, Steven A. Falco wrote: I think I just hit the builder race condition that was discussed a few days ago. I've attached a copy of template_fieldnames_lexer.h. At line 184 there is an #endif, and then part of the file appears to repeat. Thus, I wind up with an unmatched #endi

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-06-04 Thread Tomasz Wlostowski
On 04/06/2019 17:11, Tomasz Wlostowski wrote: > Hi Wayne, > > It looks like I screwed up the exception handler under KiCad windows > shell. Will fix soon. Fixed in my github branch. T. ___ Mailing list: https://launchpad.net/~kicad-developers Post to

Re: [Kicad-developers] please help translators...

2019-06-04 Thread Marco Ciampa
On Tue, Jun 04, 2019 at 08:17:18AM -0400, Seth Hillbrand wrote: > On 2019-06-04 05:58, Marco Ciampa wrote: > > > > msgid "Filo %s da (%s, %s) a (%s, %s)" > > > > Without any comment in the code it is difficult to translate that string > > in a meaningful and/or correct way until you try to use it

Re: [Kicad-developers] Build faulure

2019-06-04 Thread Jeff Young
OK, that’s really bizarre as that change /removes/ a reference to EDA_3D_VIEWER rather than adds one. Still, it’s safe enough to revert (there’s no real change; it just used to open-code a routine it could have been calling). I’ll merge fixes…. Cheers, Jeff. > On 4 Jun 2019, at 16:19, jp char

Re: [Kicad-developers] Build faulure

2019-06-04 Thread jp charras
Le 04/06/2019 à 16:44, Wayne Stambaugh a écrit : > Jeff, > > The fix didn't work for me. Now I'm getting this error: > > [ 97%] Linking CXX executable qa_pcbnew > /usr/bin/ld: ../../common/libpcbcommon.a(pcb_base_frame.cpp.o): in > function `PCB_BASE_FRAME::Update3DView(bool, wxString const*)':

Re: [Kicad-developers] please help translators...

2019-06-04 Thread Константин Барановский
вт, 4 июн. 2019 г. в 12:59, Marco Ciampa : > ... Il Italian, without any help, that would be translated in this way: > msgstr "%s Filo da (%s, %s) a (%s, %s)" > > that ends up in something like this: > > "Verticale Filo da ... a ..." > > which, in Italian is horrible. > > The right translation is

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-06-04 Thread Tomasz Wlostowski
On 03/06/2019 14:42, Wayne Stambaugh wrote: > On 5/31/19 4:23 PM, Tomasz Wlostowski wrote: >> On 30/05/2019 21:12, Wayne Stambaugh wrote: >>> Nothing was displayed. I was running from the project manager. I even >>> crashed the project manager. I'm using msys2 to create mingw32 and >>> mingw64 d

[Kicad-developers] Build failure - probably a race generating template_fieldnames_lexer.h

2019-06-04 Thread Steven A. Falco
I think I just hit the builder race condition that was discussed a few days ago. I've attached a copy of template_fieldnames_lexer.h. At line 184 there is an #endif, and then part of the file appears to repeat. Thus, I wind up with an unmatched #endif and the compile fails. I tried re-runnin

Re: [Kicad-developers] Build faulure

2019-06-04 Thread Wayne Stambaugh
Jeff, The fix didn't work for me. Now I'm getting this error: [ 97%] Linking CXX executable qa_pcbnew /usr/bin/ld: ../../common/libpcbcommon.a(pcb_base_frame.cpp.o): in function `PCB_BASE_FRAME::Update3DView(bool, wxString const*)': /home/wayne/src/kicad-trunk/pcbnew/pcb_base_frame.cpp:131: unde

Re: [Kicad-developers] Build faulure

2019-06-04 Thread Simon Richter
Hi, > I’ve changed the probably-offending line back to a static_cast, but I can’t > say I’m terribly happy about it. dynamic_cast would be safer…. We have a few more of these in the codebase, around GetElem() calls. common/project.cpp:FP_LIB_TABLE* tbl = (FP_LIB_TABLE*) GetElem( ELEM_FP

Re: [Kicad-developers] Build faulure

2019-06-04 Thread Jeff Young
I’ve changed the probably-offending line back to a static_cast, but I can’t say I’m terribly happy about it. dynamic_cast would be safer…. > On 4 Jun 2019, at 14:53, jp charras wrote: > > Le 04/06/2019 à 15:47, Wayne Stambaugh a écrit : >> I'm getting the following build failure on linux using

Re: [Kicad-developers] [PATCH] Enable floating point exceptions in Debug, disable in Release

2019-06-04 Thread Wayne Stambaugh
On 6/3/19 5:30 PM, Seth Hillbrand wrote: > On 2019-05-28 10:51, Simon Richter wrote: >> Hi, >> >> this enables FP exceptions everywhere in Debug mode, and disables them in >> Release mode. This is for testing only, and should *not* yet go into >> mainline. >> >> Still needed: >> >>  - signal handle

Re: [Kicad-developers] Build faulure

2019-06-04 Thread jp charras
Le 04/06/2019 à 15:47, Wayne Stambaugh a écrit : > I'm getting the following build failure on linux using commit 1fe848f3: > > [ 97%] Linking CXX executable qa_pcbnew > /usr/bin/ld: ../../common/libpcbcommon.a(pcb_base_frame.cpp.o): in > function `PCB_BASE_FRAME::Get3DViewerFrame()': > /home/wayne

[Kicad-developers] Build faulure

2019-06-04 Thread Wayne Stambaugh
I'm getting the following build failure on linux using commit 1fe848f3: [ 97%] Linking CXX executable qa_pcbnew /usr/bin/ld: ../../common/libpcbcommon.a(pcb_base_frame.cpp.o): in function `PCB_BASE_FRAME::Get3DViewerFrame()': /home/wayne/src/kicad-trunk/pcbnew/pcb_base_frame.cpp:117: undefined ref

Re: [Kicad-developers] PATCH: fix crash in netlist updater

2019-06-04 Thread Seth Hillbrand
On 2019-06-04 03:09, Andrew Lutsenko wrote: Hi Seth, Another patch that fixes some bugs in scripting and restores previous dlist behavior. Regards, Andrew Thanks Andrew! A couple questions: - Do we need to check the existence of Cast() for the BOARD_ITEMS? - Does the next() method work for py

Re: [Kicad-developers] please help translators...

2019-06-04 Thread Seth Hillbrand
On 2019-06-04 05:58, Marco Ciampa wrote: msgid "Filo %s da (%s, %s) a (%s, %s)" Without any comment in the code it is difficult to translate that string in a meaningful and/or correct way until you try to use it and find the results, that is not always possible, pratical. Hi Marco- This se

[Kicad-developers] please help translators...

2019-06-04 Thread Marco Ciampa
Dear devs, please help (if this is possible) translators to make translatable strings more meaningful. Example: #: eeschema/sch_line.cpp:629 #, c-format msgid "%s Wire from (%s, %s) to (%s, %s)" Il Italian, without any help, that would be translated in this way: msgstr "%s Filo da (%s, %s) a (%s

Re: [Kicad-developers] PATCH: fix crash in netlist updater

2019-06-04 Thread Andrew Lutsenko
Hi Seth, Another patch that fixes some bugs in scripting and restores previous dlist behavior. Regards, Andrew On Sat, Jun 1, 2019 at 10:06 PM Andrew Lutsenko wrote: > On further digging I believe reason for that is that we no longer use the > extended iterator that is in dlist.i > There is som