Re: [Kicad-developers] [PATCH] Board statistics dialog

2019-07-17 Thread Jeff Young
Hi Alex, I’m about to go on vacation myself so I’ll be on a plane all day tomorrow, but I’ll look at this when I get there. Cheers, Jeff. > On 17 Jul 2019, at 19:06, Alexander Shuklin wrote: > > Hi Jeff, > > That's not a problem. Now I'm on 2 weeks vacation )) > We don't use header capitali

Re: [Kicad-developers] [PATCH] Adapt CMake 3.0 compatibility code for C++14

2019-07-17 Thread Simon Richter
Hi, On Wed, Jul 17, 2019 at 01:24:26PM -0400, Seth Hillbrand wrote: > Any reason to be using the gnu++14 extensions? I thought we were > trying to stay with the vanilla c++14. I went for consistency. This code is pretty much unused anyway, since it only handles the very old CMake versions that

Re: [Kicad-developers] [PATCH] Adapt CMake 3.0 compatibility code for C++14

2019-07-17 Thread Seth Hillbrand
Thanks Simon! Not sure how I missed that one. Any reason to be using the gnu++14 extensions? I thought we were trying to stay with the vanilla c++14. -Seth On 2019-07-17 13:11, Simon Richter wrote: --- CMakeLists.txt | 8 1 file changed, 4 insertions(+), 4 deletions(-)

[Kicad-developers] [PATCH] Adapt CMake 3.0 compatibility code for C++14

2019-07-17 Thread Simon Richter
--- CMakeLists.txt | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 85b029786..cb41e0c15 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -201,12 +201,12 @@ endif() if( CMAKE_VERSION VERSION_LESS 3.1 AND ( CMAKE_COMPILER_IS_GNUCX

Re: [Kicad-developers] [PATCH] Fix handling of filled circle in eagle importer (was only partly fixed)

2019-07-17 Thread Thomas Pointhuber
I would like to send a ping for my two eagle importer fixes. The fix for handling filled circles should be included into 5.1.3, the other one only affects nightly. Both bugs can be reproduced with: https://github.com/SHA2017-badge/PCB Bugs fixed for this specific board: * silkscreen for button

Re: [Kicad-developers] Hotkeys show twice or none...

2019-07-17 Thread jp charras
Le 17/07/2019 à 15:49, Jeff Young a écrit : > Hi JP, > > In commit 6388189f4837447fbf3aa71513f498ae387455ca you removed the page calls > to TransferDataToWindow() to keep from getting duplicate hotkeys. Was that > for GTK? > > If so, I’d guess that GTK calls TransferDataTowindow() recursivel

[Kicad-developers] Hotkeys show twice or none...

2019-07-17 Thread Jeff Young
Hi JP, In commit 6388189f4837447fbf3aa71513f498ae387455ca you removed the page calls to TransferDataToWindow() to keep from getting duplicate hotkeys. Was that for GTK? If so, I’d guess that GTK calls TransferDataTowindow() recursively for child windows while MSW and OSX do not. (In any ca

Re: [Kicad-developers] [PATCH] Board statistics dialog

2019-07-17 Thread Jeff Young
Hi Alex, No need for apologies. It’s a steep learning curve. Some more comments: 1) Dialog items use sentence-capitalization and colons; dialog headers use title-capitalization and no colons. So “Components:” should be “Components”, “Front side:” should be “Front Side”, etc. 2) Right-align

Re: [Kicad-developers] [PATCH v2 0/8] MSVC Build

2019-07-17 Thread Simon Richter
Hi Wayne, On Tue, Jul 16, 2019 at 06:24:30PM -0400, Wayne Stambaugh wrote: > I'm ready to push this patch set. I'm assuming this is the same changes > as the merge request. If not please let me know. The merge request is better: - two small fixes for things that happened while rebasing -