[Kicad-developers] [Patch] Another hotkey processing fix

2019-08-08 Thread Ian McInerney
In the current framework, if more than one global actions share the same hotkey (even if they are not all active in the current tool manager), the dispatcher will only choose the final action (in what seems to be alphabetical order) to run. I think that the correct behavior should instead be to

Re: [Kicad-developers] Coding style question

2019-08-08 Thread Seth Hillbrand
+1 for typing out the first definition. In functions, I'd be in favor of using 'auto' and 'decltype' when declaring local variables that need to match the class variable. Best- Seth On 2019-08-08 02:43, Jeff Young wrote: When I worked at Frame a colleague advised me not to create Framegol.

Re: [Kicad-developers] Anyone know where the sources to the simulation cursors are?

2019-08-08 Thread Maciej Suminski
Hi Jeff, I have just checked the new features, well done! Cheers, Orson On 8/7/19 7:47 PM, Jeff Young wrote: > Hi Orson, > > I needed to make a current-probe, so I created a new voltage-probe to match. > > Try the SPICE probe out and see what you think. (You should get a > voltage-probe

Re: [Kicad-developers] Coding style question

2019-08-08 Thread Wayne Stambaugh
Tom, On 8/7/19 6:18 PM, Tomasz Wlostowski wrote: > Hi Fellow Devs, > > I'm fixing some memory management issues in the P by introducing smart > pointers here and there. Do we have any coding policy on typedefing > shared_ptrs/unique_ptrs? > > Should I: > - always use std::shared_ptr explicitly?

Re: [Kicad-developers] Coding style question

2019-08-08 Thread Simon Richter
Hi Tom, > - always use std::shared_ptr explicitly? I'd vote for explicit smart pointers in function signatures and member definitions, and "auto" in places where it can be deduced. MSVC's /ANALYZE also has some helpful diagnostics like C26418[1] "Shared pointer parameter X is not copied or

Re: [Kicad-developers] Coding style question

2019-08-08 Thread Jeff Young
When I worked at Frame a colleague advised me not to create Framegol. (That was back in the day when Pascal and C were considered Algol family languages.) I’ve always taken that to heart and so prefer std::shared_ptr, ugly as it is. Cheers, Jeff. > On 7 Aug 2019, at 23:18, Tomasz Wlostowski

Re: [Kicad-developers] GAL layer question

2019-08-08 Thread Jeff Young
Yes, that’s another option. Eeschema doesn’t currently hide selected objects and create clones in the preview, but it could. Cheers, Jeff. > On 7 Aug 2019, at 23:15, Tomasz Wlostowski wrote: > > On 07/08/2019 19:45, Jeff Young wrote: >> Hi Orson, >> >> I wanted to keep the selection