Re: [Kicad-developers] Allowable character set for symbols and footprints

2019-09-06 Thread Cirilo Bernardo
Offhand I don't know if other characters can be allowed. This is not so much a limitation of any specific system, but a requirement to ensure that there are never any problems with the filenames when used on any system. So as far as file naming goes, I'd say stick to those strict limitations.

Re: [Kicad-developers] [PATCH 2/2] Remove questionable useless casts

2019-09-06 Thread Simon Richter
Hi, On Fri, Sep 06, 2019 at 10:09:07PM -0400, Reece R. Pollack wrote: > >-const float posYfactor = (float)(windowsPos.y + y * > >4.0f) / (float)m_windowSize.y; > >+const float posYfactor = windowsPos.y + y * 4.0f / > >(float)m_windowSize.y; > These are

Re: [Kicad-developers] [PATCH 2/2] Remove questionable useless casts

2019-09-06 Thread Reece R. Pollack
On 9/6/19 6:36 PM, Simon Richter wrote: -const float posYfactor = (float)(windowsPos.y + y * 4.0f) / (float)m_windowSize.y; +const float posYfactor = windowsPos.y + y * 4.0f / (float)m_windowSize.y; These are mathematically different expressions. You

[Kicad-developers] [PATCH 2/2] Remove questionable useless casts

2019-09-06 Thread Simon Richter
These are also reported by gcc -Wuseless-casts as having the same source and destination type, so the new code is equivalent to the old, but it is less immediately obvious that this interpretation was originally intended. --- .../3d_render_raytracing/c3d_render_raytracing.cpp| 2 +-

[Kicad-developers] [PATCH 1/2] Remove useless casts

2019-09-06 Thread Simon Richter
This removes casts where source and destination type are identical, as reported by gcc -Wuseless-cast. All of these should be trivial. --- 3d-viewer/3d_cache/sg/sg_helpers.h | 4 ++-- 3d-viewer/3d_canvas/create_layer_items.cpp | 10 +-

[Kicad-developers] [PATCH 0/2] Remove useless casts

2019-09-06 Thread Simon Richter
Hi, I have two patches that remove useless casts. The first covers cases where it is quite obvious that the cast can be removed with no adverse effects, the second contains the cases where that is less clear. In theory, both can be applied and should not cause code changes, but the second needs

Re: [Kicad-developers] Allowable character set for symbols and footprints

2019-09-06 Thread Jeff Young
Hi Evan, The code prohibits the following in filenames: \/:"<>| Note that the prohibited list does not include spaces. (In theory all the escaping bugs are now fixed.) Netnames (and therefore pin names and labels) don’t have filename constraints, so you can in theory use anything that’s not

[Kicad-developers] Allowable character set for symbols and footprints

2019-09-06 Thread Evan Shultz
Hi all, http://kicad-pcb.org/libraries/klc/G1.1/ shows a limited set of characters that can be used in the official library. https://github.com/KiCad/kicad-symbols/pull/2090 sparked a conversation about allowing other characters, and as one of the librarians I want to solicit dev input. 1. Can

Re: [Kicad-developers] [RFC] Comments for a Layer Stack Manager in Pcbnew

2019-09-06 Thread Evan Shultz
Sorry if this is mixing things since Michael replied after me. Continuing on with the numbering I used above: 8. To clarify, I meant the material name in the Material column, not the layer name in the Name column. I assume this would fit in with adding custom materials which is to be done later.

Re: [Kicad-developers] [RFC] Comments for a Layer Stack Manager in Pcbnew

2019-09-06 Thread jp charras
Le 06/09/2019 à 12:04, Michael Kavanagh a écrit : > Hi JP, > > This will be a great addition to KiCad, and I'm excited to see this > progress. Now it's merged into master, would you prefer feedback on > the mailing list or bug reports? > > In any case, the panel display seems to be broken on