Ian,
Your patch is working, the new node is selected after rename as it is
expected now.
While testing your patch I found yet another bug in the project manager
(most likely unrelated to this patch), I'll report it later.
Thank you for your kind words.
Best regards,
Mikołaj Wielgus
On Sun,
Ok, I have pushed the fixes for the rename tree update, and an attempt to
fix the item selection after rename. Since Gtk uses the rename event, I
can't test the add code path easily (it is probably time I actually tried
to set up my mac and Windows build environments). It would be good to
verify
I've tested Ian's patch on Windows 10 and it works correctly for me, with
exception to the same selection problem, as well.
I've done simple logging and found out that the rename event routine is not
executed during rename, but the delete and create event routines are, in
this order.
On 2019-11-16 11:03, Steven A. Falco wrote:
On 11/16/19 1:14 PM, Seth Hillbrand wrote:
On 2019-11-16 08:42, Steven A. Falco wrote:
It looks like Fedora may be switching from OCE to OCC, so I'm doing a
trial build with OCC.
How would folks recommend testing the build? I'm not sure what would
On 11/16/19 1:14 PM, Seth Hillbrand wrote:
> On 2019-11-16 08:42, Steven A. Falco wrote:
>> It looks like Fedora may be switching from OCE to OCC, so I'm doing a
>> trial build with OCC.
>>
>> How would folks recommend testing the build? I'm not sure what would
>> be necessary.
>>
>>
>> Also, I
On 2019-11-16 08:42, Steven A. Falco wrote:
It looks like Fedora may be switching from OCE to OCC, so I'm doing a
trial build with OCC.
How would folks recommend testing the build? I'm not sure what would
be necessary.
Also, I have a question about CMakeLists.txt. Around line 91, it says:
I can confirm your observation. I have been using occ for some time and
don't see any issues with switching other than the build script needs to
disable oce explicitly.
lør. 16. nov. 2019 17.42 skrev Steven A. Falco :
> It looks like Fedora may be switching from OCE to OCC, so I'm doing a
>
It looks like Fedora may be switching from OCE to OCC, so I'm doing a trial
build with OCC.
How would folks recommend testing the build? I'm not sure what would be
necessary.
Also, I have a question about CMakeLists.txt. Around line 91, it says:
option( KICAD_USE_OCC
"Build tools and
Thanks for testing. I had noticed the selection issue on GTK as well, so I
will fix it up before I push it.
The file system watcher is a finiky creature. GTK for sure uses the rename
events (I traced those through the logic last night), but according to the
docs
On 2019-11-15 16:54, Mikołaj Wielgus wrote:
- Project manager multiple selection options:
It appears that implementing these enchancements would require
significant changes to the project manager code, since much of the
actions is implemented in TREEPROJECT_ITEM class itself, hence a
How bizarre. Make you wonder how it worked on Mac and Windows. (Hmmm… I
wonder if GTK goes through wxFSW_EVENT_RENAME and Mac and Windows go through
wxFSW_EVENT_DELETE and wxFSW_EVENT_CREATE?)
Your patch works on OSX except for one thing: it doesn’t get the selection
right (selecting the
11 matches
Mail list logo
