Re: [Kicad-developers] , and the format checker

2020-01-21 Thread Seth Hillbrand
Place an empty line between "#include " and the rest of the includes to keep it in order. The nice thing about alphabetic is that you can find/remove/prevent duplicates. You can apply this at the same time as the storage location grouping, again with using spaces to keep from re-arranging

Re: [Kicad-developers] auto conversion of sch file not working

2020-01-21 Thread Rene Pöschl
Hi, I made a tutorial quite some time ago explaining step by step how to prepare your project for remapping and how you can fix any errors that might ocour. See https://forum.kicad.info/t/converting-kicad-version-4-projects-to-version-5-remap-a-project/13767 I hope this is of help to you or

Re: [Kicad-developers] , and the format checker

2020-01-21 Thread Wayne Stambaugh
I'm thinking "config.h" needs to be included before any of the kicad header files. I'm not terribly thrilled about alphabetizing the include files per clang-format and we certainly shouldn't be using it in this case. I always grouped them according to where they are defined even though it's not

[Kicad-developers] , and the format checker

2020-01-21 Thread Simon Richter
Hi, we have a build failure on MSVC because ngspice.cpp no longer includes . This file should really be included first by any cpp file, because it uses macros to work around compiler differences. The format checker rightly suggests that, as it is a <> include from the local project, it should go

[Kicad-developers] kicad github wiki

2020-01-21 Thread Felix Vollmer
Hi, the kicad source mirror wiki (https://github.com/KiCad/kicad-source-mirror/wiki) had some very outdated information about the old kicad bzr repository at launchpad. I went ahead and removed all the outdated information and added a link to the new gitlab repository. Since the permissions

Re: [Kicad-developers] auto conversion of sch file not working

2020-01-21 Thread Wayne Stambaugh
On 1/20/20 7:18 PM, Dick Hollenbeck wrote: > On 1/20/20 11:44 AM, Wayne Stambaugh wrote: >> Is mylib an entry in the list of libraries below the >> >> LibDir=/i/pcbs/kicad_parts;/usr/local/share/kicad/library > > Does this not illustrate a yes to your question? There should be an entry

[Kicad-developers] Rebasing aftermath

2020-01-21 Thread Seth Hillbrand
Hi Lead Devs- After this weekend, we will need to be extra careful with MRs. By default, the `git rebase` command on the new master will include 4 extra commits. This happens for command-line as well as GitLab web rebases. They will need to be dropped from each branch before merging. As

Re: [Kicad-developers] Rebase the tree?

2020-01-21 Thread Ian McInerney
They look fine, no contamination with build files. Are you doing an in-tree build (running cmake at the root of the repository)? -Ian On Tue, Jan 21, 2020 at 9:33 AM Jeff Young wrote: > FWIW, my Git tried to add the two files again (I guess from its local > history). I think I caught it in

Re: [Kicad-developers] Rebase the tree?

2020-01-21 Thread Jeff Young
FWIW, my Git tried to add the two files again (I guess from its local history). I think I caught it in time and cancelled. I then rebased without the two commits, and without Ian’s commits to remove them (which were also in my history). So I think I’m up-to-date now, but if someone could

Re: [Kicad-developers] Rebase the tree?

2020-01-21 Thread Jonatan Liljedahl
Perhaps the git commit hook can include a check for file size and complain if larger than some-arbitrary-threshold? On Tue, Jan 21, 2020 at 12:43 AM Wayne Stambaugh wrote: > > No problem. Hopefully it wont cause too many issues for other devs who > have to rebase any local changes. > > Cheers,