uptive as they are now.
I second this. There are quite a few outstanding patches that will likely have
enough conflicts so I would rather not pile more on top of that.
Regards, Orson On 09/23/2017 12:17 PM, Camille 019 wrote:
Hi all, I recently play with clang-tidy on the KiCad source code. Here is
Hi,
A set of patch to clean some warnings I get with Clang.
The list of warnings :
../pcbnew/router/pns_router.cpp:208:10: warning: unused variable 'nonOrtho'
[-Wunused-variable]
bool nonOrtho = false;
../pcbnew/router/pns_topology.cpp:385:21: note: use function 'std::abs' instead
Hi,
Here a set of patch to remove some compiler warnings.
--
Camille
kicad-3Dviewer-Wparentheses-equality.diff
Description: Binary data
kicad-3Dviewer-Wsometimes-uninitialized.diff
Description: Binary data
kicad-warnings.diff
Description: Binary
Hi,
Here is a patch to fix a bad field declaration in SEG class.
B is declared as an object and not as a reference as expected.
To avoid this kind of bugs it is preferable to declare only one field per line.
--
Camille
patch_SEG.diff
Description:
Hi,
Here is 2 patch to remove some Clang warnings.
* a struct/class mismatched tags
* /pcbnew/router/direction.h:293:19: warning: comparison of constant 8 with
expression of type 'DIRECTION_45::Directions' is always false
[-Wtautological-constant-out-of-range-compare]
if( m_dir= 8 )
Date: Sat, 19 Apr 2014 17:44:25 +0200
From: l.marcanto...@logossrl.com
On Sat, Apr 19, 2014 at 04:02:21PM +0200, Camille 019 wrote:
* /pcbnew/router/direction.h:293:19: warning: comparison of constant 8 with
expression of type 'DIRECTION_45::Directions' is always false
[-Wtautological
Hi,
Have you planned to apply these patchs or not ?
From: camille...@outlook.com
To: kicad-developers@lists.launchpad.net
Date: Mon, 3 Mar 2014 19:02:44 +0100
Subject: [Kicad-developers] [patch] Warnings removal
Here is a set of 3 patch to remove some
Here is a set of 3 patch to remove some warning.
* in-class initializer for static data member of type 'const double' is a GNU
extension [-Wgnu-static-float-init]
* struct/class '???' was previously declared as a class/struct
[-Wmismatched-tags]
* implicit conversion of NULL constant to 'bool'
Date: Sat, 22 Feb 2014 11:45:33 -0500
From: stambau...@verizon.net
To: kicad-developers@lists.launchpad.net
Subject: Re: [Kicad-developers] Menu icons
On 2/22/2014 9:53 AM, Wayne Stambaugh wrote:
On 2/22/2014 8:40 AM, Miguel Angel wrote:
The context
Hi,
The attached patch change conditional inclusion around pragma implementation
to avoid unknown pragma warnings with Clang.
--
Camille
clang-unknow-pragma.diff
Description: Binary data
___
Mailing list:
The attached patch update GLM to version 0.9.4.6 . This patch remove the
following Clang warning.
include/gal/opengl/glm/gtc/../core/func_integer.inl:106:95: warning: operator
'' has lower precedence than '-'; '-' will be evaluated first
[-Wshift-op-parentheses]
return
The attached patch update GLM to version 0.9.4.6 . This patch remove the
following Clang warning.
include/gal/opengl/glm/gtc/../core/func_integer.inl:106:95: warning: operator
'' has lower precedence than '-'; '-' will be evaluated first
[-Wshift-op-parentheses]
return
HI,
Here is a patch to remove some Clang warnings.
Camille
kicad-warning.diff
Description: Binary data
___
Mailing list: https://launchpad.net/~kicad-developers
Post to :
So, here is an updated patch. It applies the boost::polygon workaround only to
GCC 4.7.0 - 2 and remove KICAD_GCC_{RELEASE,DEBUG}_BUILD_FLAGS.
Camille
kicad-testing_bzr4404.patch
Description: Binary data
Hello,
In CMakeLists.txt there is a wokaround to fix the bug #1056926.
I removed this workaround and I am not able to reproduce the bug with recent
version of GCC (4.8.1) and boost (1.54). Cut out in Zone work fine for me with
-O1, -O2 and -O3 optimization level for GCC
15 matches
Mail list logo
