Re: [Kicad-developers] [RFC] 3D models repository

2017-06-28 Thread Cheng Sheng
Good-to-know knowledge. Thanks for the education, Javier. So if I do some minor changes to some file with "Copyright John Smith 2017" and since it is minor I don't even bother adding a second line there, does it imply "I'm passing my copyright ownership to John Smith" or actually the copyright hol

Re: [Kicad-developers] fp_arc confusion

2017-06-28 Thread Cheng Sheng
or use boost::variant and switch to std::variant in the future? On 28 June 2017 at 00:18, hauptmech wrote: > The tokens for circles are fine. > > I suspect it will come up about as often as it has (so once in 5 years?). > > Perhaps you could a couple lines of documentation for fp_arc in the file

Re: [Kicad-developers] Patch: Open Datasheet in Project Dir

2017-06-06 Thread Cheng Sheng
://docs.kicad-pcb.org/doxygen/md_Documentation_ > development_coding-style-policy.html > > On 6/6/2017 8:17 AM, Cheng Sheng wrote: > > Thanks, Wayne. See the new attachment with "wxURL" for testing URLs and > > updated AUTHORS.txt. Retested that both cases (http://... and >

Re: [Kicad-developers] Patch: Open Datasheet in Project Dir

2017-06-06 Thread Cheng Sheng
you work > for. > > Thanks, > > Wayne > > [1]: > http://docs.wxwidgets.org/3.0/classwx_u_r_l.html# > a9837df16ff9f8daf91e5569265cfbe60 > > On 5/31/2017 5:43 PM, Cheng Sheng wrote: > > I see. This is also doable. I updated the patch to resolve en

Re: [Kicad-developers] Patch: Open Datasheet in Project Dir

2017-05-31 Thread Cheng Sheng
orks, hence I would have > assumed it would aslo for for other paths. Maybe that is a better > solution in this case to keep things consistent. > > 2017-05-31 17:39 GMT+02:00 Cheng Sheng : > > Hi Nick, > > > > Could you be a little more specific? Do you mean: > > >

Re: [Kicad-developers] Patch: Open Datasheet in Project Dir

2017-05-31 Thread Cheng Sheng
ing the KIPRJMOD as is? > > 2017-05-31 15:17 GMT+02:00 Cheng Sheng : > > Thanks, Fabrizio. It's good to know such info that is not mentioned in > the > > doc. I'm indeed quite new to contributing code here. > > > > Regards, > > Cheng > > > &

Re: [Kicad-developers] Patch: Open Datasheet in Project Dir

2017-05-31 Thread Cheng Sheng
in and what stays out. And normally common good is paramount. > > cheers > Fabrizio > > > > > > > > On Wed, May 31, 2017 at 11:49 AM, Cheng Sheng > wrote: > >> okay, thanks for the info, Sergey. >> >> Don't find any explicit rule on ho

Re: [Kicad-developers] Patch: Open Datasheet in Project Dir

2017-05-31 Thread Cheng Sheng
itioning. Thanks. Regards, Cheng On 31 May 2017 at 11:01, Sergey A. Borshch wrote: > On 31.05.2017 10:57, Cheng Sheng wrote: > >> So is there any conclusion on this patch like it will be accepted or >> rejected or needs some improvement? >> >> Sergey, are you a patch

Re: [Kicad-developers] Patch: Open Datasheet in Project Dir

2017-05-31 Thread Cheng Sheng
So is there any conclusion on this patch like it will be accepted or rejected or needs some improvement? Sergey, are you a patch reviewer who can commit to the repo, or I need to add someone explicitly? Thanks. Regards, Cheng On May 29, 2017 12:33 PM, "Cheng Sheng" wrote: On 29 M

Re: [Kicad-developers] Patch: Open Datasheet in Project Dir

2017-05-29 Thread Cheng Sheng
On 29 May 2017 at 09:40, Sergey A. Borshch wrote: > On 28.05.2017 23:49, Cheng Sheng wrote: > >> I myself prefer storing all files specific to the project within the >> project directory, including datasheets, components, adjusted footprints >> and scripts. This way ma

Re: [Kicad-developers] Patch: Open Datasheet in Project Dir

2017-05-28 Thread Cheng Sheng
based on my own workflow. Regards, Cheng On 28 May 2017 at 20:53, Ingo Kletti wrote: > Am 28.05.2017 um 18:47 schrieb Sergey A. Borshch: > >> On 28.05.2017 14:35, Cheng Sheng wrote: >> >>> So I made a patch to resolve the path before it is passed to >>> "w

Re: [Kicad-developers] [PATCH 0/4] Use of "virtual" and "override" keywords

2016-07-14 Thread Cheng Sheng
To Simon: Fair. It is indeed a little odd that C++ committee decides to put one before but one after the signature. Only that you might want to write it in the style guide; otherwise, both styles will appear in the future. To Mark: I said {the use of both is redundant}, not {one of them is redunda

Re: [Kicad-developers] [PATCH 0/4] Use of "virtual" and "override" keywords

2016-07-13 Thread Cheng Sheng
Why both "virtual" and "override" in "struct C"? It is redundant (you cannot override a non-virtual function). See http://en.cppreference.com/w/cpp/language/override. Regards, Cheng On Wed, Jul 13, 2016 at 1:27 AM, Simon Richter wrote: > Hi Wayne, > > On 12.07.2016 16:07, Wayne Stambaugh wrote:

Re: [Kicad-developers] Interesting consequence of "subtract soldermask from silkscreen"

2016-06-16 Thread Cheng Sheng
Random thought: Make some positive thing to subtract away. 1. What about drawing a small dot under each pad? It is surely subtracted but you still have some positive images so you don't have a negative-only film to be "corrected". 2. What about picking some empty region to add a dot then subtract i

Re: [Kicad-developers] pcbnew feature: Vias on Solder Mask Layers

2016-06-13 Thread Cheng Sheng
Thanks for the hints, Tomasz! On Sun, Jun 12, 2016 at 11:47 PM, Tomasz Wlostowski < tomasz.wlostow...@cern.ch> wrote: > On 12.06.2016 20:06, Prabhu Sammandam wrote: > > Hi Jean-Pierre, > > > > Yes I accept. Why I am bothering is that, it is wasting the toner. > > > > I need to take two prints and

Re: [Kicad-developers] pcbnew feature: Vias on Solder Mask Layers

2016-06-12 Thread Cheng Sheng
okay... I didn't even notice that "Plot" can output pdf/ps directly! Thought it was Gerber only. Then this change can be skipped, indeed it doesn't add any new functionality. Thanks for the comments, guys. On Sun, Jun 12, 2016 at 6:44 PM, jp charras wrote: > Le 12/06/2016 à 18:29, Prabhu Samma