Re: [Kicad-developers] Proof-of-concept for better contrasting netnames in pcbnew

2013-04-10 Thread Marco Mattila
On Mon, Apr 8, 2013 at 3:06 PM, Lorenzo Marcantonio l.marcanto...@logossrl.com wrote: The idea is to have more legible net names on pads and tracks when using light colours (it can happen using the net highlighting, as shown). Any idea/comment? The high-contrast net names look good. However,

Re: [Kicad-developers] Help building on F16

2013-01-09 Thread Marco Mattila
On Wed, Jan 9, 2013 at 7:45 PM, jp charras jp.char...@wanadoo.fr wrote: I was aware of this lib (It comes from LibreCAD) but I did not found any doc to use it (no document and no comments in sources) Have you some doc? No, I just stared at the code for a while. It seems that one has to

[Kicad-developers] Circular interpolation in gerbers

2012-07-11 Thread Marco Mattila
Hi, Currently gerbers plotted from pcbnew approximate arcs and circles using linear segments. I implemented circle and arc plotting using the native gerber circular interpolation commands (G02/03) in the multi-quadrant mode. The output looks good in gerbview and gerbv. However, before committing

Re: [Kicad-developers] Rev 3597: Add zone duplication to pcbnew.

2012-06-05 Thread Marco Mattila
On Tue, Jun 5, 2012 at 9:47 AM, jean-pierre charras jp.char...@wanadoo.fr wrote: Your commit about zone duplication has *very* serious issues and currently breaks Pcbnew: - No test is made, so a zone can be added to the same layer (duplicate zone on same layers) - No DRC performed on the new

Re: [Kicad-developers] Recently commited changes bzr3430 compilation warnings (to Marco Mattila).

2012-02-23 Thread Marco Mattila
On Thu, Feb 23, 2012 at 12:57 PM, Александр Закамалдин zak...@mail.ru wrote: This changes causes the compilation warnings 'comparison of signed and unsigned integer expressions'. It would be good to investigate this issue and fix it. Fixed. Let me know if there are any GOST issues with the

Re: [Kicad-developers] Zone corner chamfers/fillets and CPolyLine

2011-02-22 Thread Marco Mattila
There's now support for zone corner smoothing in pcbnew. However, an issue remains with zones with cut-outs. Will be taken care of shortly. marco ___ Mailing list: https://launchpad.net/~kicad-developers Post to :

Re: [Kicad-developers] Zone corner chamfers/fillets and CPolyLine

2011-02-14 Thread Marco Mattila
On Mon, Feb 14, 2011 at 7:32 PM, jean-pierre charras jp.char...@wanadoo.fr wrote: What do you mean by fillet zone corners ? I mean rounding corners. I am thinking both KBool and Boost::polygon have functions to chamfer polygons outlines. But I am not sure. I think that the

Re: [Kicad-developers] [PATCH] Saving plot dialog settings

2011-02-09 Thread Marco Mattila
On Wed, Feb 9, 2011 at 5:35 PM, Wayne Stambaugh stambau...@verizon.net wrote: It looks good.  It certainly is a huge improvement over the old dialog.  Aside from some minor alignment issues the only comment I have is what does the Apply Settings button do?  If it just copies the dialog settings

Re: [Kicad-developers] [PATCH] Saving plot dialog settings

2011-02-03 Thread Marco Mattila
On Thu, Feb 3, 2011 at 6:32 PM, Jerry Jacobs xor.gate.engineer...@gmail.com wrote: For me the dialog is very very good, and works as expected. Still the issue remains that the dialog can't be closed with the window button and the cancel button. I hacked a class function DIALOG_PLOT_BASE::OnQuit

Re: [Kicad-developers] Cursor position improvements.

2011-02-02 Thread Marco Mattila
On Wed, Feb 2, 2011 at 4:38 PM, Wayne Stambaugh stambau...@verizon.net wrote: Desirable would have been a better term here.  I am hoping to do away with the drawn cross hairs and use the stock cross hairs cursor which will make this behavior impossible. The good thing about having the cursor

Re: [Kicad-developers] [PATCH] Saving plot dialog settings

2011-01-30 Thread Marco Mattila
On Sun, Jan 30, 2011 at 3:20 PM, jean-pierre charras jp.char...@wanadoo.fr wrote: Most of time plot subdirectory is a subdirectory of the current working directory. Mainly in this case (easy to detect), the stored path must be relative to the CWD. Do not forget the CWD can easily change for a

Re: [Kicad-developers] [PATCH] Saving plot dialog settings

2011-01-29 Thread Marco Mattila
On Sat, Jan 29, 2011 at 10:24 PM, Marco Mattila marco...@gmail.com wrote: I've been rearranging the plot dialog. The current status is shown in the attachment. There should be enough room to add a checkbox for marking the path relative. On second thought, it should be possible to infer from

Re: [Kicad-developers] [PATCH] Saving plot dialog settings

2011-01-28 Thread Marco Mattila
On Fri, Jan 28, 2011 at 12:21 AM, Dick Hollenbeck d...@softplc.com wrote: Any complex string that is capable of having either whitespace or quotes in it should be wrapped using aFormatter-Quoted( CONV_TO_UTF8(blah) ).c_str(), I'm working on this now. Should there be something like if(

Re: [Kicad-developers] RC3a feedback

2011-01-13 Thread Marco Mattila
If there's more than one board in a project, the board file might more suitable. It's the same thing with the plotting options that were discussed earlier. However, I think that typically people have only one board per project (?). marco On Thu, Jan 13, 2011 at 3:25 PM, Wayne Stambaugh

Re: [Kicad-developers] [PATCH] Footprint reference/value text size patch

2011-01-09 Thread Marco Mattila
Committed an edited version of this patch. marco On Thu, Nov 11, 2010 at 9:32 PM, Marco Mattila marco...@gmail.com wrote: Hi, I'm reposting this patch since the original has probably gone missing due to a non-conformant subject line. The original discussion is in this thread: https

Re: [Kicad-developers] [PATCH] Zone clearance to pcb edge etc.

2011-01-09 Thread Marco Mattila
Committed this patch (this time using bazaar branch nick testing, if that makes any difference). marco On Sat, Jan 1, 2011 at 6:33 PM, Marco Mattila marco...@gmail.com wrote: Hi, It seems that currently the clearances between zones and pcb edge segments (and text items and module edge

Re: [Kicad-developers] [PATCH] Saving plot dialog settings

2011-01-05 Thread Marco Mattila
Damn. I always struggle the most with the comments for Doxygen... I think that we may be able to get rid of the global variable. I'll take a look. I'll fix the comments in the next patch, too. marco On Wed, Jan 5, 2011 at 3:24 PM, Wayne Stambaugh stambau...@verizon.net wrote: This is a nice

Re: [Kicad-developers] [PATCH] Saving plot dialog settings

2011-01-05 Thread Marco Mattila
If you think that the plotting requirements vary from one project to another (the number of needed technical layers maybe?), saving them outside the config system makes sense. Since there can be multiple boards in a project, maybe the SETUP section of a board file is the correct place for this. I

Re: [Kicad-developers] [PATCH] Saving plot dialog settings

2011-01-03 Thread Marco Mattila
The previous patch has a bug. It incorrectly complains about no layers being selected. This patch works better. marco On Sun, Jan 2, 2011 at 11:40 PM, Marco Mattila marco...@gmail.com wrote: Hi, During previous discussions about subtracting masks from silkscreen layers when plotting gerbers

[Kicad-developers] [PATCH] Saving plot dialog settings

2011-01-02 Thread Marco Mattila
Hi, During previous discussions about subtracting masks from silkscreen layers when plotting gerbers, Dick mentioned that saving plot settings is not quite up to date. Currently some plot settings to be saved/loaded are defined in pcbnew_config.cpp. However, that requires that corresponding

[Kicad-developers] [PATCH] Zone clearance to pcb edge etc.

2011-01-01 Thread Marco Mattila
Hi, It seems that currently the clearances between zones and pcb edge segments (and text items and module edge segments on copper layers) are not something one would expect based on zone clearance settings. The reason is that, unlike with, e.g., tracks, the minimum zone thickness is not taken

Re: [Kicad-developers] [PATCH] Option to subtract soldermask from silkscreen in gerber output

2010-12-12 Thread Marco Mattila
Dick, The main point in my reply earlier was just that the visual results are not equivalent. However, I agree with you that using OR is the way to go if it is acceptable that things in gerbview will look a little different than before. At least I'm ok with that. Anyways, I think that the

Re: [Kicad-developers] [PATCH] Option to subtract soldermask from silkscreen in gerber output

2010-12-07 Thread Marco Mattila
I tested the output with gerbview and gerbv. In gerbv everything's ok. Now that I checked again with gerbview the negative layer kind of works. However, since negative layers in gerbview are taken care of by drawing them in background color, the negative stuff will be subtracted from all layers

Re: [Kicad-developers] Editing value field in eeschema/libedit seems to fail.

2010-11-22 Thread Marco Mattila
Ok, but what was the bug/issue that was fixed by introducing m_oldRootName? Before 2559 it was possible to create a copy of a component by changing the value field and clicking save. Replacing a component was done by creating a copy first and then deleting the old one. After introducing

Re: [Kicad-developers] Editing value field in eeschema/libedit seems to fail.

2010-11-21 Thread Marco Mattila
This was changed in revision 2559. The reason was Fix bug that prevented component from being replaced in library when the component root name was changed. I don't quite get the point, though. What exactly was the bug? Value != component name? Is there something that could be done to enable

Re: [Kicad-developers] [PATCH] Draw items in block move in pcbnew

2010-11-11 Thread Marco Mattila
The attached version of the patch adds a checkbox into the block operation dialog. The user can choose whether the items in the block are drawn or not during the operation. That should be more suitable than a compiled-in constant for users with different preferences. Outline-only behavior is also

Re: [Kicad-developers] [PATCH] Draw items in block move in pcbnew

2010-11-01 Thread Marco Mattila
Do you mean useful from an aesthetic or screen refresh point of view? Since selecting flip (in pcbnew) or mirror (in eeschema) after (inadvertently) moving the block flips/mirrors the block in its original position. marco On Mon, Nov 1, 2010 at 6:10 PM, Lorenzo Marcantonio

Re: [Kicad-developers] Footprint reference/value text size patch

2010-10-22 Thread Marco Mattila
, Sep 13, 2010 at 5:22 PM, Wayne Stambaugh stambau...@verizon.net wrote: On 9/10/2010 9:19 AM, Marco Mattila wrote: Hi, Do you have any input regarding this patch proposal? Is there something that should be done differently for this to be considered? Marco, I apologize for not responding sooner

Re: [Kicad-developers] [PATCH] Locked modules locked in block operations

2010-10-17 Thread Marco Mattila
for flip block, though. Marco On Sun, Oct 17, 2010 at 8:46 AM, jean-pierre charras jp.char...@wanadoo.frwrote: Le 17/10/2010 00:05, Marco Mattila a écrit : Hi, I have previously submitted a couple of patches that prevented direct manipulation of locked modules in pcbnew. However, within a block

Re: [Kicad-developers] [PATCH] Locked modules locked in block operations

2010-10-17 Thread Marco Mattila
So the dialog should be added to block flip, too. I'll start working on this. On Sun, Oct 17, 2010 at 1:44 PM, jean-pierre charras jp.char...@wanadoo.frwrote: Le 17/10/2010 12:32, Marco Mattila a écrit : Good point. However, sometimes it might be used also for moving footprints within

[Kicad-developers] [PATCH] Locked modules locked in block operations

2010-10-16 Thread Marco Mattila
Hi, I have previously submitted a couple of patches that prevented direct manipulation of locked modules in pcbnew. However, within a block it remained possible to, e.g., move a locked module. This patch prevents locked modules from being added to the list of selected items in a block operation.

[Kicad-developers] Disable hotkeys for pads in pcbnew (patch)

2010-09-01 Thread Marco Mattila
Hi, Moving of pads using hotkeys in pcbnew was found to be little problematic in earlier discussions. The attached patch changes hotkey behavior so that pressing M, G, or E over a pad moves, drags, or edits the parent footprint (pads can still be moved via the right-click menu). The patch is a

[Kicad-developers] Libedit block copy patch

2010-09-01 Thread Marco Mattila
Hi, There seems to be a small typo in libeditframe.cpp that prevents block copy via the right-click menu. This patch helps. marco === modified file 'eeschema/libeditframe.cpp' --- eeschema/libeditframe.cpp 2010-07-23 14:12:37 + +++ eeschema/libeditframe.cpp 2010-09-01 20:47:27 + @@

Re: [Kicad-developers] Collateral effect with module editor hotkeys

2010-08-30 Thread Marco Mattila
The issue here is that before hotkey moving of footprints, pads, and fotprint text fields in pcbnew was implemented, it was always possible to right click somewhere on the footprint and select move footprint on the menu. Now that there are some hotkeys, one cannot just point at some point on the

[Kicad-developers] Footprint reference/value text size patch

2010-08-29 Thread Marco Mattila
Hi, I've attached a patch that allows reseting footprint reference or value text sizes and widths to the defaults set in the Dimensions-Texts and Drawings dialog. The functions Reset size and Reset all sizes are added into Reference and Value submenus of the right-click context menu (not sure if

Re: [Kicad-developers] Locked module really locked patch

2010-08-29 Thread Marco Mattila
Sorry about the formatting issues (and double posting to you Dick). My emacs c-style should now be correct for Kicad. However, the previous patch didn't quite get fixed to that style yet. I think that this patch has no tabs or extra whitespace. I also removed the superfluous else statements you

[Kicad-developers] Template fields bugfix patch

2010-08-28 Thread Marco Mattila
Hi, Drawing component fields originating from templates crashes eeschema due to a null parent issue. The attached patch fixes that. Regards, Marco === modified file 'eeschema/dialog_edit_component_in_schematic.cpp' --- eeschema/dialog_edit_component_in_schematic.cpp 2010-07-12 14:07:09 +

[Kicad-developers] Label dragging patch

2010-07-15 Thread Marco Mattila
Hi again, I intend to use global labels to name power nets instead of power symbols, and, thus, I made some changes to enable dragging of labels. Most of the code should be pretty straightforward. The changes in dangling_ends.cpp make dangling label detection work for all wire orientations and