Re: [Kicad-developers] [PATCH] Don't reference CMAKE_INSTALL_PREFIX in installation paths

On Sat, Apr 28, 2018 at 09:56:48PM +0200, Simon Richter wrote: > > This is substituted at configuration time, creating an absolute path, which > breaks overriding CMAKE_INSTALL_PREFIX at installation time, breaking the > workflow for installation using GNU stow. > --- > CMakeLists.txt | 10 +-

Re: [Kicad-developers] [PATCH 00/12] Minor cleanups and improvements

m? > > Regards, > Orson > > On 11/02/2017 09:58 PM, Marvin Schmidt wrote: > > Just a set of small code cleanups to fix a bunch of warnings > > and remove dead code. > > Other than that the 'build:' commits avoid/remove/fix the > > installati

Re: [Kicad-developers] [PATCH 0/3] Minor fixes for VECTOR2 and BOX2

On Sun, Nov 05, 2017 at 11:04:48PM +0100, Maciej Suminski wrote: > Hi Marvin, > > Thank you for the patches. I have just pushed them to the master branch. > > Regards, > Orson > > On 10/31/2017 12:17 PM, Marvin Schmidt wrote: > > I was irritated by the usage of

[Kicad-developers] [PATCH 06/12] Remove unused #define

--- eeschema/sch_screen.cpp | 3 --- 1 file changed, 3 deletions(-) diff --git a/eeschema/sch_screen.cpp b/eeschema/sch_screen.cpp index 02f2030d1..50d921b2d 100644 --- a/eeschema/sch_screen.cpp +++ b/eeschema/sch_screen.cpp @@ -66,9 +66,6 @@ static double SchematicZoomList[] = 13.0, 16.0, 2

[Kicad-developers] [PATCH 03/12] build: Remove dead code

--- CMakeLists.txt | 8 1 file changed, 8 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 54d477e22..3a8ee4518 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -693,14 +693,6 @@ if( KICAD_SCRIPTING OR KICAD_SCRIPTING_MODULES ) endif() -if( EXISTS ${CMAKE_SOURCE_DI

[Kicad-developers] [PATCH 02/12] build: Use CMAKE_INSTALL_DATADIR

--- CMakeLists.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 5d01d6577..54d477e22 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -380,9 +380,9 @@ if( NOT APPLE ) CACHE PATH "Location of KiCad user-loaded plugins"

[Kicad-developers] [PATCH 04/12] build: Don't install *.bat scripts on Unix

--- CMakeLists.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/CMakeLists.txt b/CMakeLists.txt index 3a8ee4518..efd02e103 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -774,6 +774,7 @@ if( UNIX ) install( DIRECTORY scripts DESTINATION ${KICAD_DOCS} COMPONENT re

[Kicad-developers] [PATCH 08/12] Remove orphaned code files

--- common/wxunittext.cpp | 142 - include/wxunittext.h | 144 -- 2 files changed, 286 deletions(-) delete mode 100644 common/wxunittext.cpp delete mode 100644 include/wxunittext.h diff --git a/comm

[Kicad-developers] [PATCH 07/12] Remove some dead code

--- eeschema/sch_item_struct.cpp | 7 --- eeschema/sch_item_struct.h | 4 2 files changed, 11 deletions(-) diff --git a/eeschema/sch_item_struct.cpp b/eeschema/sch_item_struct.cpp index 6e4f98c8d..873a8921a 100644 --- a/eeschema/sch_item_struct.cpp +++ b/eeschema/sch_item_struct.cpp @@

[Kicad-developers] [PATCH 10/12] Remove duplicate #include

--- common/class_undoredo_container.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/common/class_undoredo_container.cpp b/common/class_undoredo_container.cpp index ada087480..88eec3001 100644 --- a/common/class_undoredo_container.cpp +++ b/common/class_undoredo_container.cpp @@ -25,8 +25

[Kicad-developers] [PATCH 11/12] Remove some else-after-return's

--- common/class_undoredo_container.cpp | 37 +++-- 1 file changed, 19 insertions(+), 18 deletions(-) diff --git a/common/class_undoredo_container.cpp b/common/class_undoredo_container.cpp index 88eec3001..e3f974eb3 100644 --- a/common/class_undoredo_container.cpp

[Kicad-developers] [PATCH 12/12] Use std::remove_pointer instead of own implementation (NFC)

--- include/core/typeinfo.h | 22 +- 1 file changed, 5 insertions(+), 17 deletions(-) diff --git a/include/core/typeinfo.h b/include/core/typeinfo.h index 34c3324e6..537171348 100644 --- a/include/core/typeinfo.h +++ b/include/core/typeinfo.h @@ -28,19 +28,7 @@ #ifndef SW

[Kicad-developers] [PATCH 09/12] Remove some extra semicolons

--- 3d-viewer/3d_cache/dialogs/3d_cache_dialogs.h | 2 +- 3d-viewer/3d_cache/sg/sg_helpers.cpp| 2 +- 3d-viewer/3d_cache/sg/sg_helpers.h | 2 +- 3d-viewer/3d_cache/sg/sg_node.h | 2 +- 3d-viewer/3d_cache/str_rsort.h | 2 +- 3d-viewer

[Kicad-developers] [PATCH 05/12] Fix a typo

--- gerbview/class_gerbview_layer_widget.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gerbview/class_gerbview_layer_widget.cpp b/gerbview/class_gerbview_layer_widget.cpp index 6e9b8e312..498dac397 100644 --- a/gerbview/class_gerbview_layer_widget.cpp +++ b/gerbview/clas

[Kicad-developers] [PATCH 00/12] Minor cleanups and improvements

UNIX systems - use CMAKE_INSTALL_* consistently to install files in the correct places Marvin Schmidt (12): build: Don't install INSTALL.txt build: Use CMAKE_INSTALL_DATADIR build: Remove dead code build: Don't install *.bat scripts on Unix Fix a typo Remove unused #define

[Kicad-developers] [PATCH 01/12] build: Don't install INSTALL.txt

--- CMakeLists.txt | 4 1 file changed, 4 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 9405416a3..5d01d6577 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -775,10 +775,6 @@ add_custom_target( uninstall # Installation #

[Kicad-developers] [PATCH 2/3] vector2d: Fix traits usage and use std::numeric_limits

--- include/math/vector2d.h | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/include/math/vector2d.h b/include/math/vector2d.h index 8bf2da588..d67f9b72f 100644 --- a/include/math/vector2d.h +++ b/include/math/vector2d.h @@ -29,8 +29,8 @@ #define VECTOR2D_H_ #includ

[Kicad-developers] [PATCH 3/3] box2: Remove wrong use of typename keyword

--- include/math/box2.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/math/box2.h b/include/math/box2.h index 5bf6ddd03..fb6fd9d5c 100644 --- a/include/math/box2.h +++ b/include/math/box2.h @@ -47,7 +47,7 @@ private: public: typedef typename Vec::coord_type

[Kicad-developers] [PATCH 1/3] vector2d: Remove duplicate #include

--- include/math/vector2d.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/math/vector2d.h b/include/math/vector2d.h index abe3734ac..8bf2da588 100644 --- a/include/math/vector2d.h +++ b/include/math/vector2d.h @@ -32,7 +32,6 @@ #include #include #include -#include #include

[Kicad-developers] [PATCH 0/3] Minor fixes for VECTOR2 and BOX2

it got through the traits class The other two patches are just minor fixes. The wrong use of the typename keyword in the box2 class might have been triggering a bug in the MSVC compiler though (not sure about that as I can't test it, just seems possible from workaround I've seen) Marv

[Kicad-developers] How I Learned to Stop Worrying (about whitespace) and Love clang-format

Hi everybody! I've been following the KiCad development for some time and I feel like quite some time is wasted on whitespaces. Be it either when new contributors send in reviews (I find the coding style rather hard to get acustomed to as well, personally) or when fixing them by hand when seeing t

[Kicad-developers] [PATCH] Add missing include in kicad_string.h

Without this include the HAVE_STRTOKR define won't be available to the preprocessor and the strtok_r function will be declared unconditionally and eventually clash with the declaration from the system provided equivalent: ../../include/kicad_string.h:171:71: error: declaration of 'char* strtok_r(

Re: [Kicad-developers] [PATCH 04/12] Avoid C99 style compound statement

On Fri, May 27, 2016 at 04:32:51PM +0200, Simon Richter wrote: > > Support for C99 in C++ programs is a gcc extension. > --- > eeschema/autoplace_fields.cpp | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/eeschema/autoplace_fields.cpp b/eeschema/autoplace_fields.cpp