Hi,
what is the current outlook on the legacy canvas past v5?
Specifically, I have a feature branch that targets v6 because it
certainly won't be in time for v5. Does it make sense to invest effort
here to get it working with the legacy canvas?
Simon
signature.asc
Description: OpenPGP
Hi,
On 30.04.2017 14:47, Russell Oliver wrote:
> Also located at https://github.com/rustyoz/kicad/tree/position-relative
In the long run, constraint based editing would be great, and this is a
good start, I think.
Windows builds are on the way[1].
Simon
[1]
Hi,
On 24.04.2017 14:55, Jan Mrázek wrote:
[patch]
Test build on Windows checked out okay.
Simon
signature.asc
Description: OpenPGP digital signature
___
Mailing list: https://launchpad.net/~kicad-developers
Post to :
Hi,
On 25.04.2017 17:11, Jan Mrázek wrote:
> I am a little confused. What exactly is wrong with the patch? According
> to the IRC discussion a while ago, I think it was with nickoe, the best
> approach is probably to adopt the changes in FindwxWidgets and when
> KiCAD upgrades to a reasonably
Hi,
On 25.04.2017 14:45, Wayne Stambaugh wrote:
> Are you saying this patch will not work as is or are there other steps
> we need to do to get this correct?
Neither. The patch is likely to work, I've scheduled a quick(...) test
for Windows in Jenkins to make sure of that.
I'm mainly passing
Hi,
On 24.04.2017 14:55, Jan Mrázek wrote:
> I have updated my patch for this problem and managed to get it into
> CMake upstream. Since it will be included in CMake 3.9 and I think KiCAD
> is not going to switch to new version of CMake soon, I think it might be
> useful to include this patch
Hi,
On 18.04.2017 14:55, Jon Evans wrote:
> In my opinion, a schematic with multiple sheets is not like a text
> editor with multiple documents. The schematic editor is working on a
> single project, and it should be way more common to apply operations
> (that might want to be undone) to all
Hi,
in my net_ties branch I'm adding a few additional classes that need to
be handled in all appropriate places. A pattern I've seen often in the
code (e.g. in the PAINTER classes) is
void do_something(EDA_ITEM *item)
{
switch(item->Type())
{
case FOO_TYPE: //
---
utils/kicad-ogltest/CMakeLists.txt | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/utils/kicad-ogltest/CMakeLists.txt b/utils/kicad-ogltest/CMakeLists.txt
index 6b6f79f87..b6d71f649 100644
--- a/utils/kicad-ogltest/CMakeLists.txt
+++ b/utils/kicad-ogltest/CMakeLists.txt
Hi,
On 06.04.2017 14:01, Wayne Stambaugh wrote:
> Is there any reason that the polygon library needs to be defined twice
> in the same target in this patch?
Yes, it has a circular dependency with common, and static libraries are
only searched once.
Simon
signature.asc
Description:
---
qa/geometry/CMakeLists.txt | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/qa/geometry/CMakeLists.txt b/qa/geometry/CMakeLists.txt
index 60c857fe6..9615e183b 100644
--- a/qa/geometry/CMakeLists.txt
+++ b/qa/geometry/CMakeLists.txt
@@ -41,10 +41,10 @@
---
qa/geometry/CMakeLists.txt | 2 ++
qa/geometry/test_module.cpp | 2 +-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/qa/geometry/CMakeLists.txt b/qa/geometry/CMakeLists.txt
index 9615e183b..c542d378c 100644
--- a/qa/geometry/CMakeLists.txt
+++ b/qa/geometry/CMakeLists.txt
@@
---
utils/kicad-ogltest/kicad-ogltest.cpp | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/utils/kicad-ogltest/kicad-ogltest.cpp b/utils/kicad-ogltest/kicad-ogltest.cpp
index eb0a8cba7..7c3415f0c 100644
--- a/utils/kicad-ogltest/kicad-ogltest.cpp
+++
---
utils/kicad-ogltest/CMakeLists.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/utils/kicad-ogltest/CMakeLists.txt b/utils/kicad-ogltest/CMakeLists.txt
index 7e662f713..6b6f79f87 100644
--- a/utils/kicad-ogltest/CMakeLists.txt
+++ b/utils/kicad-ogltest/CMakeLists.txt
@@ -2,6 +2,8 @@
---
utils/kicad-ogltest/CMakeLists.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/utils/kicad-ogltest/CMakeLists.txt b/utils/kicad-ogltest/CMakeLists.txt
index 7e662f713..6b6f79f87 100644
--- a/utils/kicad-ogltest/CMakeLists.txt
+++ b/utils/kicad-ogltest/CMakeLists.txt
@@ -2,6 +2,8 @@
Hi,
On 28.03.2017 09:41, Andrey Kuznetsov wrote:
> It would be nice if the ruler could be a manipulable object that can be
> saved, locked, have multiple rulers on screen. It won't be output to
> gerbers, for kicad viewing only.
I wonder if it would make sense to have dimensions in the
There is no good default behaviour for these, so there should not be a
default implementation.
---
include/class_board_item.h | 15 +++
pcbnew/class_board.h | 3 +++
pcbnew/class_netinfo.h | 4
3 files changed, 10 insertions(+), 12 deletions(-)
diff --git
Hi,
On 27.03.2017 01:13, Chris Pavlina wrote:
> Can someone please confirm authoritatively which Boost version is
> installed on the Jenkins boxes? I recently had to "fix" my code to build
> on Boost 1.55 [1], making it rather ugly in the process. Out of
> curiosity I checked our documentation
---
common/base_screen.cpp | 20 --
common/base_struct.cpp | 46
eeschema/class_libentry.h | 8 ---
eeschema/class_netlist_object.cpp | 107
eeschema/class_netlist_object.h
Hi,
I've looked at where EDA_ITEM::Show() is actually used:
- NETLIST_OBJECT::Show() uses it from DumpNetList(), which is called if
DEBUG_NETLIST is defined in addition to DEBUG, probably to debug the
sorting during netlist generation.
- PCB_BASE_FRAME and PCB_EDIT_FRAME also have references
Hi,
On 14.03.2017 16:44, John Beard wrote:
> This is something I've bene toying with for a little while: an
> enhanced overlay and construction method for arcs in Pcbnew.
One thing that people have been asking about is a way to connect arcs
and lines, is it possible to add that in your design
Hi,
On 14.03.2017 17:30, Chris Pavlina wrote:
>> The regex matcher should give you good results for "^R".
> I think people would be opposed to using regexes in the footprint
> filters. I like having them in some places as an option, but they're
> complicated for people who aren't programmers,
Hi,
On 14.03.2017 16:57, Chris Pavlina wrote:
> What if I changed this to require matching at the beginning of the
> string? A filter meant to match anywhere in the string could be written
> "*R_*" instead. This should significantly reduce the number of false
> positive matches.
The regex
On 11.03.2017 03:35, Chris Pavlina wrote:
> Does anyone know why we have "#define VTBL_ENTRY virtual" in kiway.h and
> then use that in several kiway-related places? Would anyone object to
> just using "virtual"?
I'd say go for it.
Simon
signature.asc
Description: OpenPGP digital
Hi,
Am 07.03.2017 um 14:36 schrieb Tomasz Wlostowski:
> The attached patch removes boost::context dependency by introducing a
> single-file libcontext that automatically detects the compiler &
> platform and provides a stable API, contrary to the Boost libs. If you
> have some spare time, please
Hi,
Am 07.03.2017 um 07:07 schrieb Cirilo Bernardo:
> The sole difference with the previous patch is that kicad2step.cpp
> was modified to replace:
> wxIMPLEMENT_APP_CONSOLE( KICAD2MCAD );
> with
> wxIMPLEMENT_APP( KICAD2MCAD );
On Windows proper, this means that stdin/stdout/stderr are
Passing a wxString to std::ifstream::ifstream() is ambiguous, at least on MSVC.
---
tools/io_benchmark/io_benchmark.cpp | 49 ++--
tools/io_benchmark/stdstream_line_reader.cpp | 8 ++---
tools/io_benchmark/stdstream_line_reader.h | 4 ++-
3 files changed, 32
Hi,
On 01.03.2017 18:26, Kevin Cozens wrote:
>> +#include
>> +
> That looks like a typo. I think that should be
No, that is correct.
is a C header that pulls in , for memcpy() and friends.
is a C++ header that defines std::unique_ptr and std::shared_ptr.
Simon
signature.asc
color_swatch.cpp uses std::unique_ptr
---
common/widgets/color_swatch.cpp | 2 ++
1 file changed, 2 insertions(+)
diff --git a/common/widgets/color_swatch.cpp b/common/widgets/color_swatch.cpp
index 745537d4b..354ed5df3 100644
--- a/common/widgets/color_swatch.cpp
+++
Hi,
On 26.02.2017 17:55, Wayne Stambaugh wrote:
> I'm not sure it's even necessary since curl's dependencies would have to
> be satisfied in order to build so I'm not sure it makes sense for the
> KiCad build config to test for and dependency library sub-dependencies.
The library, yes, but we
Hi,
On 24.02.2017 11:29, Simon Wells wrote:
>> The proper fix is to make sure that only a single thread uses CURL. Then
>> we can drop the OpenSSL dependency ourselves, as we only initialize some
>> locking functions.
> i believe the curl-multi interface will also remove this inane requirement
Hi Cirilo,
On 24.02.2017 01:52, Cirilo Bernardo wrote:
> Since I know nothing of the github plugin code and the usage of curl
> within kicad, I thought I'd ask if that block should be qualified by the
> BUILD_GITHUB_PLUGIN option or of there's some mysterious
> reason why it must be there even
If we want to have an override marker on this function, it needs to be
conditional on Mac.
---
common/single_top.cpp | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/common/single_top.cpp b/common/single_top.cpp
index 38ed55f89..c9bd80625 100644
--- a/common/single_top.cpp
---
eeschema/class_netlist_object.h| 2 +-
gerbview/class_gbr_layout.h| 4 ++--
pagelayout_editor/class_pl_editor_layout.h | 4 ++--
pcbnew/class_netclass.h| 2 +-
4 files changed, 6 insertions(+), 6 deletions(-)
diff --git
---
eeschema/class_libentry.cpp | 8
pcbnew/eagle_plugin.cpp | 28
pcbnew/legacy_plugin.cpp| 17 -
3 files changed, 53 deletions(-)
diff --git a/eeschema/class_libentry.cpp b/eeschema/class_libentry.cpp
index 9e7a1b244..b87fb2345
CMake already sets NDEBUG by default for Release builds, no need to duplicate
this.
---
CMakeLists.txt | 3 ---
1 file changed, 3 deletions(-)
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 167fd37c6..5dc9fd77b 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -233,9 +233,6 @@ if(
Using -O3 is default for release builds with gcc/clang anyway, so this
doesn't gain anything, but overwriting the existing flags might remove some
that might be needed.
---
3d-viewer/CMakeLists.txt | 3 ---
1 file changed, 3 deletions(-)
diff --git a/3d-viewer/CMakeLists.txt
Hi Wayne,
On 23.02.2017 17:40, Wayne Stambaugh wrote:
> I'm
> just curious as to what torrents buy us that we don't already provide.
It has partial checksums, so if the 3D models are largely unchanged, the
total download will be smaller.
I'm not convinced it would be useful to many users
Hi,
On 23.02.2017 16:48, Mário Luzeiro wrote:
> Yes I added it, because for 3D we need *speed* :P
It's unnecessary though, as cmake defaults to "-O3 -DNDEBUG". So
overwriting that will likely enable assertion checks.
> What kind of warnings it is causing? O_o
MSVC only knows "-O2" as a
If the compiler doesn't support -Wshadow, the variable is empty, leading to
a broken declaration.
---
pcbnew/CMakeLists.txt | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/pcbnew/CMakeLists.txt b/pcbnew/CMakeLists.txt
index 2c22916f0..4535daa1b 100644
---
Hi,
in 3d-viewer/CMakeLists.txt we have
set( CMAKE_C_FLAGS_RELEASE "-O3" )
set( CMAKE_CXX_FLAGS_RELEASE "-O3" )
Is that intentional?
- it seems to be unused in the Make based builds
- it overwrites any existing flags in these variables
- it causes warnings on MSVC
Simon
Hi,
On 14.02.2017 10:54, Strontium wrote:
> I believe it would be far preferable for these types of components
> simply to define the functions of each pin in a table, and then when
> placing the part, its just an empty box (like a nested sheet). You then
> right click on the part select "Add
On Windows, the debug build of the GLEW library has an attached "d" in the
library name, which the version in the kicad source doesn't know about.
Updating to current FindGLEW.cmake solves the issue.
Tested on msys2, msvc and Linux.
---
CMakeModules/FindGLEW.cmake | 155
Hi,
On Wed, Feb 08, 2017 at 11:04:21PM +1100, Oliver Walters wrote:
> I have amended the patch to only ignore connection of pins that are both
> INVISIBLE and NC (Electrical Type = Not Connected). This will improve the
> safety of the current libraries which do contain many parts with NC pins
>
Hi,
On 04.02.2017 18:25, Javier Serrano wrote:
> I am organizing the EDA devroom dinner this year as usual, and I thought
> we had all the KiCad people. Discussion has happened in the EDA devroom
> list [1]. Sorry, I did not know you were here.
Neither did I, until Thursday. :) I'll be there.
Hi,
On 03.02.2017 13:22, Wayne Stambaugh wrote:
> We should probably put this on the KiCad website in the about section.
> I'm sure there are users who would like to know how the name KiCad came
> to be and now we know the rest of the story.
We could also ask for the mailing list archive to
Hi,
On 31.01.2017 20:13, Chris Pavlina wrote:
> /home/cmp/git/kicad/eeschema/dialogs/dialog_edit_one_field.cpp: In member
> function ‘virtual bool DIALOG_EDIT_ONE_FIELD::TransferDataToWindow()’:
> /home/cmp/git/kicad/eeschema/dialogs/dialog_edit_one_field.cpp:174:42:
> warning: comparison
The common library uses CURL.
---
common/CMakeLists.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/common/CMakeLists.txt b/common/CMakeLists.txt
index e9c7e4338..549a2c86b 100644
--- a/common/CMakeLists.txt
+++ b/common/CMakeLists.txt
@@ -4,6 +4,7 @@ include_directories(
Hi,
this is for the 4.0 branch, and fairly obvious, I think. The master branch
already has this.
Simon
Simon Richter (1):
Add missing include directory
common/CMakeLists.txt | 1 +
1 file changed, 1 insertion(+)
--
2.11.0
___
Mailing list
Hi,
I can trigger an Assertion Failure fairly reliably:
1. Open KiCad
2. Open a PCB in pcbnew
3. Close the KiCad project manager
This leads to
kicad: /home/geier/kicad/common/gal/opengl/opengl_compositor.cpp:133:
virtual void KIGFX::OPENGL_COMPOSITOR::Resize(unsigned int, unsigned
int):
Hi,
I just fixed the MSVC build by using a better FindPixman.cmake that
doesn't make as many assumptions about the system.
There are a few new warnings that popped up:
> fp_lib_table.cpp:182, MSBuild, Priority: Normal
> 'FP_LIB_TABLE::Parse': function assumed not to throw an exception but does
ense at
+# Copyright 2012 Dmitry Baryshnikov
+# Copyright 2017 Simon Richter
#
-# http://www.apache.org/licenses/LICENSE-2.0
+# Distributed under the OSI-approved BSD License (the "License");
+# see accompanying file Copyright.txt for details.
#
-# Unless required by applicab
The newest version is 0.34. 1.0 doesn't exist, this only worked because
there is no actual version test.
---
CMakeLists.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 8d71af2c6..349d69df8 100644
--- a/CMakeLists.txt
+++
Hi jp,
On 06.01.2017 19:43, jp charras wrote:
>>> converting the std::chrono::system_clock::now() to
>>> high_resolution_clock breaks builds on osx, i can't see if there is an
>>> explicit conversion function. is there any reason we aren't just
>>> using
Hi,
On 06.01.2017 03:19, Simon Wells wrote:
> converting the std::chrono::system_clock::now() to
> high_resolution_clock breaks builds on osx, i can't see if there is an
> explicit conversion function. is there any reason we aren't just
> using std::chrono::high_resolution_clock::now()? as
Hi,
this commit breaks the build if Python scripting isn't enabled:
[ 83%] Building CXX object
pcbnew/CMakeFiles/pcbnew_kiface.dir/dialogs/dialog_footprint_wizard_list.cpp.o
/home/geier/kicad/pcbnew/dialogs/dialog_footprint_wizard_list.cpp:36:30:
fatal error: python_scripting.h: Datei oder
---
common/gal/opengl/cached_container.cpp | 15 ++-
common/gal/opengl/gpu_manager.cpp | 10 --
common/gal/opengl/opengl_gal.cpp | 10 --
common/view/view.cpp | 5 ++---
4 files changed, 16 insertions(+), 24 deletions(-)
diff --git
---
include/profile.h | 58 ---
1 file changed, 58 deletions(-)
diff --git a/include/profile.h b/include/profile.h
index ae2840e53..b08303f1e 100644
--- a/include/profile.h
+++ b/include/profile.h
@@ -30,69 +30,11 @@
#ifndef __TPROFILE_H
---
include/profile.h | 27 +++
1 file changed, 19 insertions(+), 8 deletions(-)
diff --git a/include/profile.h b/include/profile.h
index fdfeea1ca..ae2840e53 100644
--- a/include/profile.h
+++ b/include/profile.h
@@ -34,7 +34,10 @@
#include
#include
+#include
---
include/profile.h | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/include/profile.h b/include/profile.h
index d3cb30bd2..fdfeea1ca 100644
--- a/include/profile.h
+++ b/include/profile.h
@@ -93,11 +93,10 @@ static inline void prof_end( prof_counter* aCnt )
class
Hi,
this cleans up the performance counters, using only a single interface, and
switches that implementation to use std::chrono with a high resolution
timer.
Simon
Simon Richter (4):
PROF_COUNTER: initialize in initializer list
Use std::chrono and std::cerr in PROF_COUNTER
Switch
Hi,
> For me it's OK. Ppa for Ubuntu is ready...
Please don't use the PPA for stable releases. Installing packages from
the PPA does not work if the distro packages haven't been purged before,
and vice versa.
This is fine for users on the bleeding edge, but is massively annoying
to support on
Hi,
On Wed, Dec 07, 2016 at 07:21:32AM -0500, Carl Poirier wrote:
> The KIGITHUB variable leads to Github. For using the pretties locally, the
> fp-lib-table.for-pretty has to be used instead, which is the one that's
> included by default in the stable release. Anyway, as I had mentioned in
>
Hi,
On 06.12.2016 09:03, Maciej Sumiński wrote:
> Thank you Simon! Does it mean you have Windows binaries available for
> testing?
Yes:
http://downloads.kicad-pcb.org/windows/testing/patched/kicad-patched-396-54c5f6b-x86_64.exe
Simon
signature.asc
Description: OpenPGP digital signature
Hi,
On 05.12.2016 17:52, Maciej Sumiński wrote:
> Since some time we have been working on eeschema library editor with the
> goal of simplifying the user interface. Now it is available for
> beta testing [1] and I would appreciate some feedback.
Building for Windows at
Hi,
On Mon, Dec 05, 2016 at 12:51:38PM +0100, Jean-Samuel Reynaud wrote:
> Ok I'm ready on my side (Ubuntu PPA). Do you want I push the packages or
> I wait your announcement ?
It would also be really cool if these packages could be integrated with the
regular Debian packages, so users can get
Hi,
On 04.12.2016 13:33, jp charras wrote:
>> when doing other stuff I ran into one of a gazillion cases that can make
>> StrNumCmp starting in
>> common/string.cpp:214 crash. There are quite a few unchecked iterator
>> dereferences, the aLength
>> parameter is not correctly taken into
---
common/CMakeLists.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/common/CMakeLists.txt b/common/CMakeLists.txt
index 79b5dbc..78ef209 100644
--- a/common/CMakeLists.txt
+++ b/common/CMakeLists.txt
@@ -484,6 +484,7 @@ add_custom_target(
)
add_dependencies( common
Hi jp,
On 13.10.2016 12:42, jp charras wrote:
> Many times, it was said these files must be *never* modified by hand.
> You perfectly know that, and why it was said.
> So, why are doing that?
These patches are not meant to go into the mainline project, just to
demonstrate how I went looking
Hi Wayne,
On 12.10.2016 20:22, Wayne Stambaugh wrote:
> What version of wxFB are you using to generate the changes?
That is the current version from github, basically -- Debian packages
for that version live at http://www.simonrichter.eu/debian/ .
The build dates I remove with an extra sed
---
pcbnew/dialogs/dialog_freeroute_exchange.cpp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/pcbnew/dialogs/dialog_freeroute_exchange.cpp b/pcbnew/dialogs/dialog_freeroute_exchange.cpp
index f84bd7e..6af87e2 100644
--- a/pcbnew/dialogs/dialog_freeroute_exchange.cpp
+++
---
3d-viewer/3d_viewer/dialogs/dialog_3D_view_option_base.cpp | 2 --
3d-viewer/3d_viewer/dialogs/dialog_3D_view_option_base.fbp | 2 +-
3d-viewer/3d_viewer/dialogs/dialog_3D_view_option_base.h | 1 -
bitmap2component/bitmap2cmp_gui_base.cpp | 4
---
eeschema/dialogs/dialog_lib_edit_text.cpp | 7 +++
eeschema/dialogs/dialog_lib_edit_text.h | 1 +
2 files changed, 8 insertions(+)
diff --git a/eeschema/dialogs/dialog_lib_edit_text.cpp b/eeschema/dialogs/dialog_lib_edit_text.cpp
index a1c7cee..b9cec6b 100644
---
---
common/class_marker_base.cpp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/common/class_marker_base.cpp b/common/class_marker_base.cpp
index 91e05a2..da1808e 100644
--- a/common/class_marker_base.cpp
+++ b/common/class_marker_base.cpp
@@ -39,7 +39,7 @@
#include
---
eeschema/dialogs/dialog_lib_edit_text.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/eeschema/dialogs/dialog_lib_edit_text.h b/eeschema/dialogs/dialog_lib_edit_text.h
index b58a165..547f3fd 100644
--- a/eeschema/dialogs/dialog_lib_edit_text.h
+++
---
eeschema/dialogs/dialog_rescue_each.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/eeschema/dialogs/dialog_rescue_each.cpp b/eeschema/dialogs/dialog_rescue_each.cpp
index c2065fd..5566240 100644
--- a/eeschema/dialogs/dialog_rescue_each.cpp
+++
---
pcbnew/dialogs/dialog_graphic_item_properties_for_Modedit.cpp | 1 +
1 file changed, 1 insertion(+)
diff --git a/pcbnew/dialogs/dialog_graphic_item_properties_for_Modedit.cpp b/pcbnew/dialogs/dialog_graphic_item_properties_for_Modedit.cpp
index da5a89d..062046d 100644
---
---
pcbnew/sel_layer.cpp | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/pcbnew/sel_layer.cpp b/pcbnew/sel_layer.cpp
index 44fad09..e968632 100644
--- a/pcbnew/sel_layer.cpp
+++ b/pcbnew/sel_layer.cpp
@@ -97,6 +97,8 @@ private:
void OnLeftGridCellClick( wxGridEvent&
---
eeschema/pinedit.cpp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/eeschema/pinedit.cpp b/eeschema/pinedit.cpp
index 30b4d99..4b328c7 100644
--- a/eeschema/pinedit.cpp
+++ b/eeschema/pinedit.cpp
@@ -42,7 +42,7 @@
#include
#include
-#include
This brings the remaining stragglers to the current wxFB version.
No semantic changes.
---
common/dialogs/dialog_image_editor.fbp | 104 +++--
common/dialogs/dialog_image_editor_base.cpp| 5 +
common/dialogs/dialog_image_editor_base.h | 2 +-
Bumping the version number makes patches more difficult to read, so don't
write a version number into the file.
---
3d-viewer/3d_cache/dialogs/dlg_3d_pathconfig_base.cpp | 2 +-
3d-viewer/3d_cache/dialogs/dlg_3d_pathconfig_base.h | 2 +-
xed "CHECK" are definitely just hints at a class of
problems we might to look for further.
Simon
Simon Richter (14):
wxFormBuilder: convert empty strings
wxFormBuilder: update older schema files
Remove version number from wxFB output
wxFormBuilder: regenerate all dialogs
wxFormBu
The exception objects caught are either not referenced at all, or only in
debug builds. This avoids the warnings for the unused variables.
---
eeschema/class_libentry.cpp| 2 +-
eeschema/class_library.cpp | 4 ++--
eeschema/cross-probing.cpp | 2 +-
std::iota is defined in
---
3d-viewer/3d_rendering/3d_render_raytracing/PerlinNoise.cpp | 1 +
1 file changed, 1 insertion(+)
diff --git a/3d-viewer/3d_rendering/3d_render_raytracing/PerlinNoise.cpp b/3d-viewer/3d_rendering/3d_render_raytracing/PerlinNoise.cpp
index 7513c89..daf4fd3 100644
---
Hi,
On 28.09.2016 17:57, Wayne Stambaugh wrote:
> I didn't test what the compiler generated but I suspected that was the
> case from warning message. If that's the case then I will apply the
> patch but it does mask the underlying issue which could fail spectacularly.
That is what happens:
Triangle::NeighborAcross returns a reference, which must refer to a valid
object whose address cannot be 0. Thus, this test is nonsensical.
---
polygon/poly2tri/sweep/sweep.cc | 16
1 file changed, 16 deletions(-)
diff --git a/polygon/poly2tri/sweep/sweep.cc
The actual definition uses "class", so the forward declarations should do
so, too.
---
include/class_title_block.h | 2 +-
include/wxPcbStruct.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/class_title_block.h b/include/class_title_block.h
index
---
pcbnew/class_board_connected_item.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pcbnew/class_board_connected_item.cpp b/pcbnew/class_board_connected_item.cpp
index b7162e7..b02a5c2 100644
--- a/pcbnew/class_board_connected_item.cpp
+++
This constant should be given as wchar_t const * in UNICODE builds on
Windows, so use the _T() macro.
---
common/dialog_about/aboutinfo.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/common/dialog_about/aboutinfo.h b/common/dialog_about/aboutinfo.h
index
The DRC also runs per-segment tests, not just segment-segment, so the last
segment needs to be tested as well, with an empty list of segments to test
against.
---
pcbnew/drc.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pcbnew/drc.cpp b/pcbnew/drc.cpp
index
This test is only run when the via size itself is acceptable, to avoid
bigger changes to the codebase.
---
pcbnew/class_drc_item.cpp | 4
pcbnew/drc_clearance_test_functions.cpp | 12
pcbnew/drc_stuff.h | 26 ++
3
---
pcbnew/dialogs/dialog_track_via_properties.cpp | 19 +--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/pcbnew/dialogs/dialog_track_via_properties.cpp b/pcbnew/dialogs/dialog_track_via_properties.cpp
index 32297c9..8bd3918 100644
---
This also reverses the substitution logic if strcasecmp is missing.
---
CMakeModules/config.h.cmake| 8
common/class_bitmap_base.cpp | 2 +-
eeschema/sch_legacy_plugin.cpp | 8
gerbview/excellon_read_drill_file.cpp | 4 ++--
This also reverses the substitution logic if strcasecmp is missing.
---
CMakeModules/config.h.cmake| 8
common/class_bitmap_base.cpp | 2 +-
eeschema/sch_legacy_plugin.cpp | 8
pcb_calculator/datafile_read_write.cpp | 4 ++--
pcbnew/specctra.cpp
This is also defined in , and likely to be a compiler intrinsic.
---
common/widgets/mathplot.cpp | 6 --
1 file changed, 6 deletions(-)
diff --git a/common/widgets/mathplot.cpp b/common/widgets/mathplot.cpp
index 3a1896b..f9de3ae 100644
--- a/common/widgets/mathplot.cpp
+++
Hi,
On 25.07.2016 17:12, Nick Østergaard wrote:
> Using pads we have no content control, but it is very easy to
> brainstorm stuff.
That would be fine if we can at some point finalize a proposal and
archive it.
> Using hugo, it will be done via github such that
> pull request can be made from
Hi,
one of the outcomes at CERN was that we want to use the Blueprints
system in Launchpad more, and get consensus on major developments before
they are started.
For this, it would be great if there was a wiki, but I'm not sure who
would or should host it. The alternative would be to develop the
Hi Mário,
> I've updated my branch with latest changes and clean the conflicts,
> As I am not an expert, I am not sure how can I revert the old generated
> bitmaps,
> would you mind to make a new branch for me?
With bzr, that is difficult.
> I don't mind (and I prefer) that my branch history
Hi,
On 18.07.2016 21:18, Simon Richter wrote:
> If we don't care about the branch history, I've attached a diff between
> the current product branch tip and Mario's branch (fixing one conflict
> in a comment and reverting the bitmaps).
It seems the list dropped the attachment.
Lin
Hi,
On 18.07.2016 19:54, Wayne Stambaugh wrote:
> I could not merge your branch into the product branch. Here is the
> merge error message:
Rebasing that branch is going to be difficult because of all the
backmerges from mainline.
If we don't care about the branch history, I've attached a
401 - 500 of 898 matches
Mail list logo
