Re: [Kicad-developers] [PATCH 1 / 2] Add check to use std::optional

2018-07-19 Thread Thomas Figueroa
Ah, you’re totally right. That escaped my mind (hard to track bug w.r.t. std vs boost). I wasn’t sure how things like that were handled (std vs boost variant also comes to mind). From: Seth Hillbrand Sent: Thursday, July 19, 2018 3:28:43 PM To: Thomas Figueroa

Re: [Kicad-developers] [PATCH 2 / 2] Remove deprecated binary/unary function usages

2018-07-19 Thread Thomas Figueroa
deprecated_functionality.patch Description: deprecated_functionality.patch ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help :

[Kicad-developers] [PATCH 1 / 2] Add check to use std::optional

2018-07-19 Thread Thomas Figueroa
Hello everyone, my name is Thomas. I’ve posted a few times on here to submit some feedback, but now I have finally mustered the courage to submit stuff for development. This first pair of patches is really just to get a feel for things and get feedback on any issues with my process or potential p

Re: [Kicad-developers] Some speed up patches

2018-05-18 Thread Thomas Figueroa
Hey Seth, I had an issue where the zone wouldn’t refill at all after modification, leaving a zone that was visible in outline but not being connected to or filled in any way. I’ll try to replicate it tonight, as I’ve since removed the patches, and give a more detailed overview of what I’ve foun

[Kicad-developers] Build failure w.r.t. wxDateTime

2018-03-29 Thread Thomas Figueroa
I recently started getting a "Call of overloaded 'wxDateTime(timestamp_t&)' is ambiguous" compilation failure in class_module.cpp line 573. I modified it to static_cast m_LastEditTime, but I'm not sure that is what is intended here. This occurs both on MSVC and MSYS2 builds. (MSYS2 build here: ht

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

2018-02-08 Thread Thomas Figueroa
it correctly with the same error outputted. -Thomas From: Seth Hillbrand Sent: Thursday, February 08, 2018 10:49 AM To: Thomas Figueroa Cc: kicad-developers@lists.launchpad.net Subject: Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition Hi Thomas- I will add this library to the

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

2018-02-08 Thread Thomas Figueroa
ith a clean cmake. -Seth 2018-02-02 12:47 GMT-08:00 Thomas Figueroa mailto:tom_figue...@hotmail.com>>: Hey Seth, I was able to successfully use OpenCascade 7.1 and export using kicad2step! Now to find out why… -Thomas From: Seth Hillbrand<mailto:seth.hillbr...@gmail.com> Sent: Frid

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

2018-02-02 Thread Thomas Figueroa
Hey Seth, I was able to successfully use OpenCascade 7.1 and export using kicad2step! Now to find out why… -Thomas From: Seth Hillbrand<mailto:seth.hillbr...@gmail.com> Sent: Friday, February 2, 2018 11:10 AM To: Thomas Figueroa<mailto:tom_figue...@hotmail.com> Cc: kica

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

2018-02-01 Thread Thomas Figueroa
message is probably not relevant. -Thomas From: Seth Hillbrand<mailto:seth.hillbr...@gmail.com> Sent: Thursday, February 1, 2018 12:15 PM To: Thomas Figueroa<mailto:tom_figue...@hotmail.com> Cc: kicad-developers@lists.launchpad.net<mailto:kicad-developers@lists.launchpad.n

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

2018-01-31 Thread Thomas Figueroa
Hello Seth, I’ve had the opportunity to test this on Windows (MSVC, but I’ve had the same issue with MSYS2). STEP models work great in the 3D viewer, and in the footprint module editor, just as in OCE. Unfortunately, I cannot get the STEP export to work. I’ve had a run at using OpenCascade befo