Re: [Kicad-developers] , and the format checker

2020-01-21 Thread Seth Hillbrand
Place an empty line between "#include " and the rest of the includes to keep it in order. The nice thing about alphabetic is that you can find/remove/prevent duplicates. You can apply this at the same time as the storage location grouping, again with using spaces to keep from re-arranging acr

Re: [Kicad-developers] , and the format checker

2020-01-21 Thread Wayne Stambaugh
I'm thinking "config.h" needs to be included before any of the kicad header files. I'm not terribly thrilled about alphabetizing the include files per clang-format and we certainly shouldn't be using it in this case. I always grouped them according to where they are defined even though it's not s

[Kicad-developers] , and the format checker

2020-01-21 Thread Simon Richter
Hi, we have a build failure on MSVC because ngspice.cpp no longer includes . This file should really be included first by any cpp file, because it uses macros to work around compiler differences. The format checker rightly suggests that, as it is a <> include from the local project, it should go