Re: [Kicad-developers] [FEATURE] Partial selection in pcbnew

Looks like module text fields should be culled from the selection in ::SanitizeSelection if the parent module is also selected. On 11 May 2017 04:15, "Joakim Asplund" wrote: > On Sat, May 6, 2017 at 9:21 AM, Oliver Walters < > oliver.henry.walt...@gmail.com> wrote: >> >> a)

Re: [Kicad-developers] [FEATURE] Partial selection in pcbnew

On Sat, May 6, 2017 at 9:21 AM, Oliver Walters < oliver.henry.walt...@gmail.com> wrote: > > a) PCBNEW > > Selecting part of a MODULE (right to left) will select both the entire > module and also any parts of the module that you touched (lines, pads, > etc). Then, when you move the module, the

Re: [Kicad-developers] [FEATURE] Partial selection in pcbnew

JP, Sorry, the code for ::ClosestPointTo "used to" have a variable called near. I had since removed it. Never mind :) On Wed, May 10, 2017 at 11:47 PM, jp charras wrote: > Le 10/05/2017 à 15:29, Oliver Walters a écrit : > > JP, > > > > I think that the code "wxPoint

Re: [Kicad-developers] [FEATURE] Partial selection in pcbnew

Le 10/05/2017 à 15:29, Oliver Walters a écrit : > JP, > > I think that the code "wxPoint near" should also be changed to "wxPoint > nearpt" ('near' also seems > to be a somewhat-reserved keyword) > Sure, "far" and "near" must be avoided on Windows, they look like they are still reserved

Re: [Kicad-developers] [FEATURE] Partial selection in pcbnew

Brian, Welcome back! It's good to hear from you after such a long absence. Cheers, Wayne On 5/10/2017 6:18 AM, Brian Sidebotham wrote: > I've been away from the coal face for so long. I've just been catching > up with the list and can't wait to compile the latest! > > Good work to all who've

Re: [Kicad-developers] [FEATURE] Partial selection in pcbnew

Le 10/05/2017 à 14:56, Wayne Stambaugh a écrit : > Windows builds on mingw using gcc 6.3.0 are broken. Here is the > compiler error: > > C:/msys64/home/wstambaugh/src/kicad-trunk/common/base_struct.cpp: In > member function 'bool EDA_RECT::IntersectsCircleEdge(const wxPoint&, > int, int) const':

Re: [Kicad-developers] [FEATURE] Partial selection in pcbnew

JP, I think that the code "wxPoint near" should also be changed to "wxPoint nearpt" ('near' also seems to be a somewhat-reserved keyword) On Wed, May 10, 2017 at 11:23 PM, Oliver Walters < oliver.henry.walt...@gmail.com> wrote: > Looks like JP has already fixed this :) > > On Wed, May 10, 2017

Re: [Kicad-developers] [FEATURE] Partial selection in pcbnew

Looks like JP has already fixed this :) On Wed, May 10, 2017 at 10:56 PM, Wayne Stambaugh wrote: > Windows builds on mingw using gcc 6.3.0 are broken. Here is the > compiler error: > > C:/msys64/home/wstambaugh/src/kicad-trunk/common/base_struct.cpp: In > member function

Re: [Kicad-developers] [FEATURE] Partial selection in pcbnew

Windows builds on mingw using gcc 6.3.0 are broken. Here is the compiler error: C:/msys64/home/wstambaugh/src/kicad-trunk/common/base_struct.cpp: In member function 'bool EDA_RECT::IntersectsCircleEdge(const wxPoint&, int, int) const':

Re: [Kicad-developers] [FEATURE] Partial selection in pcbnew

I've been away from the coal face for so long. I've just been catching up with the list and can't wait to compile the latest! Good work to all who've been doing some amazing work recently! Hopefully I'll be able to start contributing again soon. :) Brian. On 10 May 2017 at 10:41, Maciej

Re: [Kicad-developers] [FEATURE] Partial selection in pcbnew

Hi Oliver, Thank you very much for your effort, I have just pushed your patches to the master branch. Regards, Orson On 05/09/2017 09:32 AM, Oliver Walters wrote: > Two more patches for this set (attached) > > 0017 - Slight fix for arc segment hit test (line width was not accounted > for) >

Re: [Kicad-developers] [FEATURE] Partial selection in pcbnew

On 5/9/2017 5:49 AM, Maciej Sumiński wrote: > Hi Oliver, > > Unfortunately, as you have noticed - there is no way to draw dashed > lines in GAL at the moment. > > I really like the new way of the selection mode indication. I vote for > merging the patch. If there are no other objections, I will

Re: [Kicad-developers] [FEATURE] Partial selection in pcbnew

Hi Oliver, Unfortunately, as you have noticed - there is no way to draw dashed lines in GAL at the moment. I really like the new way of the selection mode indication. I vote for merging the patch. If there are no other objections, I will do it. Regards, Orson On 05/09/2017 09:32 AM, Oliver

Re: [Kicad-developers] [FEATURE] Partial selection in pcbnew

In the improved selection tool Ctrl switch to subtractive selection mode. Regards, Orson On 05/09/2017 07:22 AM, Andrey Kuznetsov wrote: > What's CTRL taken by? > I thought CTRL would be used to toggle grid snapping? > > On Mon, May 8, 2017 at 3:39 PM, José Ignacio

Re: [Kicad-developers] [FEATURE] Partial selection in pcbnew

Two more patches for this set (attached) 0017 - Slight fix for arc segment hit test (line width was not accounted for) 0018 - SELECTION_AREA color now indicates selection mode as discussed above: a) Normal selection = BLUE b) Addition selection = GREEN (Shift modifier) c) Subtraction selection =

Re: [Kicad-developers] [FEATURE] Partial selection in pcbnew

What's CTRL taken by? I thought CTRL would be used to toggle grid snapping? On Mon, May 8, 2017 at 3:39 PM, José Ignacio wrote: > Or switching between object and grid snap :) > > On Mon, May 8, 2017 at 5:34 PM, Wayne Stambaugh > wrote: > >> I tend

Re: [Kicad-developers] [FEATURE] Partial selection in pcbnew

Is there a way do draw a zoom-independent dashed line in GAL? I have an updated idea on selection box rendering that I think would be better. 1. Blue interior shows normal selection 2. Green interior shows additive selection 3. Red interior shows subtractive selection 4. Solid border shows

Re: [Kicad-developers] [FEATURE] Partial selection in pcbnew

Or switching between object and grid snap :) On Mon, May 8, 2017 at 5:34 PM, Wayne Stambaugh wrote: > I tend to lean toward Oliver's approach. Most CAD tools I've used have > this type of includes vs intersects selection paradigm. I don't see the > need to tie up the

Re: [Kicad-developers] [FEATURE] Partial selection in pcbnew

I tend to lean toward Oliver's approach. Most CAD tools I've used have this type of includes vs intersects selection paradigm. I don't see the need to tie up the modifier key if we don't have to. I would prefer that we keep a modifier key open for something like orthogonal move. On 5/8/2017

Re: [Kicad-developers] [FEATURE] Partial selection in pcbnew

I was approaching this from having used mechanical CAD tools where the direction of selection is the standard approach. Whatever function is chosen, it will still be required that the users adjust to the new style, manuals updated, etc. Is assigning what is essentially the last remaining modifier

Re: [Kicad-developers] [FEATURE] Partial selection in pcbnew

2017-05-08 14:59 GMT+02:00 Maciej Sumiński : > Hi Oliver, > > I took your set of patches for a test drive. I am glad that you thought > about the subtractive mode in the selection tool, it really fits there. > Regarding different selection modes - I like the idea, but I

Re: [Kicad-developers] [FEATURE] Partial selection in pcbnew

Hi Oliver, I took your set of patches for a test drive. I am glad that you thought about the subtractive mode in the selection tool, it really fits there. Regarding different selection modes - I like the idea, but I think the two modes should be more distinct, changing the selection direction

Re: [Kicad-developers] [FEATURE] Partial selection in pcbnew

Maciej, That was it! Thanks for the hint. #0016 attached, which fixes both issues: a) No more double-selection of module and module-items (pads / lines / etc) in PCBNEW b) Disable selection of entire module in MODEDIT As far as I can tell this patchset is now working very well. Regards,

Re: [Kicad-developers] [FEATURE] Partial selection in pcbnew

Maciej, Thanks, I'll look into that. If you have a chance to look over what I've done, I'd appreciate that :) On Sat, May 6, 2017 at 10:17 PM, Maciej Suminski wrote: > Hi Oliver, > > I have not tested the patches yet, but my gut feeling says that you miss > calling

Re: [Kicad-developers] [FEATURE] Partial selection in pcbnew

Hi Oliver, I have not tested the patches yet, but my gut feeling says that you miss calling SELECTION_TOOL::selectable() to filter out redundant items. Regards, Orson On 05/06/2017 09:21 AM, Oliver Walters wrote: > Three further patch files attached: > > - Different color select box based on

Re: [Kicad-developers] [FEATURE] Partial selection in pcbnew

Three further patch files attached: - Different color select box based on direction - Fixed HitTest for EDA_TEXT - Control modifier unselects anything in rectangle. The major piece of feedback I need right now is how to perfect the behaviour of the tool in PCBNEW and MODEDIT: a) PCBNEW

Re: [Kicad-developers] [FEATURE] Partial selection in pcbnew

Currently most (all?) of the HitTest code uses intersection tests defined for EDA_RECT (which is already a large duplication of code). Should I refactor all of the ones I have touched to use the common/geometry routines? On Fri, May 5, 2017 at 2:33 PM, Oliver Walters <

Re: [Kicad-developers] [FEATURE] Partial selection in pcbnew

Tomasz, I would be happy to put my new code in a more generic location. I was not aware of common/geometry and simply fixed the ::HitTest() functions that were already present for each shape. I am a little confused by the numerous duplication of the "Rectangle" class (SHAPE_RECT, EDA_RECT,

Re: [Kicad-developers] [FEATURE] Partial selection in pcbnew

On 02.05.2017 09:25, Oliver Walters wrote: > I have attached a patch-set that implements "partial selection" of > objects when the selection box is dragged right-to-left. > > L -> R = Objects must be completely enclosed to be selected > R -> L = Objects that intersect the selection rectangle will

Re: [Kicad-developers] [FEATURE] Partial selection in pcbnew

Actually I'd prefer there to be only 1 selector tool, every program that I've used that made the distinction of 2 mouse pointers with slightly different functionality of selection has made it HELL to use. The act of switching between the two cursors is a PITA, whereas a silent selector switch

Re: [Kicad-developers] [FEATURE] Partial selection in pcbnew

the way autocad did it since about when computer mice started coming out for computers was to use a continuous border for the rectangle when doing a "window" select (that is, all objects must be completely enclosed to be part of the selection), when dragging the other way the outline is dashed for

Re: [Kicad-developers] [FEATURE] Partial selection in pcbnew

On 5/4/2017 10:53 AM, Marco Ciampa wrote: > On Thu, May 04, 2017 at 02:36:06PM +0200, Kristoffer Ödmark wrote: >> Personally I would like the box select to update selections online while >> dragging, this would be very informative. I also think that maybe this >> functionality would be better with

Re: [Kicad-developers] [FEATURE] Partial selection in pcbnew

On Thu, May 04, 2017 at 02:36:06PM +0200, Kristoffer Ödmark wrote: > Personally I would like the box select to update selections online while > dragging, this would be very informative. I also think that maybe this > functionality would be better with a modifier button now that I think about > it,

Re: [Kicad-developers] [FEATURE] Partial selection in pcbnew

The "drag one way to do selection of completely enclosed objects, drag another way to select any objects that touch the selection area" is definitely a common pattern in other programs. I have seen it in various graphics editing and CAD tools. re. Kristoffer's point, I think it would be cool to

Re: [Kicad-developers] [FEATURE] Partial selection in pcbnew

Personally I would like the box select to update selections online while dragging, this would be very informative. I also think that maybe this functionality would be better with a modifier button now that I think about it, since sometimes I cannot starta a drag move in one corner due to a

Re: [Kicad-developers] [FEATURE] Partial selection in pcbnew

SketchUp implements this behaviour as well (https://help.sketchup.com/it/article/385). I'm not sure but it might be a common pattern in other programs as well. Maybe a helpful tooltip-text on the selection tool would be enough? //Konrad On Thu, May 4, 2017 at 1:39 PM, Kristoffer Ödmark

Re: [Kicad-developers] [FEATURE] Partial selection in pcbnew

Hello! I like the functionality a lot! Selection is probably the one thing that is used most of all functions in kicad, so I clearly like that it can be done in multiple ways! I do however wonder how one would find and discover this functionality? - Kristoffer On 05/02/2017 09:25 AM,

Re: [Kicad-developers] [FEATURE] Partial selection in pcbnew

Yay! On Tue, May 2, 2017 at 2:25 AM, Oliver Walters < oliver.henry.walt...@gmail.com> wrote: > I have attached a patch-set that implements "partial selection" of objects > when the selection box is dragged right-to-left. > > L -> R = Objects must be completely enclosed to be selected > R -> L =

[Kicad-developers] [FEATURE] Partial selection in pcbnew

I have attached a patch-set that implements "partial selection" of objects when the selection box is dragged right-to-left. L -> R = Objects must be completely enclosed to be selected R -> L = Objects that intersect the selection rectangle will be selected. To achieve this I had to fix a lot of