Re: [Kicad-developers] [PATCH/QUESTION] Fix -Wshadow warnings in sch_sheet_path.cpp

2018-06-28 Thread Wayne Stambaugh
John, I went ahead and merged your patch even though there seems to be not logical reason for the shadow variable warning. There is not much risk in renaming a few variables to keep the compiler from complaining. Thank you for your contribution to KiCad. Cheers, Wayne On 6/28/2018 9:44 AM,

[Kicad-developers] [PATCH/QUESTION] Fix -Wshadow warnings in sch_sheet_path.cpp

2018-06-28 Thread John Beard
Hi, Simple patch to fix a trio of -Wshadow warnings in SCH_SHEET_PATH. Apparently, these shadow declarations from the STL vector header: /home/john/src/kicad/eeschema/sch_sheet_path.cpp: In member function ‘void SCH_SHEET_PATH::GetComponents(SCH_REFERENCE_LIST&, bool, bool)’: