Re: [Kicad-developers] [PATCH]/Question TITLE_BLOCK tests

2018-10-13 Thread John Beard
Hi Wayne, I understand the problems with linking when units are involved. This particular test executable defines GERBVIEW to satisfy the need to have a valid #define set in convert_to_biu.h. It doesn't actually use any unit code directly. TITLE_BLOCK is just a few strings in a class, but somehow

Re: [Kicad-developers] [PATCH]/Question TITLE_BLOCK tests

2018-10-12 Thread Wayne Stambaugh
Hey John, Any code that has to be built multiple times to get the correct base units scalar will most likely fail linking unless you only care about testing a specific unit scalar such as PCBNEW or EESCHEMA in which case you would need to include the appropriate libraries. You cannot make any

Re: [Kicad-developers] [PATCH]/Question TITLE_BLOCK tests

2018-10-09 Thread John Beard
Hi Wayne, No problems, I get it! It's not needed for the fuzzing stuff, it's actually a pre-cursor for a patch set to do with the dialog_page_settings dialog, but that is now probably on hold for a bit due to being unable to now include "class_drawpanel.h" from any common lib cpp. However, it's

Re: [Kicad-developers] [PATCH]/Question TITLE_BLOCK tests

2018-10-09 Thread Wayne Stambaugh
Hey John, I would like to help you out with this but I'm slammed at work and I'm not going to be able to help out. Is this a patch a prerequisite for your fuzzing patch? Cheers, Wayne On 10/8/2018 1:11 PM, John Beard wrote: > Hi Wayne, > > I have no ideas why that would be, but the QA stuff

Re: [Kicad-developers] [PATCH]/Question TITLE_BLOCK tests

2018-10-08 Thread John Beard
Hi Wayne, I have no ideas why that would be, but the QA stuff does have a funny way of exposing strange link behaviours. In this case, we have: target_link_libraries( qa_common common polygon bitmaps ${Boost_UNIT_TEST_FRAMEWORK_LIBRARY} ${wxWidgets_LIBRARIES} # doesn't this

Re: [Kicad-developers] [PATCH]/Question TITLE_BLOCK tests

2018-10-08 Thread Wayne Stambaugh
Hi John, I am getting the following build error on windows with this patch: C:/msys64/mingw32/bin/../lib/gcc/i686-w64-mingw32/7.3.0/../../../../i686-w64-mingw32/bin/ld.exe: ../../common/libgal.a(color4d.cpp.obj):color4d.cpp:(.text+0x1c9): undefined reference to `wxColourBase::FromString(wxString

Re: [Kicad-developers] [PATCH]/Question TITLE_BLOCK tests

2018-10-06 Thread Wayne Stambaugh
On 10/06/2018 03:48 PM, John Beard wrote: > Hi Wayne, > > On Sat, Oct 6, 2018 at 5:29 PM Wayne Stambaugh wrote: >> No problem. I will test your patch once you post it. > > Patch attached. Indeed, it was a missing include in the header that > probably worked until now due to serendipitous

Re: [Kicad-developers] [PATCH]/Question TITLE_BLOCK tests

2018-10-06 Thread John Beard
Hi Wayne, On Sat, Oct 6, 2018 at 5:29 PM Wayne Stambaugh wrote: > No problem. I will test your patch once you post it. Patch attached. Indeed, it was a missing include in the header that probably worked until now due to serendipitous include ordering in the existing CPPs. This actually

Re: [Kicad-developers] [PATCH]/Question TITLE_BLOCK tests

2018-10-06 Thread Wayne Stambaugh
John, I'm getting the following build errors. [ 84%] Building CXX object qa/common/CMakeFiles/qa_common.dir/test_utf8.cpp.o In file included from /home/wayne/src/kicad-trunk/qa/common/test_title_block.cpp:27: /home/wayne/src/kicad-trunk/include/title_block.h:143:5: error: ‘wxArrayString’ does

[Kicad-developers] [PATCH]/Question TITLE_BLOCK tests

2018-10-05 Thread John Beard
Hi, Here's a patch that adds some really basic tests of TITLE_BLOCK (hopefully leading onto some more interesting changes to do with avoiding the triple-compilation of the page settings dialog). However, it did need some finagling to get it working, and I'd like to ask about why some of it might