Re: [Kicad-developers] [PATCH] Adapt CMake 3.0 compatibility code for C++14

2019-07-18 Thread Seth Hillbrand
On 2019-07-17 13:53, Simon Richter wrote: Hi, On Wed, Jul 17, 2019 at 01:24:26PM -0400, Seth Hillbrand wrote: Any reason to be using the gnu++14 extensions? I thought we were trying to stay with the vanilla c++14. I went for consistency. This code is pretty much unused anyway, since it

Re: [Kicad-developers] [PATCH] Adapt CMake 3.0 compatibility code for C++14

2019-07-17 Thread Simon Richter
Hi, On Wed, Jul 17, 2019 at 01:24:26PM -0400, Seth Hillbrand wrote: > Any reason to be using the gnu++14 extensions? I thought we were > trying to stay with the vanilla c++14. I went for consistency. This code is pretty much unused anyway, since it only handles the very old CMake versions that

Re: [Kicad-developers] [PATCH] Adapt CMake 3.0 compatibility code for C++14

2019-07-17 Thread Seth Hillbrand
Thanks Simon! Not sure how I missed that one. Any reason to be using the gnu++14 extensions? I thought we were trying to stay with the vanilla c++14. -Seth On 2019-07-17 13:11, Simon Richter wrote: --- CMakeLists.txt | 8 1 file changed, 4 insertions(+), 4 deletions(-)

[Kicad-developers] [PATCH] Adapt CMake 3.0 compatibility code for C++14

2019-07-17 Thread Simon Richter
--- CMakeLists.txt | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 85b029786..cb41e0c15 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -201,12 +201,12 @@ endif() if( CMAKE_VERSION VERSION_LESS 3.1 AND (