Re: [Kicad-developers] [PATCH] Add Insert hotkey to add a zone/segment corner

2018-08-07 Thread Seth Hillbrand
Looks good John. I pushed your patch to the master branch. Thanks for your contribution! -Seth Am Sa., 4. Aug. 2018 um 04:40 Uhr schrieb John Beard : > Hi Seth, > > Sorry about that, I think I've checked the right thing here. > > I suppose many global TOOL_ACTIONs are actually unsafe to call

Re: [Kicad-developers] [PATCH] Add Insert hotkey to add a zone/segment corner

2018-08-04 Thread John Beard
Hi Seth, Sorry about that, I think I've checked the right thing here. I suppose many global TOOL_ACTIONs are actually unsafe to call from a global context but are defended implicitly by not providing a hotkey or menu item when the action isn't ready to get called. Cheers, John On Wed, Aug 1,

Re: [Kicad-developers] [PATCH] Add Insert hotkey to add a zone/segment corner

2018-08-01 Thread Seth Hillbrand
Hi John- I get a segfault when trying to use the hotkey to insert a point on a zone when it is not selected. -Seth Am Di., 24. Juli 2018 um 10:00 Uhr schrieb John Beard < john.j.be...@gmail.com>: > This patch adds a hotkey for adding a corner to a zone or segment. > This is an action I have

[Kicad-developers] [PATCH] Add Insert hotkey to add a zone/segment corner

2018-07-24 Thread John Beard
This patch adds a hotkey for adding a corner to a zone or segment. This is an action I have really struggled without a hotkey for! I have used Insert, as: 1) it's available and 2) it's what Inkscape uses (but Inkscape adds the point at the midpoint of the segment, this adds at the cursor). It