I've sent it to the mailing list, see
https://lists.launchpad.net/kicad-developers/msg37372.html
On Sat, Sep 8, 2018 at 4:21 PM Wayne Stambaugh wrote:
> Hey Andrew,
>
> Did you send the unit test patch to the mailing list or the bug report?
> I don't see it in my inbox but I have been so furious
Hey Andrew,
Did you send the unit test patch to the mailing list or the bug report?
I don't see it in my inbox but I have been so furiously trying to catch
up that I may have accidentally deleted it.
Cheers,
Wayne
On 09/08/2018 05:53 PM, Andrew Lutsenko wrote:
Hi Wayne,
It looks like you
Hi Wayne,
It looks like you committed first version of the patch without the unit
test.
I'm fine either way, just FYI.
On Sat, Sep 8, 2018 at 7:29 AM Wayne Stambaugh wrote:
> Andrew,
>
> I merged your patch into the development branch of KiCad. I also tagged
> it for release for 5.1 rather tha
Andrew,
I merged your patch into the development branch of KiCad. I also tagged
it for release for 5.1 rather than 5.0.1 since it is a new python
scripting feature. Thank you for your contribution to KiCad.
Cheers,
Wayne
On 08/31/2018 06:42 AM, Andrew Lutsenko wrote:
> Hi all,
>
> This is a
Friendly ping, please take a look at this patch
On Sat, Sep 1, 2018 at 1:21 AM Andrew Lutsenko wrote:
> Added a unit test. See amended patch attached.
>
> > ..\..\Kicad-dev\bin\python.exe testcases\test_002_board_class.py
>
> -
I'm sorry but I disagree with many things here
On Sat, Sep 1, 2018 at 2:13 AM Carsten Schoenert
wrote:
> Am 01.09.18 um 10:51 schrieb Andrew Lutsenko:
> > My test is trivial (create a model with some settings, add it to
> footprint,
> > try to read it back).
>
> Sure the tests are simple, but gi
I wonder why the python scripting devs didn't use all uppercase like the
C++ source? I guess it makes sense to leave it as is for the sake of
consistency.
On 08/31/2018 06:15 PM, Andrew Lutsenko wrote:
@Wayne,
Quick grep suggested that _List is the current convention:
$ egrep -ho '[a-zA-Z_]
Am 01.09.18 um 10:51 schrieb Andrew Lutsenko:
> My test is trivial (create a model with some settings, add it to footprint,
> try to read it back).
Sure the tests are simple, but given there are mostly a dozen of them in
the end count all the single amount of time for getting in touch with
the fun
My test is trivial (create a model with some settings, add it to footprint,
try to read it back).
Fixing other tests is outside of scope of this change.
On Sat, Sep 1, 2018 at 1:36 AM Carsten Schoenert
wrote:
> Am 01.09.18 um 10:21 schrieb Andrew Lutsenko:
> > Added a unit test. See amended patc
Am 01.09.18 um 10:21 schrieb Andrew Lutsenko:
> Added a unit test. See amended patch attached.
>
>> ..\..\Kicad-dev\bin\python.exe testcases\test_002_board_class.py
>
> --
> Ran 8 tests in 1.491s
>
> OK
I'd really appre
Added a unit test. See amended patch attached.
> ..\..\Kicad-dev\bin\python.exe testcases\test_002_board_class.py
--
Ran 8 tests in 1.491s
OK
On Fri, Aug 31, 2018 at 3:15 PM Andrew Lutsenko
wrote:
> @Wayne,
>
> Quick
@Wayne,
Quick grep suggested that _List is the current convention:
$ egrep -ho '[a-zA-Z_]+_List' -R ./pcbnew | sort -u
BOARD_ITEM_List
delete_BOARD_ITEM_List
delete_MODULE_List
delete_PAD_List
delete_TRACK_List
MODULE_List
new_BOARD_ITEM_List
new_MODULE_List
new_PAD_List
new_TRACK_List
PAD_List
T
I cant view the patch via my phone right now, but please add a simple
unittest in the qa folder as well.
fre. 31. aug. 2018 14.56 skrev Wayne Stambaugh :
> Andrew,
>
> I looked at this patch an it looks fine to me. I fine with exposing the
> 3D model properties in the Python scripting. Is there
Andrew,
I looked at this patch an it looks fine to me. I fine with exposing the
3D model properties in the Python scripting. Is there a reason why you
use MODULE_3D_SETTINGS_List instead of MODULE_3D_SETTINGS_LIST for the
template name? Typically we use the latter. Can anyone think of a good
r
Hi all,
This is a fix for https://bugs.launchpad.net/kicad/+bug/1758858
Regards,
Andrew
0001-pcbnew-add-3d-models-properties-to-swig.patch
Description: Binary data
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developer
15 matches
Mail list logo
