Re: [Kicad-developers] [PATCH] Add empty eeschema page layout for Eagle schematic import. Bug #1729722

Great, thank you Russell! That is exactly what I had in mind. Regards, Orson On 02/13/2018 01:56 AM, Russell Oliver wrote: > Updated patch. > > On Tue, Feb 13, 2018 at 9:41 AM Wayne Stambaugh > wrote: > >> On 02/12/2018 05:21 PM, Russell Oliver wrote: >>> So a file

Re: [Kicad-developers] [PATCH] Add empty eeschema page layout for Eagle schematic import. Bug #1729722

Updated patch. On Tue, Feb 13, 2018 at 9:41 AM Wayne Stambaugh wrote: > On 02/12/2018 05:21 PM, Russell Oliver wrote: > > So a file created on disk in the project folder that is then added as a > > path in the project specification? > > Yes. Just set

Re: [Kicad-developers] [PATCH] Add empty eeschema page layout for Eagle schematic import. Bug #1729722

On 02/12/2018 05:21 PM, Russell Oliver wrote: > So a file created on disk in the project folder that is then added as a > path in the project specification? Yes. Just set m_PageLayoutDescrFileName to empty.kicad_wks for both the schematic and the board BASE_SCREEN objects and you should be good

Re: [Kicad-developers] [PATCH] Add empty eeschema page layout for Eagle schematic import. Bug #1729722

So a file created on disk in the project folder that is then added as a path in the project specification? As a more general concept then should every project have a layout file in the project folder? On 13 Feb 2018 02:59, "Wayne Stambaugh" wrote: I prefer adding an

Re: [Kicad-developers] [PATCH] Add empty eeschema page layout for Eagle schematic import. Bug #1729722

I prefer adding an empty.kicad_wks file be added to the project and then set the board and schematic worksheets to this file. This would negate the file format rev bumps. On 2/12/2018 10:48 AM, Maciej Sumiński wrote: > Hi Russell, > > You are right, it adds a special case for project file

Re: [Kicad-developers] [PATCH] Add empty eeschema page layout for Eagle schematic import. Bug #1729722

Hi Russell, You are right, it adds a special case for project file format, so technically it is a version bump. Alternatively one could simply create "empty.kicad_wks" and store there the contents of emptyPageLayout[]. It seems safer, but on the other hand I would like to be able to specify that

Re: [Kicad-developers] [PATCH] Add empty eeschema page layout for Eagle schematic import. Bug #1729722

There is still one problem to be solved here: worksheet layout is not saved in schematic file, so the default worksheet is restored when an imported project is saved and reloaded. I have nothing against the patch, it gives a nicer first impression. Cheers, Orson On 02/07/2018 04:44 PM, Wayne

Re: [Kicad-developers] [PATCH] Add empty eeschema page layout for Eagle schematic import. Bug #1729722

I just tested printing then and it worked fine. plus one person's unhandled edge case is another's unit test. On Thu, Feb 8, 2018 at 12:05 AM Wayne Stambaugh wrote: > Be careful with zero length line segments. They have been known to > cause issues in the past. We

Re: [Kicad-developers] [PATCH] Add empty eeschema page layout for Eagle schematic import. Bug #1729722

Be careful with zero length line segments. They have been known to cause issues in the past. We recently fixed a print bug where a zero diameter circle was causing pages not to print. On 2/7/2018 7:45 AM, Russell Oliver wrote: > Hi Orson,  > > I'm completely fine with any simplifications and

Re: [Kicad-developers] [PATCH] Add empty eeschema page layout for Eagle schematic import. Bug #1729722

Hi Orson, I'm completely fine with any simplifications and style changes. With regards to the zero length line, it appears on line 110 of your patch file. 110: +"(line (name segm1:Line) (start 0 0) (end 0 0))\n" JP mentions in a comment to the bug report that there is a legacy compatibility

Re: [Kicad-developers] [PATCH] Add empty eeschema page layout for Eagle schematic import. Bug #1729722

Hi Russell, Thank you very much for the patch. It works as expected and I would like to merge it, but there are two things. I have simplified the patch a bit (moved the empty layout to an existing file, minor code formatting fixes), so please confirm you are ok with committing it under your

[Kicad-developers] [PATCH] Add empty eeschema page layout for Eagle schematic import. Bug #1729722

Attached is a patch that adds an empty layout using the same method as the SetDefaultLayout function, which is then called by the Eagle schematic plugin to leave only the imported frame visible. https://bugs.launchpad.net/kicad/+bug/1729722 Kind Regards Russell