Re: [Kicad-developers] [PATCH] Add live footprint filtering in modview window

Oliver, Understood. I'm fine with pushing this off until version 6. I'm pretty busy myself. I'm guessing there is a lot of common code that could be refactored. Given that the new symbol library editor already has a tree view, I wonder if the symbol library viewer is even necessary. After

Re: [Kicad-developers] [PATCH] Add live footprint filtering in modview window

Oliver, It seems to work but I found one issue that will certainly confuse users. Footprint libraries are loaded on demand so until you actually select a library in the viewer, there are no footprints to filter. Even after you select a library, only the footprints in the selected library are

Re: [Kicad-developers] [PATCH] Add live footprint filtering in modview window

Oops! Wrong email. Thanks for looking at this. On 11/23/2017 08:48 AM, Oliver Walters wrote: > Wayne, > > I think you meant to respond to the other thread. But good point, I > haven't fixed the step s-expr reader. Why doesn't this use the same > code? Anyway, I'll have a look. > > On Fri, Nov

Re: [Kicad-developers] [PATCH] Add live footprint filtering in modview window

Oliver, Have you tested the impact of these changes on the step exporter? I'm not sure it will understand the offset keyword and the step export will have incorrect model offsets. Please verify this before I commit these patches. If it creates a lot of work to correct, I'm thinking we should

Re: [Kicad-developers] [PATCH] Add live footprint filtering in modview window

Oliver, Here is the stack trace after typing 'r' in the search control. Thread 1 "kicad" received signal SIGSEGV, Segmentation fault. 0x7fffe0e3a250 in std::vector, std::allocator >

Re: [Kicad-developers] [PATCH] Add live footprint filtering in modview window

I already removed the patches from my dev branch so I could work on my stuff. I will try to get a stack dump when I get a chance. On 11/22/2017 07:33 AM, Oliver Walters wrote: > Wayne, > > That's disappointing. Any further debug info you can provide? > > On Wed, Nov 22, 2017 at 11:31 PM, Wayne

Re: [Kicad-developers] [PATCH] Add live footprint filtering in modview window

Wayne, That's disappointing. Any further debug info you can provide? On Wed, Nov 22, 2017 at 11:31 PM, Wayne Stambaugh wrote: > Oliver, > > I tested your footprint filtering patch set last night and it didn't go > very well. The very first letter I typed ('r') in the

Re: [Kicad-developers] [PATCH] Add live footprint filtering in modview window

Oliver, I tested your footprint filtering patch set last night and it didn't go very well. The very first letter I typed ('r') in the filter control caused kicad to crash so it's not ready just yet. Cheers, Wayne On 11/20/2017 06:57 PM, Oliver Walters wrote: > Wayne, > > Friendly bump in

Re: [Kicad-developers] [PATCH] Add live footprint filtering in modview window

Oliver, I didn't forget. It's still on my todo list. I just haven't had the time to review it. I will do my best to get it reviewed and merged over the Thanksgiving Holiday before the feature freeze. Cheers, Wayne On 11/20/2017 6:57 PM, Oliver Walters wrote: > Wayne, > > Friendly bump in

Re: [Kicad-developers] [PATCH] Add live footprint filtering in modview window

Wayne, Friendly bump in case this has been forgotten - this thread has wandered around a fair bit. Patches 0001 through 0008 are in the email above. Thanks On Fri, Nov 17, 2017 at 11:05 PM, Oliver Walters < oliver.henry.walt...@gmail.com> wrote: > Wayne, > > Please ignore the previous patch

Re: [Kicad-developers] [PATCH] Add live footprint filtering in modview window

Wayne, Please ignore the previous patch sets. I have made further tweaks and the attached patch set 0001 through 0008 should be considered canonical. . I have fixed a couple of pointer errors, and have also dropped the filter-by-library functionality. It was a bit hooky and I'd rather submit a

Re: [Kicad-developers] [PATCH] Add live footprint filtering in modview window

Hi, Am 16.11.2017 um 23:46 schrieb Seth Hillbrand: > Hi Oliver- > > I found where the issue is. I apparently have an invalid line in my > fp-lib-table. It lists my github library as type "KiCad". This is why the > URL looked odd in the debug message. I have to admit, I'm not certain how >

Re: [Kicad-developers] [PATCH] Add live footprint filtering in modview window

Seth, Currently at work but I'll have a look at these issues ASAP. I'd like to get this merged :) On Fri, Nov 17, 2017 at 9:46 AM, Seth Hillbrand wrote: > Hi Oliver- > > I found where the issue is. I apparently have an invalid line in my > fp-lib-table. It lists my

Re: [Kicad-developers] [PATCH] Add live footprint filtering in modview window

Kevin - noted. It appears that Seth found the cause of the issue anyway :) On Fri, Nov 17, 2017 at 10:30 AM, Kevin Cozens wrote: > On 2017-11-16 04:08 PM, Oliver Walters wrote: > >> I just tried that github repo and it works fine for me. It appears that >> you are missing a "/"

Re: [Kicad-developers] [PATCH] Add live footprint filtering in modview window

Orson, Yes this is correct. I have noticed this too and there is a workaround I can make. On Fri, Nov 17, 2017 at 10:07 AM, Maciej Suminski wrote: > Hi Oliver, > > I admit that recently I have wished for a footprint filter (/me puts a > tinfoil hat), so I like the

Re: [Kicad-developers] [PATCH] Add live footprint filtering in modview window

On 2017-11-16 04:08 PM, Oliver Walters wrote: I just tried that github repo and it works fine for me. It appears that you are missing a "/" after https:/ I don't think the second / is missing after https:/. There are places where the code normalizes paths which converts // to /. -- Cheers!

Re: [Kicad-developers] [PATCH] Add live footprint filtering in modview window

Hi Oliver, I admit that recently I have wished for a footprint filter (/me puts a tinfoil hat), so I like the idea. Being picky, I noticed that library and footprint filters behave a little differently: for libraries one needs to explicitly use wildcards, whereas it is not necessary for

Re: [Kicad-developers] [PATCH] Add live footprint filtering in modview window

Wayne, Patch set now goes to 0009 (all patches re-attached to this email). Most recent patch adds the following: - Busy cursor while loading each library (otherwise it feels like KiCad is just sleepy) - Further nullptr checks, trying to fix Seth's error - Removed a tooltip that erroneously

Re: [Kicad-developers] [PATCH] Add live footprint filtering in modview window

Seth, Did you try with the included 0008 patch? I have tried a lot to reproduce your bug but cannot do so. On Fri, Nov 17, 2017 at 4:40 AM, Seth Hillbrand wrote: > Oops, also got a segfault when hitting the "Reload button" on a github > library. Here's the backtrace:

Re: [Kicad-developers] [PATCH] Add live footprint filtering in modview window

Seth, I just tried that github repo and it works fine for me. It appears that you are missing a "/" after https:/ On Fri, Nov 17, 2017 at 4:37 AM, Seth Hillbrand wrote: > Hi Oliver- > > I tried the new patchset but I can't seem to get it to work. It only > loads the

Re: [Kicad-developers] [PATCH] Add live footprint filtering in modview window

Oops, also got a segfault when hitting the "Reload button" on a github library. Here's the backtrace: #0 0x7fffd69a1ccc in std::vector, std::allocator > >::size (this=0x10) at

Re: [Kicad-developers] [PATCH] Add live footprint filtering in modview window

Hi Oliver- I tried the new patchset but I can't seem to get it to work. It only loads the local libraries (none of the Github libraries). I get the error: Error: IO_ERROR: Footprint library path 'https:/ github.com/KiCad/Connectors_JST.pretty' does not exist -S On Thu, Nov 16, 2017 at 5:23

Re: [Kicad-developers] [PATCH] Add live footprint filtering in modview window

Important! Patch 0008 (attached) fixes a nullpointer error. BUT more importantly, it also reintroduces the ability to filter out libraries using the ':' separator! Now we are getting somewhere! On Thu, Nov 16, 2017 at 11:38 PM, Oliver Walters < oliver.henry.walt...@gmail.com> wrote: > Wayne, >

Re: [Kicad-developers] [PATCH] Add live footprint filtering in modview window

Wayne, I have finally found some time to readdress this. I have reimplemented the filtering using the existing FOOTPRINT_FILTER class. I have also reverted behaviour to work only on the currently selected footprint library. This removes the requirement to load all the libraries when the dialog

Re: [Kicad-developers] [PATCH] Add live footprint filtering in modview window

On 10/31/2017 5:01 PM, Oliver Walters wrote: > How should I proceed here then? > > I would like to see the various libraries being "cached" in the > background, but this is increasing the scope of the work by a large factor. > > One thing I have noticed: > > In eeschema when you launch the

Re: [Kicad-developers] [PATCH] Add live footprint filtering in modview window

How should I proceed here then? I would like to see the various libraries being "cached" in the background, but this is increasing the scope of the work by a large factor. One thing I have noticed: In eeschema when you launch the component viewer, it (on first run) maps and caches all the

Re: [Kicad-developers] [PATCH] Add live footprint filtering in modview window

hi Guys, this is a great feature. It would be a good thing to have a gray suggestion often used in webpages and phone apps. Example here: https://storage.googleapis.com/material-design/publish/material_v_12/assets/0B5ZSepuCX1xOOURmSHNjdktDR28/discoverable-extracted-label1.png cheers Fabrizio

Re: [Kicad-developers] [PATCH] Add live footprint filtering in modview window

On 10/31/2017 1:25 AM, Oliver Walters wrote: > Hmm, I had thought that there was a way to load only the *names* of > footprints, rather than individually parsing each footprint file. It > appears that this is not the case. Any suggestions on how the speed > could be improved? Currently I'm reading

Re: [Kicad-developers] [PATCH] Add live footprint filtering in modview window

Hmm, I had thought that there was a way to load only the *names* of footprints, rather than individually parsing each footprint file. It appears that this is not the case. Any suggestions on how the speed could be improved? Currently I'm reading out all the footprint names in each footprint

Re: [Kicad-developers] [PATCH] Add live footprint filtering in modview window

On 10/30/2017 5:23 PM, Oliver Walters wrote: > Thanks for the suggestions on fixing the text. I have that sorted.  > > I will look into different ways of caching footprint data so it is quicker.  > > Wayne, I didn't know about FOOTPRINT_FILTER I will switch to using that > instead (and provide

Re: [Kicad-developers] [PATCH] Add live footprint filtering in modview window

Thanks for the suggestions on fixing the text. I have that sorted. I will look into different ways of caching footprint data so it is quicker. Wayne, I didn't know about FOOTPRINT_FILTER I will switch to using that instead (and provide regex search). On 31 Oct 2017 06:55, "Seth Hillbrand"

Re: [Kicad-developers] [PATCH] Add live footprint filtering in modview window

On Mon, Oct 30, 2017 at 11:42 AM, Wayne Stambaugh wrote: > On 10/30/2017 1:16 PM, Seth Hillbrand wrote: > > Oliver, this is neat and very helpful. > > > > The greyed-out thing is a wx2.8 bug. You can work around it by setting > > the foreground color when updating the

Re: [Kicad-developers] [PATCH] Add live footprint filtering in modview window

On 10/30/2017 1:16 PM, Seth Hillbrand wrote: > Oliver, this is neat and very helpful. > > The greyed-out thing is a wx2.8 bug.  You can work around it by setting > the foreground color when updating the filter like this: >   >  void FOOTPRINT_VIEWER_FRAME::OnFilterUpdated( wxCommandEvent& event )

Re: [Kicad-developers] [PATCH] Add live footprint filtering in modview window

Oliver, this is neat and very helpful. The greyed-out thing is a wx2.8 bug. You can work around it by setting the foreground color when updating the filter like this: void FOOTPRINT_VIEWER_FRAME::OnFilterUpdated( wxCommandEvent& event ) { +// Workaround wx2.8 bug showing greyed color +

Re: [Kicad-developers] [PATCH] Add live footprint filtering in modview window

What! No regular expression search! Just kidding but you know someone will ask for it. I'm fine with merging this as long as the grey text issue that Chris pointed out is resolved. It seems odd that the text is greyed out. It looks like a focus issue. Also, is there any reason why the

Re: [Kicad-developers] [PATCH] Add live footprint filtering in modview window

Hi Oliver, This is a really useful improvement and works as advertised, I vote for merging! Cheers, Orson On 10/29/2017 02:37 PM, Oliver Walters wrote: > In the footprint viewer window it is often hard to find the exact footprint > you want across multiple libraries > > The attached patch set

Re: [Kicad-developers] [PATCH] Add live footprint filtering in modview window

Hi Oliver, I have tested your patchset against the current master. On 10/29/2017 02:37 PM, Oliver Walters wrote: > In the footprint viewer window it is often hard to find the exact footprint > you want across multiple libraries This looks great. Filtering by keywords is really good alternative to

[Kicad-developers] [PATCH] Add live footprint filtering in modview window

In the footprint viewer window it is often hard to find the exact footprint you want across multiple libraries The attached patch set adds a search filter input to the toolbar. Entering a filter string in this box updates the list of available libraries and footprints. Features: 1. Wildcard