Re: [Kicad-developers] [PATCH] Add mils as user unit

2017-09-05 Thread Mathias Grimmberger
Hi Wayne, Wayne Stambaugh writes: > On 9/4/2017 4:14 PM, Mathias Grimmberger wrote: [snip] >> Input validation is implemented quite unevenly in any case, some inputs >> do not even allow to input invalid characters (IMHO desirable), others >> allow anything and complain

Re: [Kicad-developers] [PATCH] Add mils as user unit

2017-09-05 Thread Lorenzo Marcantonio
On Mon, Sep 04, 2017 at 07:09:32PM -0400, Wayne Stambaugh wrote: > wxValidator is the standard way to customize control input and output. > This is well documented in the wxWidgets documentation. Please do not > create a custom design unless there is no way to do this as validator > which I

Re: [Kicad-developers] [PATCH] Add mils as user unit

2017-09-04 Thread Wayne Stambaugh
On 9/4/2017 8:58 AM, Tomasz Wlostowski wrote: > On 03.09.2017 18:29, Mathias Grimmberger wrote: >> >> Hi all, >> >> >> below is a patch to add "mils" as a user unit to pcbnew, the gerber >> viewer and the module editor. I left out eeschema because I do not think >> it's useful there, but if

Re: [Kicad-developers] [PATCH] Add mils as user unit

2017-09-04 Thread Wayne Stambaugh
On 9/4/2017 4:14 PM, Mathias Grimmberger wrote: > > Hi Lorenzo, > > Lorenzo Marcantonio writes: >> On Mon, Sep 04, 2017 at 02:58:45PM +0200, Tomasz Wlostowski wrote: >>> below is a patch to add "mils" as a user unit to pcbnew, the gerber >>> viewer and the module editor. I left

Re: [Kicad-developers] [PATCH] Add mils as user unit

2017-09-04 Thread Mathias Grimmberger
Hi Lorenzo, Lorenzo Marcantonio writes: > On Mon, Sep 04, 2017 at 02:58:45PM +0200, Tomasz Wlostowski wrote: >> below is a patch to add "mils" as a user unit to pcbnew, the gerber >> viewer and the module editor. I left out eeschema because I do not think >> it's useful there,

Re: [Kicad-developers] [PATCH] Add mils as user unit

2017-09-04 Thread jp charras
Le 04/09/2017 à 14:58, Tomasz Wlostowski a écrit : > On 03.09.2017 18:29, Mathias Grimmberger wrote: >> >> Hi all, >> >> >> below is a patch to add "mils" as a user unit to pcbnew, the gerber >> viewer and the module editor. I left out eeschema because I do not think >> it's useful there, but if

Re: [Kicad-developers] [PATCH] Add mils as user unit

2017-09-04 Thread Lorenzo Marcantonio
On Mon, Sep 04, 2017 at 02:58:45PM +0200, Tomasz Wlostowski wrote: > below is a patch to add "mils" as a user unit to pcbnew, the gerber > viewer and the module editor. I left out eeschema because I do not think > it's useful there, but if required adding it would be easy. The input box parser

Re: [Kicad-developers] [PATCH] Add mils as user unit

2017-09-04 Thread Tomasz Wlostowski
On 03.09.2017 18:29, Mathias Grimmberger wrote: > > Hi all, > > > below is a patch to add "mils" as a user unit to pcbnew, the gerber > viewer and the module editor. I left out eeschema because I do not think > it's useful there, but if required adding it would be easy. > > I probably missed

[Kicad-developers] [PATCH] Add mils as user unit

2017-09-03 Thread Mathias Grimmberger
Hi all, below is a patch to add "mils" as a user unit to pcbnew, the gerber viewer and the module editor. I left out eeschema because I do not think it's useful there, but if required adding it would be easy. I probably missed some places needing modification. In any case somebody with the