[Kicad-developers] [PATCH] Add progress reporting for GerbView file loading

2018-02-20 Thread Jon Evans
Hi all, This patch adds the progress reporter dialog to GerbView file loading, when loading multiple files and the total load time goes over 1 second. I've also done some refactoring to share code between loading multiple files via a gerber job file and via the regular open dialog. -Jon From d96

Re: [Kicad-developers] [PATCH] Add progress reporting for GerbView file loading

2018-02-20 Thread Andrey Kuznetsov
Does it make sense to predict whether a loading/progress window is necessary based on total file size, based on prediction that a certain size takes X seconds to load? Or is loading highly dependent on the data/objects being loaded? On Tue, Feb 20, 2018 at 7:21 PM, Jon Evans wrote: > Hi all, > >

Re: [Kicad-developers] [PATCH] Add progress reporting for GerbView file loading

2018-02-21 Thread Jon Evans
It's dependent on the data in the files, which is why I decided to use the time based delay method. On my machine it normally doesn't show up, but a full set of Gerbers from a very large board is slow enough to show it. -Jon On Feb 21, 2018 00:07, "Andrey Kuznetsov" wrote: > Does it make sense

Re: [Kicad-developers] [PATCH] Add progress reporting for GerbView file loading

2018-02-21 Thread Wayne Stambaugh
Patch merged. Thanks! On 2/20/2018 10:21 PM, Jon Evans wrote: > Hi all, > > This patch adds the progress reporter dialog to GerbView file loading, > when loading multiple files and the total load time goes over 1 second.  > I've also done some refactoring to share code between loading multiple >