Re: [Kicad-developers] [PATCH] Add support for panning with left and right mouse buttons

2017-09-15 Thread Maciej Suminski
Hi Jon, I have tested your patch and indeed it works as described. I have merged the patch, as it does not break anything, but brings a potential benefit to GALified gerbview. Regards, Orson On 09/13/2017 03:53 PM, Jon Evans wrote: > Hi Orson and Bernhard, > > 1) If the left-click pan setting

Re: [Kicad-developers] [PATCH] Add support for panning with left and right mouse buttons

2017-09-13 Thread Andrey Kuznetsov
Sorry, I was talking about the nightly version. On Wed, Sep 13, 2017 at 12:24 PM Jon Evans wrote: > Are you using my gerbview_gal branch and testing with gerbview? That is > the only place where this feature is enabled. If you would like to test > it outside of that

Re: [Kicad-developers] [PATCH] Add support for panning with left and right mouse buttons

2017-09-13 Thread Jon Evans
Are you using my gerbview_gal branch and testing with gerbview? That is the only place where this feature is enabled. If you would like to test it outside of that branch, change m_panWithRightButton to true and rebuild. I don't have a Windows laptop to test with at the moment, but I would

Re: [Kicad-developers] [PATCH] Add support for panning with left and right mouse buttons

2017-09-13 Thread Andrey Kuznetsov
FYI, Regarding panning with 2 fingers, it does not work on my Lenovo laptop running windows 8. Only zoom works, 2 finger up-down motion. On Wed, Sep 13, 2017 at 6:53 AM, Jon Evans wrote: > Hi Orson and Bernhard, > > 1) If the left-click pan setting is enabled, it does

Re: [Kicad-developers] [PATCH] Add support for panning with left and right mouse buttons

2017-09-13 Thread Jon Evans
Hi Orson and Bernhard, 1) If the left-click pan setting is enabled, it does conflict with left-click dragging (to make a group selection, for example). I do not enable left-click pan anywhere by default, I just added it in case there is a single-function "pan tool" ever desired, like what is

Re: [Kicad-developers] [PATCH] Add support for panning with left and right mouse buttons

2017-09-13 Thread Bernhard Stegmaier
Hi, Did you try (at least for laptops) the existing touchpad panning - instead of introducing yet another panning mode? The 2-finger panning gestures should meanwhile also be available on Windows/Linux? Regards, Bernhard > On 13. Sep 2017, at 11:21, Maciej Suminski

Re: [Kicad-developers] [PATCH] Add support for panning with left and right mouse buttons

2017-09-13 Thread Maciej Suminski
Hi Jon, I apologize for delayed replies, I have very limited time for KiCad development recently. I do not mind adding such setting, but does not it cause issues with right-click menus or left mouse button click actions? Regards, Orson On 09/06/2017 03:31 AM, Jon Evans wrote: > Hi all, > >

Re: [Kicad-developers] [PATCH] Add support for panning with left and right mouse buttons

2017-09-12 Thread Jon Evans
Bump, are any of the GAL developers around to review this? Thanks, Jon On Tue, Sep 5, 2017 at 9:31 PM, Jon Evans wrote: > Hi all, > > This patch extends the VIEW_CONTROLS to allow optional panning with left > or right buttons in addition to middle. I plan to make use of

Re: [Kicad-developers] [PATCH] Add support for panning with left and right mouse buttons

2017-09-06 Thread Andrey Kuznetsov
Thanks Jon, also useful with mice that have shitty middle mouse buttons that are either hard to press or spin freely willy, or both, that makes it hard to press the button without zooming in all over the place. On Tue, Sep 5, 2017 at 6:31 PM, Jon Evans wrote: > Hi all, > >

[Kicad-developers] [PATCH] Add support for panning with left and right mouse buttons

2017-09-05 Thread Jon Evans
Hi all, This patch extends the VIEW_CONTROLS to allow optional panning with left or right buttons in addition to middle. I plan to make use of this in GerbView for an easy panning mode that works well on laptops and 2-button mice, and this might also be useful in other applications --