[Kicad-developers] [PATCH] Assertion in pcbnew/dialogs/dialog_select_net_from_list.cpp

2017-02-27 Thread Julius Schmidt
This patch fixes a format string assertion. diff --git a/pcbnew/dialogs/dialog_select_net_from_list.cpp b/pcbnew/dialogs/dialog_select_net_from_list.cpp index f4539aa..fb70b90 100644 --- a/pcbnew/dialogs/dialog_select_net_from_list.cpp +++ b/pcbnew/dialogs/dialog_select_net_from_list.cpp @@ -161

Re: [Kicad-developers] [PATCH] Assertion in pcbnew/dialogs/dialog_select_net_from_list.cpp

2017-02-27 Thread Kevin Cozens
On 2017-02-27 06:54 PM, Julius Schmidt wrote: This patch fixes a format string assertion. Thank you for the patch. I ran across this problem. With your patch applied I no longer get the assertions when I select List Nets. It also saved me from having to file a bug report about the issue. --

Re: [Kicad-developers] [PATCH] Assertion in pcbnew/dialogs/dialog_select_net_from_list.cpp

2017-02-27 Thread Sergey A. Borshch
On 28.02.2017 01:54, Julius Schmidt wrote: This patch fixes a format string assertion. ... -txt.Printf( wxT( "%u" ), net->m_PadInNetList.size() ); +txt.Printf( wxT( "%u" ), (unsigned) net->m_PadInNetList.size() ); std::vector::size() returns size_t type. Why should you

Re: [Kicad-developers] [PATCH] Assertion in pcbnew/dialogs/dialog_select_net_from_list.cpp

2017-02-28 Thread Julius Schmidt
I know about %zu, but this is wx Printf, not C99 printf. Does it also support %zu? Do we use it anywhere else? On Tue, 28 Feb 2017, Sergey A. Borshch wrote: On 28.02.2017 01:54, Julius Schmidt wrote: This patch fixes a format string assertion. ... -txt.Printf( wxT( "%u" ), net

Re: [Kicad-developers] [PATCH] Assertion in pcbnew/dialogs/dialog_select_net_from_list.cpp

2017-02-28 Thread Sergey A. Borshch
On 28.02.2017 10:33, Julius Schmidt wrote: I know about %zu, but this is wx Printf, not C99 printf. Does it also support %zu? Yes, it does: http://docs.wxwidgets.org/3.1/classwx_string.html#a9588b7f2684b9a6a924dc3746a2b2f8d --- quote: Note This function will use a safe version of vsprintf()

Re: [Kicad-developers] [PATCH] Assertion in pcbnew/dialogs/dialog_select_net_from_list.cpp

2017-02-28 Thread Wayne Stambaugh
I seem to remember the z specifier causing issues on some platforms but that may have been in the 2.8 branch of wx but it's been a while so my memory is not so clear on the issue. If you choose use the z specifier (which is the correct way to do this), it will need to be thoroughly tested on all p

Re: [Kicad-developers] [PATCH] Assertion in pcbnew/dialogs/dialog_select_net_from_list.cpp

2017-03-13 Thread Wayne Stambaugh
Julius, I committed your patch to the master branch. Thank you for your contribution to KiCad. Cheers, Wayne On 2/27/2017 6:54 PM, Julius Schmidt wrote: > This patch fixes a format string assertion. > > diff --git a/pcbnew/dialogs/dialog_select_net_from_list.cpp > b/pcbnew/dialogs/dialog_sele