Re: [Kicad-developers] [PATCH] CW/CCW rotation in GAL

2017-03-30 Thread John Beard
HI Orson, Thanks! Credit where credit is due: I didn't notice, it was kaitrek on IRC. I was just mashing R until I got what I wanted! Cheers, John On Thu, Mar 30, 2017 at 10:15 PM, Maciej Sumiński wrote: > Hi John, > > Good catch, I have committed both patches. I

Re: [Kicad-developers] [PATCH] CW/CCW rotation in GAL

2017-03-30 Thread Maciej Sumiński
Hi John, Good catch, I have committed both patches. I guess it has not been noticed, as most people do not really pay attention to rotation direction, it is only up to 3 hotkey presses to get any of the 90* multiples. Anyway, it is surely better to perform what is written on the label. Cheers,

Re: [Kicad-developers] [PATCH] CW/CCW rotation in GAL

2017-03-30 Thread John Beard
This will all be moot when GAL hotkeys can be remapped, since users that care can swap them over. In any case, the attached patch can be applied after the correction above to also swap 'R' and 'Shift-R', so that R is CCW. Cheers, John On Thu, Mar 30, 2017 at 7:32 PM, Clemens Koller

Re: [Kicad-developers] [PATCH] CW/CCW rotation in GAL

2017-03-30 Thread Clemens Koller
Hello, Jon! On 2017-03-30 11:07, John Beard wrote: > Hi, > When CW/CCW rotation was added in GAL (7045ed92f), the tool actions > didn't correct for the internal represention of angles, so CW/CCW were > reversed. This patch fixes that. I failed to notice the comment "// > TODO rotate CCW" was

[Kicad-developers] [PATCH] CW/CCW rotation in GAL

2017-03-30 Thread John Beard
Hi, When CW/CCW rotation was added in GAL (7045ed92f), the tool actions didn't correct for the internal represention of angles, so CW/CCW were reversed. This patch fixes that. I failed to notice the comment "// TODO rotate CCW" was wrong. On the other hand, it seems only one person actually