Re: [Kicad-developers] [PATCH] Change from EDA_COLOR_T to COLOR4D and arbitrary color support

Thank you, Diogo - I've got this patch and am currently looking over the other MacOS build errors related to this. I'll push both this and anything else I come up with when I'm done. On Wed, Feb 22, 2017 at 07:11:03PM +, Diogo Condeço wrote: > Hi Jon, > > Thanks that was the issue... > >

Re: [Kicad-developers] [PATCH] Change from EDA_COLOR_T to COLOR4D and arbitrary color support

Hi Jon, Thanks that was the issue... Attached is a patch for this issue... Please credit Jon with it... Thanks, Diogo On Wed, Feb 22, 2017 at 7:01 PM, Jon Evans wrote: > Thanks Chris. > That line was hidden inside an #if block that only compiles for Mac, so > it's

Re: [Kicad-developers] [PATCH] Change from EDA_COLOR_T to COLOR4D and arbitrary color support

I'll have a look at MacOS build tonight if Diogo doesn't figure it out first. On Feb 22, 2017 1:57 PM, "Jon Evans" wrote: > Hi Diogo, > > Unfortunately I cannot test on Mac OS at all, and can't test on any > platform this minute. > But, I think you have to change that line

Re: [Kicad-developers] [PATCH] Change from EDA_COLOR_T to COLOR4D and arbitrary color support

Hi Diogo, Unfortunately I cannot test on Mac OS at all, and can't test on any platform this minute. But, I think you have to change that line to: wxPen pen( GetParent()->GetGridColor().ToColour(), h ); -Jon On Wed, Feb 22, 2017 at 1:05 PM, Diogo Condeço wrote: > Hi

Re: [Kicad-developers] [PATCH] Change from EDA_COLOR_T to COLOR4D and arbitrary color support

Still regarding the above issue... It seems one of two issues: 1- either wrong number of arguments; or 2- wrong type of arguments for the wxPen constructor... Or it could be a mix of both. :) Thanks, Diogo On Wed, Feb 22, 2017 at 6:05 PM, Diogo Condeço wrote: > Hi

Re: [Kicad-developers] [PATCH] Change from EDA_COLOR_T to COLOR4D and arbitrary color support

Le 22/02/2017 à 19:05, Diogo Condeço a écrit : > Hi Jon, > > Your patch 0001 on this thread introduced a bug which makes kicad unable to > build... > > a52250a91e24733ce798ad8baa4597032d49d11e this was the commit. > > kicad/common/draw_panel.cpp:757:15: error: no matching constructor for >

Re: [Kicad-developers] [PATCH] Change from EDA_COLOR_T to COLOR4D and arbitrary color support

Hi Jon, Your patch 0001 on this thread introduced a bug which makes kicad unable to build... a52250a91e24733ce798ad8baa4597032d49d11e this was the commit. kicad/common/draw_panel.cpp:757:15: error: no matching constructor for initialization of 'wxPen' wxPen pen(

Re: [Kicad-developers] [PATCH] Change from EDA_COLOR_T to COLOR4D and arbitrary color support

Great, so now they are in the master repository. Thank you for the patches. Regards, Orson On 02/22/2017 02:10 PM, Jon Evans wrote: > Yes, they are ready to merge. > > Best, > Jon > > On Feb 22, 2017 03:37, "Maciej Sumiński" wrote: > >> I got a response from Wayne

Re: [Kicad-developers] [PATCH] Change from EDA_COLOR_T to COLOR4D and arbitrary color support

Hey Jon, I'm fine with merging the existing patches as is, as long as I know being able to revert to the default colors is on your radar. I just don't want it to get lost in the noise. Color themes is a nice bonus. Cheers, Wayne On 2/22/2017 9:03 AM, Jon Evans wrote: > Hi Wayne, is this a

Re: [Kicad-developers] [PATCH] Change from EDA_COLOR_T to COLOR4D and arbitrary color support

Hi Wayne, is this a requirement to merge the existing patches or something you'd like to see before the 5.0 release? I can definitely add that, but I was planning to address that with my color themes feature -- the default KiCad colors would be a "read-only" theme that people could always revert

Re: [Kicad-developers] [PATCH] Change from EDA_COLOR_T to COLOR4D and arbitrary color support

One thing I would like to see (unless I missed it) is a reset to default color feature. This would be useful for legacy canvas users where getting the colors correct is critical for decent board/footprint canvas rendering. On 2/22/2017 3:36 AM, Maciej Sumiński wrote: > I got a response from

Re: [Kicad-developers] [PATCH] Change from EDA_COLOR_T to COLOR4D and arbitrary color support

Yes, they are ready to merge. Best, Jon On Feb 22, 2017 03:37, "Maciej Sumiński" wrote: > I got a response from Wayne saying he is ok with the changes (I suppose > the mail was meant to be sent here). Do you think the patches ready to > be merged? They seem complete to

Re: [Kicad-developers] [PATCH] Change from EDA_COLOR_T to COLOR4D and arbitrary color support

I got a response from Wayne saying he is ok with the changes (I suppose the mail was meant to be sent here). Do you think the patches ready to be merged? They seem complete to me, but I just want to confirm. Regards, Orson On 02/20/2017 06:55 PM, Jon Evans wrote: > Thanks Orson, no I don't mind

Re: [Kicad-developers] [PATCH] Change from EDA_COLOR_T to COLOR4D and arbitrary color support

I think you should just be able to add the branch Maciej linked earlier, and possibly do a pull -r on that. 2017-02-20 19:06 GMT+01:00 Wayne Stambaugh : > Please post the rebased patch. I like to take a look at it and test it. > > Thanks, > > Wayne > > On 2/20/2017 12:50

Re: [Kicad-developers] [PATCH] Change from EDA_COLOR_T to COLOR4D and arbitrary color support

Please post the rebased patch. I like to take a look at it and test it. Thanks, Wayne On 2/20/2017 12:50 PM, Maciej Sumiński wrote: > Hi Jon, > > I have just tested the patch, and I really like it. I just need to test > it a bit longer, as there are numerous changes, but I am in favor of >

Re: [Kicad-developers] [PATCH] Change from EDA_COLOR_T to COLOR4D and arbitrary color support

Thanks Orson, no I don't mind changing to static consts! Best, Jon On Mon, Feb 20, 2017 at 12:50 PM, Maciej Sumiński wrote: > Hi Jon, > > I have just tested the patch, and I really like it. I just need to test > it a bit longer, as there are numerous changes, but I am

Re: [Kicad-developers] [PATCH] Change from EDA_COLOR_T to COLOR4D and arbitrary color support

Hi Jon, I have just tested the patch, and I really like it. I just need to test it a bit longer, as there are numerous changes, but I am in favor of merging the patch. I also applied one more patch changing a few defines (UNSPECIFIED, BLACK, WHITE) to static consts, I hope you do not mind. If

Re: [Kicad-developers] [PATCH] Change from EDA_COLOR_T to COLOR4D and arbitrary color support

Hi all, Attached is a follow-up patch to the COLOR4D change above -- I reverted from using wxColourPickerCtrl back to wxBitmapButton in the eeschema color config, because I finally got my Windows 10 testing environment set up, and found out that for some reason wxColourPickerCtrl looks really