Re: [Kicad-developers] [PATCH] Field editor buttons

2017-09-13 Thread Maciej Suminski
Hi Oliver, I like the change. The new buttons take less space and the icons appear self-explanatory. Cheers, Orson On 09/12/2017 09:50 AM, Oliver Walters wrote: > Attached is a patch set that simplifies the UI buttons for organising > component fields, both in the symbol editor and the schematic

Re: [Kicad-developers] [PATCH] Field editor buttons

2017-09-13 Thread Oliver Walters
Orson, Thanks, I have noticed (and I'm sure others have) a whole swathe of UX stuff that is pretty clunky. This one seemed like an easy win :) On Wed, Sep 13, 2017 at 8:18 PM, Maciej Suminski wrote: > Hi Oliver, > > I like the change. The new buttons take less space and the icons appear > sel

Re: [Kicad-developers] [PATCH] Field editor buttons

2017-09-14 Thread Wayne Stambaugh
Oliver, I merged your patch set into the master branch. Thank you for your contribution to KiCad. FYI, I fixed a few coding policy violations: +m_FieldsBuf[fieldNdx + 1].SetId(fieldNdx + 1); ^ ^ missing spa

Re: [Kicad-developers] [PATCH] Field editor buttons

2017-09-15 Thread Fabrizio Tappero
Dear Oliver, this patch add 4 new arrow icons (left, right, up, down) that where already present in kicad. Green button is also present, just need to be renamed appropriately. I would propose to make use of present icons whenever possible. kicad has now 494 icons that are very difficult to manage

Re: [Kicad-developers] [PATCH] Field editor buttons

2017-09-15 Thread Oliver Walters
Hi Fabrizio, The icons I used were already in the bitmap_src directory, I didn't create any new ones? Or do I misunderstand what you mean? On 15 Sep 2017 23:45, "Fabrizio Tappero" wrote: Dear Oliver, this patch add 4 new arrow icons (left, right, up, down) that where already present in kicad.

Re: [Kicad-developers] [PATCH] Field editor buttons

2017-09-18 Thread Fabrizio Tappero
Hi Oliver, hups, sorry my bad. Please forget what I said ;-) cheers Fabrizio On Fri, Sep 15, 2017 at 11:35 PM, Oliver Walters wrote: > Hi Fabrizio, > > The icons I used were already in the bitmap_src directory, I didn't create > any new ones? Or do I misunderstand what you mean? > > > On 15 Sep