Re: [Kicad-developers] [PATCH] Fix 'catching polymorphic type by value' warnings

Thank you John, I have just pushed your patch. Cheers, Orson On 06/05/2018 10:02 AM, John Beard wrote: > Hi, > > Sorry, I missed one out in kicad/import_project.cpp > > Cheers, > > John > > On Tue, Jun 5, 2018 at 8:43 AM, John Beard wrote: > >> Hi, >> >> Small patch to fix some warnings

Re: [Kicad-developers] [PATCH] Fix 'catching polymorphic type by value' warnings

Hi, Sorry, I missed one out in kicad/import_project.cpp Cheers, John On Tue, Jun 5, 2018 at 8:43 AM, John Beard wrote: > Hi, > > Small patch to fix some warnings (GCC 8.1.0) like this: > > warning: catching polymorphic type ‘class std::out_of_range’ by value > [-Wcatch-value=] >

[Kicad-developers] [PATCH] Fix 'catching polymorphic type by value' warnings

Hi, Small patch to fix some warnings (GCC 8.1.0) like this: warning: catching polymorphic type ‘class std::out_of_range’ by value [-Wcatch-value=] catch( std::out_of_range ) ^~~~ Fixed by changing to catch-by-reference: "catch( const std:::out_of_range& )"