Re: [Kicad-developers] [PATCH] Fix (Ctrl)+(ASCII control key) hotkey handling

No problem, you are welcome. I forgot to test: Ctrl-xx and Alt-xx also don’t seem to do anything when trying to configure it as a hotkey in a version before you started to change things (tested with 6397). So, no regression with those… :) > On 30.01.2016, at 16:48, Chris Pavlina

Re: [Kicad-developers] [PATCH] Fix (Ctrl)+(ASCII control key) hotkey handling

Thank you very much! Nah, nothing else yet - I'll try to get these fixed first. I figured Ctrl-xx would be the normal issue with Ctrl vs Command on OSX, but Alt? hrm. I may have to see if I can find an OSX machine to borrow for a while. On Sat, Jan 30, 2016 at 11:27:09AM +0100, Bernhard

Re: [Kicad-developers] [PATCH] Fix (Ctrl)+(ASCII control key) hotkey handling

I played around a bit: * Normal keys without modifier seem to be fine * I can confirm the space/bell issue. This is not the case with the rev 6493 I am currently working with, so this seems to be a regression. * Special keys like Tab, PgUp, etc. seem to be OK * Cmd-xx seems to work with xx being

Re: [Kicad-developers] [PATCH] Fix (Ctrl)+(ASCII control key) hotkey handling

Have any OS X devs had a chance to test this? I got a test from one, but haven't been able to track down a followup to a potential regression. I have a report that using as a hotkey on OSX with this patch causes a bell. Does someone have a chance to check that for me? Most importantly right now,

Re: [Kicad-developers] [PATCH] Fix (Ctrl)+(ASCII control key) hotkey handling

I can try tomorrow… > On 29 Jan 2016, at 15:44, Chris Pavlina wrote: > > Have any OS X devs had a chance to test this? I got a test from one, but > haven't been able to track down a followup to a potential regression. > > I have a report that using as a hotkey on OSX

Re: [Kicad-developers] [PATCH] Fix (Ctrl)+(ASCII control key) hotkey handling

Updated patch - quite a few changes. First I noticed I was inadvertently trapping some keys I shouldn't (try using Ctrl+S with the original patch...), and then I decided to tackle the old "bug" that certain key combinations, like Shift+Tab, cannot be used. To make sure hotkeys are recognized

Re: [Kicad-developers] [PATCH] Fix (Ctrl)+(ASCII control key) hotkey handling

Hi Chris! I am a bit short on time, currently, but will test your code asap next week, I hope. Thanks for taking care about that! On 2016-01-21 04:44, Chris Pavlina wrote: > - Hotkeys that are *not* handled by the main hotkey code (for example, > menu keys like Alt+F to call up the File menu)

Re: [Kicad-developers] [PATCH] Fix (Ctrl)+(ASCII control key) hotkey handling

Le 21/01/2016 04:44, Chris Pavlina a écrit : > There is an old bug that people turned up while testing my new hotkey > editor, attached is a patch that fixes it. This patch pokes into the > main hotkey handling code, so I really want as many people to test it as > possible - it's a relatively

Re: [Kicad-developers] [PATCH] Fix (Ctrl)+(ASCII control key) hotkey handling

There is definitely no way to do that in wxwidgets, any and all keys that are received generate wxEVT_CHAR_HOOK, which I am receiving. There may be a way to do it in X11, I don't know, but it would require significant system-specific bodgery. Also it'll tick people off, since if they've

Re: [Kicad-developers] [PATCH] Fix (Ctrl)+(ASCII control key) hotkey handling

Hi, Chris! On 2016-01-21 15:16, Chris Pavlina wrote: > There is definitely no way to do that in wxwidgets, any and all keys > that are received generate wxEVT_CHAR_HOOK, which I am receiving. There > may be a way to do it in X11, I don't know, but it would require > significant system-specific

Re: [Kicad-developers] [PATCH] Fix (Ctrl)+(ASCII control key) hotkey handling

Regression fixed in 6505, feel free to continue testing :) On Thu, Jan 21, 2016 at 12:05:51PM +0100, jp charras wrote: > Le 21/01/2016 04:44, Chris Pavlina a écrit : > > There is an old bug that people turned up while testing my new hotkey > > editor, attached is a patch that fixes it. This

Re: [Kicad-developers] [PATCH] Fix (Ctrl)+(ASCII control key) hotkey handling

Interestingly this regression seems to be older, a bisect indicates it dates all the way back to 6479 (specifically 6478.1.1, as 6479 was a merge). I'm surprised nobody has found that yet! Working on fixing it. On Thu, Jan 21, 2016 at 12:05:51PM +0100, jp charras wrote: > Le 21/01/2016 04:44,

[Kicad-developers] [PATCH] Fix (Ctrl)+(ASCII control key) hotkey handling

There is an old bug that people turned up while testing my new hotkey editor, attached is a patch that fixes it. This patch pokes into the main hotkey handling code, so I really want as many people to test it as possible - it's a relatively minor bug, I don't want to go introducing twelve