I committed this patch in the product branch r5357. I did fine some
trailing white space that I removed before I committed the patch. Thank
you for your contribution to KiCad.
Cheers,
Wayne
On 1/5/2015 9:34 PM, Adam Wolf wrote:
> Hi,
>
> There was a minor typo spotted by Bob in the patch. I
Thanks for testing! also fixed a tiny whitespace issue reported by
Nick on IRC (indentation of a comment in line 41 of the patch), Thank
you all for helping fix some issues with it!
~José
On Mon, Jan 5, 2015 at 11:34 PM, Adam Wolf
wrote:
> Hi,
>
> There was a minor typo spotted by Bob in the pat
Hi,
There was a minor typo spotted by Bob in the patch. I fixed it, and tested
it on OS X. Works great.
Adam Wolf
Cofounder and Engineer
W&L
On Mon, Jan 5, 2015 at 3:38 PM, Wayne Stambaugh
wrote:
> Jose,
>
> The formatting of the if/else if statements does not follow the coding
> policy. Th
Oh my bad, I'm not used to this style, fixed patch attached, also
realized that everywhere else in kicad you are using "kicad" as the
bundle name in OSX, so I changed that for consistency.
On Mon, Jan 5, 2015 at 6:38 PM, Wayne Stambaugh wrote:
> Jose,
>
> The formatting of the if/else if statemen
Jose,
The formatting of the if/else if statements does not follow the coding
policy. They should be formatted:
if( condition )
{
}
else if( condition )
{
}
Thanks,
Wayne
On 1/5/2015 4:36 PM, José Ignacio wrote:
> Whoops, I didn't realize my pre-approval email went through the list
> after all
Looks like a typo in the patch.
Bob G
On 01/05/2015 03:31 PM, José Ignacio wrote:
+lockparh.AppendDir( wxT( "org.kicad-pcb.kicad" ) );
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Whoops, I didn't realize my pre-approval email went through the list
after all, sorry for littering the mailing list with two slightly
different versions of the same patch. the one in this thread is the
most current.
Cheers,
José
On Mon, Jan 5, 2015 at 6:33 PM, Adam Wolf wrote:
> I will test thi
I will test this on OS X.
Adam Wolf
Cofounder and Engineer
W&L
On Mon, Jan 5, 2015 at 3:31 PM, José Ignacio wrote:
> Hello, I wrote a patch to fix the issue of Kicad creating lock/PID
> files for applications and open files in the user's home directory,
> which is unsightly and wrong according
Hello, I wrote a patch to fix the issue of Kicad creating lock/PID
files for applications and open files in the user's home directory,
which is unsightly and wrong according to the XDG[1]/Apple[2]
standards/spec.
To fix it I created a new function in common.cpp which fetches the
proper path to use
9 matches
Mail list logo
