Re: [Kicad-developers] [PATCH] Fix lp:1529159

2016-02-22 Thread Bernhard Stegmaier
> On 22 Feb 2016, at 22:09, Wayne Stambaugh wrote: > > I'm not. I will add a note about the wxWidgets bug so whenever we set > the minimum wxWidgets version to 3.0.3 or later, it can be removed. Just noticed your commit… unfortunately, the comment is very misleading now. The mentioned http

Re: [Kicad-developers] [PATCH] Fix lp:1529159

2016-02-22 Thread Wayne Stambaugh
On 2/22/2016 4:07 PM, Clemens Koller wrote: > Hello, Wayne! > > On 2016-02-22 20:23, Wayne Stambaugh wrote: >> Anyone else see any issues with this patch? I just tested it on windows >> and I didn't see any issues. Since this only seems to be an issue on >> OSX, maybe we should wrap this in an #

Re: [Kicad-developers] [PATCH] Fix lp:1529159

2016-02-22 Thread Clemens Koller
Hello, Wayne! On 2016-02-22 20:23, Wayne Stambaugh wrote: > Anyone else see any issues with this patch? I just tested it on windows > and I didn't see any issues. Since this only seems to be an issue on > OSX, maybe we should wrap this in an #ifdef/#endif as much as I don't > like them. I don't

Re: [Kicad-developers] [PATCH] Fix lp:1529159

2016-02-22 Thread Wayne Stambaugh
Anyone else see any issues with this patch? I just tested it on windows and I didn't see any issues. Since this only seems to be an issue on OSX, maybe we should wrap this in an #ifdef/#endif as much as I don't like them. On 2/20/2016 8:13 AM, Bernhard Stegmaier wrote: > Hi, > > attached a patc

[Kicad-developers] [PATCH] Fix lp:1529159

2016-02-22 Thread Bernhard Stegmaier
Hi, attached a patch to fix lp:1529159, it is still reproducible with a current wxWidgets master. Credits go to the author of the bug report, I just did change the condition to immediately return if one of the sizes is zero (and create the patch). Of course, it could be argued if the real fix f