Re: [Kicad-developers] [PATCH] GerbView GAL support

Thanks Nick, I will check it out soon. On Sun, Nov 5, 2017 at 5:44 PM, Nick Østergaard wrote: > Hi, I also created a bug to track this on https://bugs.launchpad.net/ > kicad/+bug/1730249 > > 2017-11-05 23:38 GMT+01:00 Nick Østergaard : > >> Hi Jon >> >>

Re: [Kicad-developers] [PATCH] GerbView GAL support

Hi, I also created a bug to track this on https://bugs.launchpad.net/kicad/+bug/1730249 2017-11-05 23:38 GMT+01:00 Nick Østergaard : > Hi Jon > > Thakn you for your work. I finally got time to just play around a bit more > in gerbview with GAL :) > > I just tested a random

Re: [Kicad-developers] [PATCH] GerbView GAL support

Thanks Oliver! I have to admit, part of why I took on this project was to learn about the GAL things so that I can be of assistance for the eeschema port :-) I definitely plan to help with that, but I have some other things to work on in the short term (and want to make sure everything is working

Re: [Kicad-developers] [PATCH] GerbView GAL support

Jon, The GAL gerber viewer works a treat! It's so fast now! Can we expect the same treatment to eeschema? ;) Thanks for your work! On Tue, Sep 26, 2017 at 7:11 AM, Jon Evans wrote: > Thanks Orson. The attached patch changes the d-code LOD threshold to a > more reasonable

Re: [Kicad-developers] [PATCH] GerbView GAL support

Perfect, I have just committed your patch. Thank you! Regards, Orson On 09/25/2017 11:11 PM, Jon Evans wrote: > Thanks Orson. The attached patch changes the d-code LOD threshold to a > more reasonable value. > > -Jon > > On Mon, Sep 25, 2017 at 8:31 AM, Maciej Sumiński

Re: [Kicad-developers] [PATCH] GerbView GAL support

Thanks Orson. The attached patch changes the d-code LOD threshold to a more reasonable value. -Jon On Mon, Sep 25, 2017 at 8:31 AM, Maciej Sumiński wrote: > Jon, > > Thank you very much for your work on GerbView GAL support. I have just > pushed your changes to the

Re: [Kicad-developers] [PATCH] GerbView GAL support

Jon, Thank you very much for your work on GerbView GAL support. I have just pushed your changes to the master branch, including the most recent patches. The display performance is significantly better when compared to the legacy renderer. Still, if you are interested in further improvements, a

Re: [Kicad-developers] [PATCH] GerbView GAL support

Hi Orson, Tom, Thanks for the tips. I eventually did figure out what was going on -- mismatch of state between the RTREE and the View in my first attempt at optimization. The attached 3 patches improve performance a ton on larger Gerber files -- on my computer, between 30-40% improvement, and

Re: [Kicad-developers] [PATCH] GerbView GAL support

Le 21/09/2017 à 14:04, Wayne Stambaugh a écrit : > Orson, > > I'm leaving this decision up to you and JP since I have not had time to > test it. JP, do you have any other concerns about this? Sorry for the delay, but I was away last 3 days. I do not have concerns about merging Gerbview GAL. We

Re: [Kicad-developers] [PATCH] GerbView GAL support

On 22.09.2017 04:04, Jon Evans wrote: > Hi Orson, > > I have dug into Seth's report of slowness on this large Gerber file, and > reproduced it. > It looks like VIEW is struggling under the load of all the items, so > this is a generic GAL problem, but Gerber files in general have many > more draw

Re: [Kicad-developers] [PATCH] GerbView GAL support

Hi Jon, I am not entirely sure about the problem root cause, but there are some hints: - VIEW_GROUP uses a list of items obtained via its virtual updateDrawList() method - SELECTION class, which represents the selected items (visually as well) is a VIEW_GROUP, but its overridden updateDrawList()

Re: [Kicad-developers] [PATCH] GerbView GAL support

Hi Orson, I have dug into Seth's report of slowness on this large Gerber file, and reproduced it. It looks like VIEW is struggling under the load of all the items, so this is a generic GAL problem, but Gerber files in general have many more draw items than PCB files, so we only notice it now. I

Re: [Kicad-developers] [PATCH] GerbView GAL support

Hi Jon- Sorry, my wording was bad. This is not a merging show-stopper. Legacy use is unaffected. Best- Seth On Thu, Sep 21, 2017 at 11:55 AM, Jon Evans wrote: > Hi Seth, > > Thanks for reporting and providing your example file. I will investigate > this issue, but is

Re: [Kicad-developers] [PATCH] GerbView GAL support

Hi Seth, Thanks for reporting and providing your example file. I will investigate this issue, but is this actually a show stopper for merging? Can't you just keep using legacy canvas? Thanks, Jon On Thu, Sep 21, 2017 at 2:47 PM, Seth Hillbrand wrote: > -- Apologies

Re: [Kicad-developers] [PATCH] GerbView GAL support

Orson, I'm leaving this decision up to you and JP since I have not had time to test it. JP, do you have any other concerns about this? Thanks, Wayne On 9/21/2017 6:05 AM, Maciej Sumiński wrote: > Hi Jon, > > Thanks you, this is really cool! Now it is even more tempting to merge > the

Re: [Kicad-developers] [PATCH] GerbView GAL support

Hi Jon, Thanks you, this is really cool! Now it is even more tempting to merge the gerbview_gal branch. I am going to wait one more day for vetos and tomorrow I will push it to the master branch. Regards, Orson On 09/20/2017 09:57 PM, Jon Evans wrote: > Hi Orson, > > Give this a shot in your

Re: [Kicad-developers] [PATCH] GerbView GAL support

Hi Orson, Give this a shot in your branch. It should work in pcbnew also now. -Jon On Wed, Sep 20, 2017 at 9:28 AM, Jon Evans wrote: > Hi Orson, > > Thank you for staging this for merge on your branch. I checked and you do > have all the patches. > > 1) Yes I planned on

Re: [Kicad-developers] [PATCH] GerbView GAL support

Hi Orson, Thank you for staging this for merge on your branch. I checked and you do have all the patches. 1) Yes I planned on refactoring the selection tool once things stabilized with the highlighting etc. 2) Do you mean when you are highlighting Gerber X2 attributes, or when you are

Re: [Kicad-developers] [PATCH] GerbView GAL support

Hi Jon, GALifying GerbView is a huge task, so thank you very much for your work! I have just tested your changes and in my opinion it is in a state that deserves merging and further tests. The new way of item highlighting is awesome, we need to port it to pcbnew as well. For now I keep your

Re: [Kicad-developers] [PATCH] GerbView GAL support

Hi Jon, On 19.09.2017 00:55, Jon Evans wrote: > While I'm waiting for review I made another small fix I've tried building for MSYS[1], and failed, because GAL::SetNegativeDrawMode() doesn't exist. Is that in a different patch? Just the first five patches:

Re: [Kicad-developers] [PATCH] GerbView GAL support

While I'm waiting for review I made another small fix On Sun, Sep 17, 2017 at 9:04 PM, Jon Evans wrote: > One follow-on patch attached after I realized that a fix hadn't made its > way in. > -Jon > > On Sun, Sep 17, 2017 at 6:47 PM, Jon Evans wrote: > >>

Re: [Kicad-developers] [PATCH] GerbView GAL support

One follow-on patch attached after I realized that a fix hadn't made its way in. -Jon On Sun, Sep 17, 2017 at 6:47 PM, Jon Evans wrote: > Hi all, > > The day has finally come! I have distilled my GerbView GAL branch into a > patchset attached to this email. Hopefully with